Commit Graph

13 Commits (75a5927d4f1f342b39ccf9ea192fddf43070be1a)

Author SHA1 Message Date
jochen@chromium.org a3683bbbee Enable CheckRietveldTryJobExecution for git-cl.
Review URL: http://codereview.chromium.org/1993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46923 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
rsesek@chromium.org 0dfc4ef271 Catch ValueErrors when trying to convert the CL issue number in git presubmit hooks
BUG=31695
TEST=none
Review URL: http://codereview.chromium.org/528004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35816 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
rsesek@chromium.org 4c098c8509 When running git presubmit hooks, use the changelist's description,
rather than the local commit message's.

BUG=31695
TEST=git cl upload where commit message is missing BUG= but CL description has one. No presubmit error.
Review URL: http://codereview.chromium.org/523101

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@35682 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jrg@chromium.org 4c3171835b --replace-all so we don't accum variables
Review URL: http://codereview.chromium.org/504002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34500 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
chase@chromium.org 745435c320 Fix git 1.6.1 vs 1.6.5 underscore key issue. (Hooks side.)
BUG=none
TEST=git cl upload sets watchlist extracc on rietveld
issues
Review URL: http://codereview.chromium.org/460125

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@34078 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jrg@chromium.org 3db8719858 http://codereview.chromium.org/460038
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33716 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ada4c65e1c Minimalist breakpad implementation.
Client-side implementation.

TODO: Need to automatically disable it for unit tests.

Review URL: http://codereview.chromium.org/444009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33681 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
chase@chromium.org 37c629a3b1 Call git diff --name-status with a relative path.
On a new Linux box, during git cl dcommit I observed
the error:

  fatal: invalid diff option/value: -r

This was caused by the git cl presubmit hooks running:

  git diff --name-status -r refs/remotes/origin/trunk.. /path/to/src

By passing a relative path (given by git rev-parse
--show-cdup) instead of an absolute path for
/path/to/src, git diff --name-status does not print an
error and returns the expected list of changed files.

Also fix some broken scm and gclient_scm unit tests.

BUG=none
TEST=git presubmit hooks work from main working
directory
Review URL: http://codereview.chromium.org/438012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32999 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 5aeb7dd54c Reapply 32057, 32058, 32059, 32062 and fixes problems introduced by these changes.
Noteworthy change is scm.SVN.GetFileProperty calls Capture instead of Run.

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/399009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32181 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 261eeb5e93 Revert 32057, 32058, 32059, 32062 because they still have unwanted side-effects.
Revert "Group SCM-specific functions in classes to simplify generalization of the interface."
Revert "Fix 2 recently introduced errors."
Revert "Fix a variable aliasing error."
Revert "Fix typo."

TBR=dpranke
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/391075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32065 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 4b5321ac01 Fix typo.
TEST=presubmit check
BUG=none

Review URL: http://codereview.chromium.org/400002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32062 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 85a3192f9c Group SCM-specific functions in classes to simplify generalization of the interface.
TEST=none
BUG=none

Move scm functions into a class to make it simpler to manage.

Review URL: http://codereview.chromium.org/391052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32057 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
chase@chromium.org 7658eb3c12 Alter hooks to call into depot_tools lib.
This new method allows us to install pre-cl-upload
and pre-cl-dcommit hook files which should rarely need
to be updated (with luck).  These hooks load the real
hooks lib from depot_tools which takes over execution
of the presubmit tests.

BUG=5339
TEST=hooks are run by git cl upload/dcommit and behave
as expected
Review URL: http://codereview.chromium.org/243118

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28409 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago