Commit Graph

3585 Commits (73baf8534877e82eb7c4e96aba0f122e39f6e2ee)
 

Author SHA1 Message Date
agable 73baf85348 Update gclient test to assert both dir and url
This makes it easier to reason about tests which care about
both the url being fetched and the directory to which it is
being fetched, like those concerning relative paths and
recursion.

R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2316963004
9 years ago
dsansome e2d6fd987e Prompt to delete pending edits before changing the Gerrit CL description.
BUG=641838

Review-Url: https://codereview.chromium.org/2318903002
9 years ago
hinoka eb20eaeced Copy over bot_update_coverage_test.py
BUG=

Review-Url: https://codereview.chromium.org/2316393002
9 years ago
bpastene 4dcad385f4 Revert of Delete lots of svn logic from bot_update (patchset #5 id:80001 of https://codereview.chromium.org/2280213002/ )
Reason for revert:
Everything's purple :(

Original issue's description:
> Delete lots of svn logic from bot_update
>
> R=hinoka@chromium.org
> BUG=472386
>
> Committed: 082267a659

TBR=hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472386

Review-Url: https://codereview.chromium.org/2320653003
9 years ago
bpastene 2a3e9913be gclient: Prune dangling remote tracking refs when fetching with --force
BUG=644722

Review-Url: https://codereview.chromium.org/2320573005
9 years ago
agable 082267a659 Delete lots of svn logic from bot_update
R=hinoka@chromium.org
BUG=472386

Review-Url: https://codereview.chromium.org/2280213002
9 years ago
tandrii 8da412cf5a Remove redundant output in git_cl.py tests.
R=agable@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2319903002
9 years ago
martiniss 925b910ac3 Revert of Require recipe tryjob in CQ (patchset #1 id:1 of https://codereview.chromium.org/2157503003/ )
Reason for revert:
Downstream tester messed up now, see https://crbug.com/644609

Original issue's description:
> Require recipe tryjob in CQ
>
> BUG=628801
>
> Committed: ac74456f1e

TBR=phajdan.jr@chromium.org,estaab@chromium.org,iannucci@chromium.org
NOTRY=true
(no try because the tester itself is broken)
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628801, 644609

Review-Url: https://codereview.chromium.org/2322763002
9 years ago
andybons f0b0378318 Remove gerrit_rebase_patch_ref flag from bot_update API
BUG=612417

Review-Url: https://codereview.chromium.org/2317213002
9 years ago
agable fbfa601efd Remove svn from gclient recipe module example
R=martiniss@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2318843002
9 years ago
iannucci 045d107c23 Remove patch_url from bot_update.
R=hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2310113003
9 years ago
iannucci 95f3d317e4 Just disable force to ensure that bot_update really is running everywhere.
This makes it so that regardless of what force is set to in the recipe, if you
invoke bot_update.ensure_checkout, it will actually run.

Removal of the force option (and related options) to come shortly.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2311673002
9 years ago
qyearsley 274c159b29 Proofread README.git-cl.md.
This CL just contains spelling changes, a minor rewording, and addition of backticks for commands.

Review-Url: https://codereview.chromium.org/2296393003
9 years ago
estaab f1fcda41c1 Docs: Fix git retry usage flag name.
BUG=

Review-Url: https://codereview.chromium.org/2304393002
9 years ago
recipe-roller 02dbeb85d7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b79776cf2fbb4822372bbc03ee9a44318c23af8c Add more information to the README.md (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2308003003
9 years ago
recipe-roller 295b220ddd Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/11cda51b49aeaa3d56af70eb138ea28eabdd16bd Implement simple step whitelisting in recipe_engine. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2308883002
9 years ago
dnj ba1b0f3795 git_cl: Enable updating description from local.
Currently, if one edits one's local CL description (e.g., `git commit
--amend`), there is no path for that update to get pushed to Rietveld.
This adds a "+" sentinel to the "-n" flag for `git cl description` that
tells it to load description content from the local commit.

The description should match what would be generated by "git cl upload".

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2307463002
9 years ago
tandrii 4cb6fb7fbd bot_update: don't forget to apply Gerrit patches for DEPS-ed in projects.
R=machenbach@chromium.org,andybons@chromium.org
BUG=602906
TEST=manual run of Angle recipe locally

Review-Url: https://codereview.chromium.org/2299693003
9 years ago
qyearsley 53f48a1c52 Add a --json option to git cl try-results.
For use in scripts that check try job results, this is
currently practically the same as making requests to
https://codereview.chromium.org/api/<cl-number>/<patchset-number>.

However, I think that this might be more future-proof, since
it fetches try job information from Buildbucket, and I expect
to still work after migration from Rietveld to Gerrit.

BUG=640354

Review-Url: https://codereview.chromium.org/2274743003
9 years ago
recipe-roller b6441d3a6e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6ac56ce6c1693f924a5e1efaef28c792c3ce1052 Warn if no valid SSL python libraries installed (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2299233002
9 years ago
scottmg 86099d7ce5 Shutdown multiprocess pool after running tests to avoid _finalizer spew on Windows
Can't just let the GC collect the pool on Windows.

R=tandrii@chromium.org
BUG=618726

Review-Url: https://codereview.chromium.org/2296723006
9 years ago
andybons 6911b06750 Make rebase and sync the default for Gerrit updates.
BUG=602906
R=tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: tandrii@ takes responsibility.
Review-Url: https://codereview.chromium.org/2298883002
9 years ago
iannucci f3458f046e Roll recipe dependencies (MANUAL).
Additions:
  * Remove PYTHONUNBUFFERED for svn tests

This obviates https://codereview.chromium.org/2298863002/.

recipe_engine:
  https://crrev.com/09345f9dcf4d2744f66d64766fd349ddf04f04ce Cancel PYTHONUNBUFFERED when unbuffered is explicitly set to False (iannucci@chromium.org)

TBR=martiniss@chromium.org, phajdan.jr@chromium.org
BUG=635641

Review-Url: https://codereview.chromium.org/2298893002
9 years ago
tandrii 7b787b8642 Revert of It's time to bring subprocess42 to depot_tools. (patchset #1 id:1 of https://codereview.chromium.org/2291223003/ )
Reason for revert:
Speculative revert because it might be breaking presubmit in depot_tools.

Original issue's description:
> It's time to bring subprocess42 to depot_tools.
>
> The immediate need is to properly kill git fetch and its sub-spawned
> process from gclient.
>
> R=maruel@chromium.org, hinoka@chromium.org
> BUG=635641
>
> Committed: 6d3c290164

TBR=hinoka@chromium.org,maruel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641

Review-Url: https://codereview.chromium.org/2295043003
9 years ago
Andrii Shyshkalov 6d3c290164 It's time to bring subprocess42 to depot_tools.
The immediate need is to properly kill git fetch and its sub-spawned
process from gclient.

R=maruel@chromium.org, hinoka@chromium.org
BUG=635641

Review URL: https://codereview.chromium.org/2291223003 .
9 years ago
recipe-roller 06e2710700 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a93ebc8b69c18bce873f4df1979b6534f3c13e68 Organize environment whitelist, add PYTHONUNBUFFERED. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2290293004
9 years ago
tandrii db8b839320 bot_update/gclient: kill git fetch after timeout regardless of output.
Also spits out whatever output was produced by git fetch for debugging.

BUG=635641
R=machenbach@chromium.org,hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2293013002
9 years ago
machenbach 26a201f2a9 Revert of Delete roll-dep-svn (patchset #1 id:1 of https://codereview.chromium.org/2282223002/ )
Reason for revert:
Still in use. Breaks the v8 auto-rollers.

https://cs.chromium.org/search/?q=roll-dep-svn&sq=package:chromium&type=cs

Original issue's description:
> Delete roll-dep-svn
>
> R=dnj@chromium.org
> BUG=475320
>
> Committed: 96ebc1d0e1

TBR=dnj@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475320

Review-Url: https://codereview.chromium.org/2297513002
9 years ago
agable c8f3a3498e Remove non-trivial SVN config from gclient recipe module
R=martiniss@google.com
BUG=640251
Recipe-Tryjob-Bypass-Reason: can't mock expectation changes downstream

Review-Url: https://codereview.chromium.org/2285213004
9 years ago
agable 9741c590a4 Remove defunct SVN-based gclient configs
The URL helper functions were only used by this file,
the svn custom_deps urls aren't referenced in any DEPS
files I can find anymore, and the oilpan and buildspec
configs aren't used by any recipes.

R=hinoka@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2291583003
9 years ago
thomasanderson 074beb2e46 Add --stat option to git-cl diff
Review-Url: https://codereview.chromium.org/2285393002
9 years ago
agable 96ebc1d0e1 Delete roll-dep-svn
R=dnj@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2282223002
9 years ago
tandrii 81665dcf76 Add more debugging in presubmit owners check for Gerrit.
BUG=641384
R=phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2293523002
9 years ago
Paweł Hajdan, Jr 42ffe773c3 win_tools.bat: call git_bootstrap.py, remove deprecated svn bootstrap
BUG=635421, 629679
R=tandrii@chromium.org

Review URL: https://codereview.chromium.org/2286333002 .
9 years ago
tandrii c4344b5958 Fix Gerrit git cl land and add test.
R=andybons@chromium.org
BUG=641127

Review-Url: https://codereview.chromium.org/2280563003
9 years ago
agable 7090f652d1 Remove all references to GIT_MODE from depot_tools
BUG=640251,472386

Review-Url: https://codereview.chromium.org/2286793003
9 years ago
hinoka 0b7cf885e0 Remove Deps2Git references from bot_update.py
BUG=

Review-Url: https://codereview.chromium.org/2283043002
9 years ago
phajdan.jr 5224ece27c git_bootstrap.py: add a switch to control client bitness
BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2280973002
9 years ago
tandrii f8757b7e02 gclient: kill git fetch operation that hangs.
This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER
that kills git fetch if it produces no output for that
many seconds.

Note that this is not final patch, but an experiment.
See http://crbug.com/635641#c24 for the deployment plan.

BUG=635641
R=hinoka@chromium.org

Review-Url: https://codereview.chromium.org/2241843002
9 years ago
agable 4b21db06e4 Default gclient's GIT_MODE to True
Also contains some other changes (to the example, and to safesync url)
in order for test coverage to remain complete. Will be followed shortly
by a wholesale removal of svn support from the gclient module.

R=iannucci@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2270083004
9 years ago
agable f14eaff814 Remove --base_url from git cl and upload.py
R=tandrii@chromium.org
BUG=638750

Review-Url: https://codereview.chromium.org/2271873003
9 years ago
agable 92bec4f56f Delete gcl, drover, and trychange
These tools are relatively standalone, and only ever worked for SVN.
Removing these is a good start to removing other SVN support code.

R=maruel@chromium.org
BUG=475321

Review-Url: https://codereview.chromium.org/2269413002
9 years ago
qyearsley 12fa6ff69b Run auto-spell-checker (codespell) on files in depot_tools.
This should only change spelling in:
 - messages that are printed
 - comments
 - docstrings

Review-Url: https://codereview.chromium.org/2277513002
9 years ago
qyearsley eab3c04311 Change "tryjob" -> "try job" in git_cl.py and trychange.py.
I know this is an unimportant change, and that across Chromium,
"try job" and "tryjob", and "try bot" and "trybot" are basically
interchangeable, still I think it's nice to have the spelling
consistent within one module.

I prefer the version with a space just because that's what's used
in the documentation:
https://www.chromium.org/developers/testing/try-server-usage

Review-Url: https://codereview.chromium.org/2269283002
9 years ago
recipe-roller b9f5e3796c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b9c3996241af9c5b0d60c0e7670897ecc3894e46 Fix recipes.py remote on Windows (phajdan.jr@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:639891,chromium:584079

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2271803003
9 years ago
agable 75e7fc2af1 Just use git refs for lkcr and lkgr
R=iannucci@chromium.org, martiniss@chromium.org
BUG=640251
Recipe-Tryjob-Bypass-Reason: None of the affected recipes need safesync anyway, will manually roll

Review-Url: https://codereview.chromium.org/2268893004
9 years ago
recipe-roller 37ac639b57 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/772978c9b350224f62085c258408a02dcd97986c Remove preloaded 'google' module (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=638824

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2274673002
9 years ago
kmarshall 9249e01b70 git cl archive: Add "--dry-run" and "--notags" flags.
This CL adds a couple flags to "git cl archive".
dry-run: Lists the cleanup tasks, but exits before any changes are
made to Git.
notags: Deletes branches only; does not create archival tags.

R=tandrii@chromium.org,groby@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2276663002
9 years ago
tandrii 33a46ffb3f git cl: workaround against integer overflows of git config.
R=maruel@chromium.org,phajdan.jr@chromium.org
BUG=640115

Review-Url: https://codereview.chromium.org/2272613002
9 years ago
tandrii e594e21959 Add git cl bash completition.
R=maruel@chromium.org,emso@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2269593002
9 years ago