Commit Graph

453 Commits (6fb1090c8e3f6a8840406da4779f79514c58d0bd)
 

Author SHA1 Message Date
maruel@chromium.org 6fb1090c8e e.stderr may be None
Review URL: http://codereview.chromium.org/1272003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42505 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org d08cb1e848 Fix import of simplejson included in depot_tools
TEST=verified it works in python 2.4
BUG=none

Review URL: http://codereview.chromium.org/1110006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42177 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 59c7ba6b87 Add simplejson 2.1.0 and use it when it's not already installed.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/1105007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42175 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 3fbcb08a1d Add new canned checks: CheckRietveldTryJobExecution and CheckBuildbotPendingBuilds
These are the same that the one in chromium's src/PRESUBMIT.py but slightly more
resilitent to exceptions.
Empirical studies have shown that exceptions in presubmit checks result in
disorientation and lack of willingness to commit.

TEST=OMG new unit tests!

Review URL: http://codereview.chromium.org/1119003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@42102 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org fb11c7b98d Add input_api.json to presubmit checks.
Review URL: http://codereview.chromium.org/1116001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41973 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 57af171055 Fix support with python 2.6 without simplejson.
Review URL: http://codereview.chromium.org/1050005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41902 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org dc06a86855 Write the progress bar to stdout, not stderr
Requested-By: Pawel Hajdan Jr. <phajdan.jr@chromium.org>

Review URL: http://codereview.chromium.org/896006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41586 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org 7080e94277 Fix @hash in DEPS file
Broken by the @branchname support

Review URL: http://codereview.chromium.org/907004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41585 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org de8f352ebb r41078 broke revinfo for .gclient files with multiple solutions
This commit fixes that, though the --snapshot option doesn't work perfectly.

Review URL: http://codereview.chromium.org/900001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41351 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 55e724e8fe Stop SVNWrapper and GitWrapper from inheriting from scm.SVN and scm.GIT.
This simplifies the unit tests and clarify what is what.

Ran pychecker on a few files.

Review URL: http://codereview.chromium.org/874002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41310 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org d0f854af68 Extract git version check code from gclient_scm.py into scm.py where it belongs.
Review URL: http://codereview.chromium.org/878001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41308 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jeffbailey@google.com e0ff00dcec Set bootstrap Python version to 2.6
Review URL: http://codereview.chromium.org/873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41303 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org e3da35f6ca Add a --snapshot option for revinfo. If set, revinfo prints a .gclient file
set to sync to the current revisions/hashes on disk

Add a --gclientfile=FILENAME option.  If set, gclient loads FILENAME
rather than .gclient for configuration info.

Patch contributed by jneddo@nvidia.com

BUG=1658
TEST=Verify that --snapshot prints a valid configuration file
     Verify that when --gclientfile is set the correct file is used
     Verify that gclient sync --gclientfile sets the correct revisions

Review URL: http://codereview.chromium.org/672004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@41078 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jam@chromium.org 83b6e4ba08 Add ability to specify that all issues are pivate in codereview.settings
TBR=maruel
Review URL: http://codereview.chromium.org/702001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@40992 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org 3b29de12a8 Ensure --revision is used when specified
BUG=http://crosbug.com/1669

Review URL: http://codereview.chromium.org/661229

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@40911 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 4baa0ad6d7 Fix --webkit trychange.py option.
Review URL: http://codereview.chromium.org/669243

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@40877 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 0b1c246cd7 Add automatic retry on "git remote update".
It does remote connection and can get HTTP 502 when used over http.

Review URL: http://codereview.chromium.org/661280

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@40330 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org 952d7c74f4 Fix revinfo with git
BUG=37104
BUG=chromium-os:1658

Review URL: http://codereview.chromium.org/660299

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@40294 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org ece406f5b9 Require git version 1.6.6
Review URL: http://codereview.chromium.org/652125

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39741 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org d90ba3f136 sync @branchname git support
Also improve GIT.update error handling and verbosity levels

TEST=unit tests
BUG=http://crosbug.com/480
BUG=http://crosbug.com/1136

Review URL: http://codereview.chromium.org/559003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39717 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
jochen@chromium.org 0b9e693a9b Add option --local allowing for merging changes into a local working copy.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/651022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39603 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
davemoore@chromium.org 8bf2731ded Forgot to include the test change.
Review URL: http://codereview.chromium.org/650039

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39458 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
davemoore@chromium.org 793796dcc6 Add gcl-reset option.
Review URL: http://codereview.chromium.org/647063

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39457 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
derat@chromium.org e08f491731 depot_tools: Make git-cl wrapper not fail when repo is missing.
I broke this in my last change.

TBR=msb
Review URL: http://codereview.chromium.org/627004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39277 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
derat@chromium.org b7ec6aa923 Make git-cl wrapper print errors instead of silently deleting repos.
It would previously delete and recreate git-cl-repo if it
saw that the remote was different than expected.  This looks
like it was added for the transition from the old SVN repo
to the new git one, but it also has the effect of losing
any local changes that have been made in the repo. :-(

Everyone should be updated by now, so print a helpful error
and exit instead.
Review URL: http://codereview.chromium.org/609002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39099 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
kbr@google.com 296df6603b Modified default blacklist regexp to match nothing, as empty regexp
was matching everything. See
http://stackoverflow.com/questions/940822/regular-expression-syntax-for-match-nothing/940856 .

Review URL: http://codereview.chromium.org/601064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38965 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 8599aa7da2 Fix failure to contain the line entry instead of constant "True"
TEST=none
BUG=34793

Review URL: http://codereview.chromium.org/591002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38382 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 81f6eea287 Make git-try --webkit work like it used to work.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/570059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38337 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 2de10250a2 Add automatic retry on HTTP 502 for svn and connection drop for git.
TEST=totally untested
BUG=34793

Review URL: http://codereview.chromium.org/574017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38336 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org 1f7a3d1d6d Add progress indicator for sync
Review URL: http://codereview.chromium.org/564051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38104 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ba55177642 Fix licensing headers and move most third party code to third_party/
Moved tests/pymox to third_party/pymox
Moved upload.py to third_party/upload.py
Fixed tests so they can run standalone
Fixed the executable bit on some scripts

TEST=none
BUG=34376
Review URL: http://codereview.chromium.org/562031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37987 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org d4fd8823b9 fix git-try broken by CheckCall return type change
Review URL: http://codereview.chromium.org/561001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37750 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org de707484e8 Add windows ignores to .gitignore, mostly useful for cygwin users
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/557082

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37710 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 99ab6776f4 Add codereview.settings to depot_tools.
I'm doing this while trying to figure out the best way to make git-cl
auto-configure itself on first use, including automatic presubmit scripts hook
setup.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/559002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37709 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org b65040abbf Fix a FetchUpstreamTuple cwd bug
in_directory was not being set to the correct cwd. This caused commands to
always run in the dir from which gclient was executed.

Review URL: http://codereview.chromium.org/554142

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37697 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org e42a1939f1 Fix for git-svn rebase bug
git-svn rebase will always output 'Current branch <> is up-to-date' when the
branch is up-to-date, even if you pass the --quiet flag(s). This change
specifically squelches that message.

Review URL: http://codereview.chromium.org/555183

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37696 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 61148d07dc git-try was broken by r37650
TEST=none
BUG=none
TBR=nasser

Review URL: http://codereview.chromium.org/548223

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37692 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
nasser@codeaurora.org cd968c1833 Always return a tuple from GIT.Capture
Review URL: http://codereview.chromium.org/555198

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37685 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 7be5ef2ed0 Change CheckCall behavior when print_error=False
We now return the stderr half of the tuple.
This required a clean up of any usage of CheckCall and GIT.Capture.

Patch contributed by Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/551215

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37650 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 519a8dd376 Using options.email for svn credential is not a good idea.
It breaks the use case when a dev outside corp wants to send a job's email to someone else.

Review URL: http://codereview.chromium.org/558062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37644 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 56ca2c246c Remove stale revert.py unit test and fix another test I broke in r37487.
TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/556092

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37618 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 5f423140ba Simplify submitting try jobs directly from rietveld.
trychange.py -R <review_url> is sufficient for try jobs when in a checkout directory.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37616 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org c19d95a4e0 Delete the revert.py tool.
It's been replaced by drover a year ago.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553145

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37487 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org a73d793164 Fix the regexp in DEFAULT_WHITE_LIST.
For example, r".*\.c" was triggering for foo.checksum.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/558026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37461 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
msb@chromium.org 8912ead3b4 gclient: Keyboard interrupt should not cause request to send stack
Patch-contributed-by: Alexey Marinichev <amarinichev@chromium.org>

Review URL: http://codereview.chromium.org/553139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37434 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ef77648dd4 Change the default source lists;
Remove *.txt and *.json, add *.pl and *.pm.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/548172

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37406 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
estade@chromium.org 593258b903 Add a trailing \ when printing filenames for presubmit checks.
This makes it easier to apply commands to a set of files. For example:

Run the command: svn pset svn:eol-style LF \
  chrome/browser/extensions/extension_accessibility_apitest.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.cc \
  chrome/browser/extensions/extension_accessibility_api.h \
  chrome/browser/extensions/extension_accessibility_api.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.cc \
  chrome/browser/gtk/accessibility_event_router_gtk.h \
  chrome/browser/gtk/accessibility_event_router_gtk.cc \
  chrome/common/accessibility_events.cc \
  chrome/common/accessibility_events.h

requires just 1 copy-paste.

Review URL: http://codereview.chromium.org/552202

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37350 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org b9e7adaa82 Add presubmit_canned_checks.CheckLicense()
It does a regexp search on the file contents to make sure it contains expected license boiler plate.

It is a generalization to implement the equivalent of ubuntu's license check script into the corresponding PRESUBMIT.py files.

TEST=unit tests
BUG=28291

Review URL: http://codereview.chromium.org/558007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37338 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
laforge@chromium.org 3529954d9f Fix branching regex to match .*? and not /d+ so that it will match "249s" in
addition to "249"
Review URL: http://codereview.chromium.org/553108

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37203 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
thestig@chromium.org 172b6e7451 Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we had it before, except with an updated CC_LIST.
BUG=none
TEST=Using gcl from src/third_party/WebKit sends code reviews to codereview.chromium.org.
Review URL: http://codereview.chromium.org/552144

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37069 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago