This reverts commit ae21f6a5ec.
Reason for revert: crbug.com/1462502#c11
Original change's description:
> New vpython to depot_tools
>
> 1. virtualenv field in the spec is ignored.
> 2. --vpython-tool removed support for delete and help subcommands.
> 3. --vpython-tool installed removed support for naming venv.
> 4. removed support for -vpython-interpreter.
> 5. removed support for searching interpreters in host PATH.
> 6. python 2.7 is available only if the binary is invoked as `vpython`.
> 7. fixed a bug that passes invalid vpython arguments to the script,
> which may be silently ignored.
> 8. python_version in the vpython_spec must specify a minor version
> (python_version: "3" is not valid anymore).
> 9. vpython now requires the cipd binary to be present in PATH, which is
> true already when using Swarming or depot_tools.
>
> Also updates the LUCI_OWNERS to add peep-software-deploy team.
>
> Bug:1415212
> Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Chenlin Fan <fancl@chromium.org>
Bug: 1415212
Change-Id: I3d00edf7d2a0d61d30b263362d35704d9f63a44d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4668482
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
1. virtualenv field in the spec is ignored.
2. --vpython-tool removed support for delete and help subcommands.
3. --vpython-tool installed removed support for naming venv.
4. removed support for -vpython-interpreter.
5. removed support for searching interpreters in host PATH.
6. python 2.7 is available only if the binary is invoked as `vpython`.
7. fixed a bug that passes invalid vpython arguments to the script,
which may be silently ignored.
8. python_version in the vpython_spec must specify a minor version
(python_version: "3" is not valid anymore).
9. vpython now requires the cipd binary to be present in PATH, which is
true already when using Swarming or depot_tools.
Also updates the LUCI_OWNERS to add peep-software-deploy team.
Bug:1415212
Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
This would add support for uploading/installing Xcode with MacOS13 adoption
Bug: 1441931
Change-Id: I81e8edc0761548b6650535f3ac6b6c504673e6a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4532378
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Yue She <yueshe@google.com>
Fixes issue where reclient erroneously shutdown during startup via
bootstrap.
BUG=b:269549741
TEST=Run bootstrap locally using the new version specified in this
change.
Change-Id: Ic443ba48d4d976a5341847bd7855e7d7fb63cc61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4445369
Commit-Queue: Eric Lok <lokeric@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Eric Lok <lokeric@google.com>
Adding back reclient to depot tools. This will allow it to be used for
chromeos-chrome builds, and other packages in the future as well
Bug: b/270080866, b/242680623
Change-Id: Ibb800a7c36f61312d540ee5595c585493e5e3578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4273546
Commit-Queue: Eric Lok <lokeric@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Fixed issue where token to paste was refreshing fast and made it difficult to copy in terminal emulators such as Alacritty and Konsole.
Bug:1411481, 1406354
Change-Id: I260c18c4aca873530d7ead55ab8826b01edffd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4231602
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
This is a minor patch that will fix the error that arises from having no config file when running lucicfg valdate.
Bug:1412186
Change-Id: Ie7432354d382fa88b45d1668e6d6476d2530898c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226560
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Auto-Submit: Riley Wong <rgw@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Version updates lucicfg fmt/validate/lint to add conditional formatting rules based off path.
Change-Id: I0870c142210f95e75356ef2cc9d94f4e265f8c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215131
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Per go/oauth-oob-deprecation we are switching to go/luci-cli-oauth-login updating the packages that use luci-auth.
Bug:1406354
Change-Id: I3fc0fd2cc88d395f28e080d90aaaaae672c33da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4195020
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Leina Sun <sunxiaodi@google.com>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
Reviewed-by: Sean McCullough <seanmccullough@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
triggered_by in CQ configs has now not been used by any projects
for a month. This is a deprecated property that we don't
support anymore in CV.
location_regexp and location_regexp_exclude has been replaced by location_filters and is not used in any projects any more.
Related buildbucket config change at
https://chrome-internal-review.googlesource.com/c/infradata/config/+/5229868
Bug: 1395209
Change-Id: I4e53606c8bcd7a784970beb337984a808321c5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4113683
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
This reverts commit fa0a108281.
Reason for revert: Creating a null pointer issue
Original change's description:
> Updating Lucicfg V 1.35.0 to 1.35.1
>
> Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue
>
> Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Riley Wong <rgw@google.com>
Change-Id: I47c56e110f0b3acc2011fa0c169d979297856a3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072086
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue
Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Including this change:
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3777409
This was tried before, but didn't stick because legacy CQ doesn't
handle location_filters; now almost all projects are migrated to CV.
Bug: 1171945
Change-Id: I6a5734922973dd8b506dc018d8838a6f2dacd271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3965089
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Changes in this release:
55ee5cd215996e99b807bd19060f8c6845423985 Switch to a buffered channel.
c18f898c8628f7063328a553de31b5a13ebbd47a Fix comment typos.
c55184b5835c789d073ce8ba10745cc7efedcd65 Fix typo
50e0d6a61bf2706e8096a4c3785331f2fa1f2bad Fix some warnings that are causing presubmit errors for the 2.7 fork.
39ca9cb80c0c7f5a18bcdcc6ce65bfdb1cc64879 Update vpython deployment doc
c93fd3c5ebdc3999eea86a7623dbd1ed4b40bc78 Roll chromiumos/config manually to fix the broken roller
149a1934123a29ca32c85f73597e7ffbfa7dbf4a Add initial PRESUBMIT support for linting python3
Change-Id: I1155342ace04e2944a9abe531e0f8b5d0206a0eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3951269
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
This will be used in ChromeOS build_packages.
Bug: b/242680623, b/203606263
Change-Id: I3eedec7b245405c24091db43a450181a270d1305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3833266
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
The roll in depot_tools enables uploading Xcode in legacy format and
not excluding some folders at upload.
Bug: 1348212
Change-Id: I2a6b635a6c236bf2eedbbf7855da3c0d58b4abaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3834034
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
This reverts commit a2267932e6.
Reason for revert: this version has an issue with led edit-recipe-bundle https://crbug.com/1350060
Original change's description:
> Update led to the current version.
>
> This will pull in the change that allows for "led edit-cr-crl" to accept
> URLs in the form output by "git cl issue": URLs that do not contain the
> gerrit project.
>
> Bug: 1348269
> Change-Id: Icb360686c9ca1548636e755bc9a611351d78d2f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3807651
> Commit-Queue: Garrett Beaty <gbeaty@google.com>
> Reviewed-by: Chan Li <chanli@chromium.org>
Bug: 1348269
Change-Id: Idad964cf47b0cbc7174201add38ab8799c1ae9b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3812817
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
This will pull in the change that allows for "led edit-cr-crl" to accept
URLs in the form output by "git cl issue": URLs that do not contain the
gerrit project.
Bug: 1348269
Change-Id: Icb360686c9ca1548636e755bc9a611351d78d2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3807651
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
Includes this change:
85ebd26fca
This changes the generation of location_filters from location_regexp
in some cases.
Bug: 1171945
Change-Id: I233281adb2edd62771f47ccb941fa99ade628f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3799232
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Contains commits:
7979d954927af292bd5a57dd398a9791cc43099c Use the full paths of bundled interpreters.
ededcc9ee88d285f6c1ea6154b0c61da5cc6fd6a Provide a way to pass in the full python executable path.
376c57dec286030d5321b4aeffbbc26dd297d28c Add a test that inheritable file handles are passed through to Python.
Bug: 1318617
Change-Id: Ib163c6b8d88667dcec5afe975006586d13b2b2f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3787826
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
This release contains commits:
e74f8f68337ee619d400e0b6607cbe9df37f78ee Fix so that Python inherits file handles again on Windows.
059bcab0fb866cf8b9bc25b5845beeb8ee90fe3d Bundle the python interpreter on Mac.
e2552b1a6ebed6651aceb5a7ab4639c0d69c0c0e Resolve symlinks when finding the vpython executable.
d5fc7bca58e458258f8c3b8a25ecd070c77581ac Roll infra/go/src/go.chromium.org/luci/ ee2c632ce..82d549a81 (1 commit)
5d9b6ecf87cdfb928e1112d2838d26bc7ede2b48 Roll infra/go/src/go.chromium.org/luci/ 0480658b5..0535bf685 (5 commits)
3076679301d2b9b040bce2c871a63ddc49273c41 [environ] Rename Get => Lookup, GetEmpty => Get.
37f02f9f91aa3918b195931fbcf02750290d0571 Search bundled python paths before looking in PATH.
a4136aa4d9e8c359bcf234fcd6ae026fb5b92925 [go] Format all files.
8349853d4517895a2c5838a00aea3e368ce3f865 [vpython] Make TestLoadForScript pass on OSX when running locally.
d94b5704d8ad151a0306974a1a949d8057c44a18 Revert "Add support for bootstrapping the Python interpreter package."
6dacee57fbe6b5bc5a2fca23b5b7d8ccfea54ee7 Revert "Pass packages to vpython to bootstrap."
03e0afedc841bad5fed8024c4b7fd38d332701ad Pass packages to vpython to bootstrap.
fa3d6effe8906e93944bf54ea6978adcd022f75c go generate all
b5eee61d0153295f3efb2e67b319066c2306ac5b Add support for bootstrapping the Python interpreter package.
cc5fb5e4934445a0a5206bfc324ca486c1285415 [vpython] Skip flaky test.
c04b64ca743703ebbfc064ec5b5c35d3bc378fa4 Add vpython3-only cipd packages.
f14d61370f1d7302a797feb2adc3a2f2449130d1 Remove the VENVOmitUseWheel field now that nothing uses it.
7c739ae11aa23bc37601e6923add677600ae1329 Remove support for old pip versions in pep425 tag probing.
51e3f0a01454d2e18b36de28c7e0ca2f6127ea2b Stop setting the unused VENVOmitUseWheel option.
e0e35a4e2227fb3429f3483c4719b6370eca7e1e Hardcode the venv OmitUseWheel option to true.
Bug: 1318617, 1340653
Change-Id: Ifb94c81492edfa98e1b59fc82e6d43678b82d776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3756933
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
Vadim Shtayura
Chenlin Fan
Jeff Yoon
Camilo Jacomet
Fumitoshi Ukai
Yue She
Yiwei Zhang
Yoshiki Iguchi
Robert Iannucci
Chan Li
Eric Lok
Patrick Meiring
randymaldonado
Scott Lee
Riley Wong
Junji Watanabe
Richard Wang
Leina Sun
Brian Ryner
Quinten Yearsley
Weiwei Lin
Yuanjun Huang
Allen Xie
Takuto Ikuta
Zhaoyang Li
Roberto Carrillo-Navarrete
Philipp Wollermann
Garrett Beaty
Quinten Yearsley
Ryan Heise
Yulan Lin