tandrii
8e22954683
git cl try: --use-rietveld no longer supported.
...
R=nodir@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2399993004
9 years ago
tandrii
f7b29d4a6d
Refactor git cl try.
...
R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=599931
Review-Url: https://codereview.chromium.org/2400793004
9 years ago
recipe-roller
a3f10315eb
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/825386b5d616ed1e5fca94ec76eb6de9335b86d2 Add astunparse and update_vendoring. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2399153003
9 years ago
tandrii
221ab25f46
git cl try-results: refactor Rietveld + add tests.
...
R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
TEST=new teste + local end-to-end
Review-Url: https://codereview.chromium.org/2395113002
9 years ago
tandrii
1838bade43
git cl: style cleanup.
...
R=emso@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2393253002
9 years ago
thakis
9bd40a63c4
Make merge driver complain about older gits
...
The git coming with Xcode 7.0 is too old to know about %P. Most
people will be on newer Xcodes (and Trusty's git and depot_tools's
Windows git are new enough), so this doesn't affect most folks -- so
just complaining loudly is good enough.
BUG=574611
TBR=dpranke
Review-Url: https://codereview.chromium.org/2388483004
9 years ago
recipe-roller
bdb5c1ffd3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/36a1da1369c83f0754989e6f5a24b1b49f6898c9 Allow tests for complicated property names (martiniss@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380393002
9 years ago
agable
c6fbe605fc
Remove straggler auto-svn doc file.
...
R=brucedawson@chromium.org
Review-Url: https://codereview.chromium.org/2383493003
9 years ago
brucedawson
dd55dc6d1c
Modify depot_tools instructions regarding %PATH%
...
The old depot_tools instructions insisted that depot_tools be the last
entry in the PATH environment variable, for reasons that are unclear and
may only have applied to Linux. Meanwhile, there is a gn issue that can
cause unnecessary building if depot_tools is not near the front of the
path - ahead of other Python installs. This change alters the
instructions for Windows.
This also removes some obsolete instructions regarding building Chrome
on Windows XP - Chrome doesn't even *run* on Windows XP anymore.
BUG=611087
Review-Url: https://codereview.chromium.org/2371333002
9 years ago
tandrii
8818977467
Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
...
Originally landed as issue 2378703002 at patchset 60001
(http://crrev.com/2378703002#ps60001 ).
BUG=chromium:649660
TBR=rmistry@chromium.org
Review-Url: https://codereview.chromium.org/2376323002
9 years ago
tandrii
31d165a5c1
Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ )
...
Reason for revert:
Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround.
Original issue's description:
> Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
>
> BUG=chromium:649660
>
> Committed: 3574740929
TBR=rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:649660
Review-Url: https://codereview.chromium.org/2375393002
9 years ago
rmistry
3574740929
Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
...
BUG=chromium:649660
Review-Url: https://codereview.chromium.org/2378703002
9 years ago
recipe-roller
3e1cde7a87
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/69af4e53c1be1b0fbbc9e57edd70926b8d4f9370 Fix whitelist feature to preserve step order. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380433002
9 years ago
recipe-roller
2ca169197d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/01049d305bfe49d91aab3207372b5b0a0791ba63 Force printing of exception message. (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:650831
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375813002
9 years ago
recipe-roller
a8d76db72b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/79cf78db1a3c32c7730f3e9006825a95261abe06 Cleanup fetch, fix missing network flake instances (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:650355
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2376543002
9 years ago
recipe-roller
6b2cc3819a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/970fe6881473f82045801dff8c317a372c51d052 Update vendoring (martiniss@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2370123002
9 years ago
agable
7276228639
Remove git-svn support from fetch
...
R=iannucci@chromium.org
BUG=475320
Review-Url: https://codereview.chromium.org/2360873002
9 years ago
tandrii
bef52ff000
git recipe_module: git new-branch.
...
R=iannucci@chromium.org,qyearsley@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2369073002
9 years ago
agable
f39c33382a
Use a whitelist for depot_tools pylint instead
...
R=maruel@chromium.org
BUG=644995
Review-Url: https://codereview.chromium.org/2353393004
9 years ago
dcheng
ff84560ede
Introduce git merge driver for the blink reformatting
...
Based on CL from primiano@: https://codereview.chromium.org/2348793003/
This is a simple tool that can help automatically resolve conflicts
from clang-format reformatting patches.
BUG=574611
Review-Url: https://codereview.chromium.org/2356933002
9 years ago
recipe-roller
15ab08227b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:649466,chromium:649529
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2360143005
9 years ago
stip
f3cc160f0c
Delete unneeded test.
...
Follow-up to https://codereview.chromium.org/2352393003 . Note that a lot of these tests seem svn related, and can probably be deleted. I defer to to agable@ on what we can carve out here.
BUG=
R=agable@chromium.org
Review-Url: https://codereview.chromium.org/2360113002
9 years ago
stip
7a3dd3570e
Change usage of deprecated flag.
...
BUG=Every time I run 'git cl upstream' I get "The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to."
Review-Url: https://codereview.chromium.org/2352393003
9 years ago
recipe-roller
32d8737bb9
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/5b64ce6370b70afd63e463ae72f02e69ecc034ec Require recipes to emit at least one full test case. (iannucci@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2364463003
9 years ago
agable
3b9a5bb84f
Delete git-auto-svn and its docs
...
We no longer support git-svn as a workflow.
R=iannucci@chromium.org
BUG=475320
Review-Url: https://codereview.chromium.org/2360143002
9 years ago
hinoka
b61b9b7583
Reland bot_update: add --auth-refresh-token-json passthrough for apply_issue
...
Reland of https://codereview.chromium.org/2294413002/ after a rebase fix.
BUG=642150
Review-Url: https://codereview.chromium.org/2353833002
9 years ago
vadimsh
23fe6cfb9d
Updating git-for-windows to 2.10.0.
...
R=iannucci@chromium.org, hinoka@chromium.org
BUG=647446
Review-Url: https://codereview.chromium.org/2357633004
9 years ago
hinoka
ad842878e4
Revert of bot_update: add --auth-refresh-token-json passthrough for apply_issue (patchset #7 id:120001 of https://codereview.chromium.org/2294413002/ )
...
Reason for revert:
Pointing to the wrong file :(
Original issue's description:
> bot_update: add --auth-refresh-token-json passthrough for apply_issue
>
> BUG=642150
>
> Committed: e465667e78
TBR=vadimsh@chromium.org,martiniss@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642150
Review-Url: https://codereview.chromium.org/2350363003
9 years ago
benhenry
186449d3e7
docs: Removing references to SVN
...
BUG=643697
TEST=None
Review-Url: https://codereview.chromium.org/2350293002
9 years ago
hinoka
e465667e78
bot_update: add --auth-refresh-token-json passthrough for apply_issue
...
BUG=642150
Review-Url: https://codereview.chromium.org/2294413002
9 years ago
recipe-roller
e4abcee60e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/f7ada90c926c78704f048767e29e8ae836d8a65b Prefer overridden dependencies. (dnj@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354683004
9 years ago
hinoka
8ea74908a6
depot_tools: Remove third_party/gsutil
...
A quick "git grep gsutil" reveals that this is no longer being used, and all
references to gsutil are pointed to gsutil.py.
BUG=
Review-Url: https://codereview.chromium.org/2280023003
9 years ago
rmistry
9eadede7df
Add ability to set topic during "git cl upload"
...
BUG=chromium:628237
Review-Url: https://codereview.chromium.org/2343363003
9 years ago
nick
7e16cf3032
owners.py: partial fix for owners-check perf regression
...
fnmatch.fnmatch seems to fall off a performance cliff once you start cycling through more patterns than can fit in its internal cache.
BUG=642793
Review-Url: https://codereview.chromium.org/2293233002
9 years ago
vadimsh
6ac12ffd59
Make bot_update.py print git version it uses.
...
R=iannucci@chromium.org, dnj@chromium.org
BUG=647446
Review-Url: https://codereview.chromium.org/2344313002
9 years ago
vadimsh
7f245d07b2
Bump git-on-windows bleeding edge version to 2.10.0.
...
R=iannucci@chromium.org
BUG=647446
Review-Url: https://codereview.chromium.org/2347243002
9 years ago
tandrii
15a248123d
Revert of bot_update: ensure correct depot_tools checkout is used. (patchset #2 id:20001 of https://codereview.chromium.org/2346973003/ )
...
Reason for revert:
broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python.
Original issue's description:
> bot_update: ensure correct depot_tools checkout is used.
>
> R=vadimsh@chromium.org,martiniss@chromium.org
> BUG=635641,647446
>
> Committed: 972ac50401
TBR=martiniss@chromium.org,vadimsh@chromium.org,iannucci@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=635641,647446
Review-Url: https://codereview.chromium.org/2349673002
9 years ago
tandrii
972ac50401
bot_update: ensure correct depot_tools checkout is used.
...
R=vadimsh@chromium.org,martiniss@chromium.org
BUG=635641,647446
Review-Url: https://codereview.chromium.org/2346973003
9 years ago
vadimsh
18ca30ca80
Teach bot_update to remove partially deleted git repos.
...
Also add logging to 'remove', helps to debug issues with 'build.dead' filling
up with crap.
R=iannucci@chromium.org, hinoka@chromium.org
BUG=647046
Review-Url: https://codereview.chromium.org/2342973002
9 years ago
thakis
adcd4b78d5
presubmit_support: Remove a noisy logging.debug()
...
On a CL with a single file, presubmit writes all this noise:
Running /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:Running CheckChangeOnCommit in /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:git diff -p --no-color --no-prefix --no-ext-diff 691e0c7d46341465de7a605b5f2aee941ccfedc0...HEAD --no-renames; cwd=/b/build/slave/linux/build/src
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkperms/checkperms.py --root /b/build/slave/linux/build/src --file content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:^(android_webview|base|content|net)[\\\/].* matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:LocalPaths: ['content/browser/gpu/gpu_data_manager_impl_private.cc']
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:Running CheckChangeOnCommit done.
The "a matched b" lines are boring and numerous, so remove this log line.
If we ever need it to debug something, we can add it back then (temporarily).
(From https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260304/steps/presubmit/logs/stdio )
BUG=none
Review-Url: https://codereview.chromium.org/2341103002
9 years ago
vapier
7475196d4c
repo: update to v1.12.17-cr1
...
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.
BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted
Review-Url: https://codereview.chromium.org/2340073002
9 years ago
tandrii
bf42940536
git cl land to refs/pending: remove unused arg.
...
R=iannucci@chromium.org
BUG=642493
Review-Url: https://codereview.chromium.org/2322783002
9 years ago
tandrii
73449b0bd4
Gerrit git cl land: abort if not uploaded.
...
R=agable@chromium.org
BUG=642759,609225
Review-Url: https://codereview.chromium.org/2317253003
9 years ago
tandrii
5d0a0421ce
git_cl: update outdated TODOs.
...
R=machenbach@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2339903002
9 years ago
tandrii
f46c20fcee
codereview.settings: add GIT_NUMBER_FOOTER setting.
...
This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.
R=iannucci@chromium.org
BUG=642493
Review-Url: https://codereview.chromium.org/2324583002
9 years ago
recipe-roller
34aa4d98f1
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/82c60d376b779c86f78ce98884fd4f887382e9ec Add better documentation, trigger namedtuple. (dnj@chromium.org )
R=dnj@chromium.org
BUG=None
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2335163004
9 years ago
martiniss
33061f78a1
Add recipe-roller as an OWNER of recipe modules.
...
See https://codereview.chromium.org/2335163004 for why this is needed. The
roller can't land a non-trivial CL with the upstream author's LGTM, because
it's not an OWNER of the recipes in the repo it's rolling into.
Review-Url: https://codereview.chromium.org/2337263002
9 years ago
recipe-roller
65cc5b1918
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/ca75ca80dcfcc2a2dc38096ba0522065ebd347ec Revert of Require recipe tryjob for CQ. (patchset #1 id:1 of https://codereview.chromium.org/2153303002/ ) (martiniss@chromium.org )
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644609,628801
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338723003
9 years ago
recipe-roller
1ce79108a3
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/dbdcd3b5c9096b3a770bdb61e15039115b6a8dd3 Revert of Add better documentation, trigger namedtuple. (patchset #3 id:40001 of https://codereview.chromium.org/2332833003/ ) (martiniss@chromium.org )
R=martiniss@chromium.org
BUG=None
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2336313002
9 years ago
rmistry
ea9e93f28c
Skip apply_gerrit rebase when there is a rebase failure.
...
Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
This causes the checkout to remain in the "rebase in progress" state.
BUG=chromium:645955
BUG=skia:5749
Committed: 9736fe8938
Review-Url: https://codereview.chromium.org/2328313002
9 years ago