Commit Graph

1584 Commits (42905bfa36b9416d7d504f643798689049254dbe)
 

Author SHA1 Message Date
maruel@chromium.org 42905bfa36 Revert r166268 "In msys-git-1.7.4, in git-cl $0 is:"
/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22:
/usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: Not a directory
/usr/local/google/home/gspencer/depot/depot_tools/git-cl: line 22: exec:
/usr/local/google/home/gspencer/depot/depot_tools/git-cl/git_cl.py: cannot execute: Not a directory

TBR=szager@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11366117

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166274 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com 3598b513fb In msys-git-1.7.4, in git-cl $0 is:
C:\depot_tools\/git-cl

But in msys-git-1.8.0 it's:

C:\depot_tools\\git-cl

Handle either syntax correctly.

TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/11359074

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166268 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com 6a12660bc6 Fix logic for checking whether git is installed.
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/11377002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166259 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
sivachandra@chromium.org a0ad8ad9c9 'dep_os' paths override 'deps' paths.
BUG=157979


Review URL: https://chromiumcodereview.appspot.com/11368067

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166247 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com c37b2817b0 Force win clients to update to git-1.8.0.
Depends on https://codereview.chromium.org/11365070
Review URL: https://codereview.chromium.org/11364056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166237 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
enne@chromium.org cb55d8a74a Add WebKit bugzilla/git search to my_activity.py
This is unfortunately imperfect in a number of ways:

* Needs to get info from git commits, so needs a local WebKit git repo, and an explicit option to find it.
* Bugzilla doesn't return nearly as much information as other bug servers, and individual issues would have to be hit (and parsed) to get it.
* Searching for comments includes any issue ever commented on that was changed over the time period requested, so may have false positives.
* Reviews themselves can't be searched from Bugzilla, so can only be detected as "reviews" once landed and "issues" until then.

BUG=158993


Review URL: https://chromiumcodereview.appspot.com/11365078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166100 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
ilevy@chromium.org 0f58fa88ef git_cl sanity checks
Added checks:
- Block upload of a diff from sha not in current branch
  (this includes tracking against an unrebased local master)
- Block upload of a diff containing shas from origin/master
  (should never happen)

- Use explicit calls to git merge-base instead of calling git diff
   with "<branch>..." which implicitly uses merge-base.

BUG=157503

Review URL: https://chromiumcodereview.appspot.com/11262057

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165887 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com 480162a664 Set executable bit
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165720 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
stuartmorgan@chromium.org 18a4f6a798 Allow specificying that only target_os should be used in a gclient file
This allows specificying that a target OS list should override the base
list instead of adding to it. This is useful for iOS builds, where the
desired behavior is to pull only the iOS deps, not the union of the Mac
and iOS deps.


Review URL: https://chromiumcodereview.appspot.com/11363036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165671 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
thakis@chromium.org fdf5ca8378 ninja: Don't assume that depot_tools is in PATH.
TEST=`~/src/depot_tools/ninja --version` works when depot_tools isn't in PATH

Review URL: https://chromiumcodereview.appspot.com/11366044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165510 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
cjhopman@chromium.org 3365f2d8ad Only try keyring password once for code.google.com
If the keyring password doesn't work on the first try, it probably won't
work on the second or third. The KeyringCreds object already supports
this, we just were recreating the object at each step.

Also, if after three tries authentication to code.google.com still
fails, then the script should continue and just use un-authenticated
access to code.google.com.

BUG=158388


Review URL: https://chromiumcodereview.appspot.com/11340023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165446 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 93477fd5fa Add another print statement to debug apply_issue problem.
TBR=cmp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11366030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165354 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com 518597c50c A git extension for running post-sync hooks.
TBR=cmp@chromium.org
Review URL: https://codereview.chromium.org/11362025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@165295 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com c1200a8559 Keep the parallel execution pipes full as much as possible.
Rearrange some of the pipe redirections to avoid crashing on Windows.

TBR=cmp@chromium.org
Review URL: https://codereview.chromium.org/11260036

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@164140 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
ukai@chromium.org 259e46891c git-cl: show dirty files if any
R=chase@chromium.org,szager@chromium.org,maruel@chromium.org
BUG=157398
Review URL: https://codereview.chromium.org/11262004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@164026 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
sivachandra@chromium.org 91668b7007 Improve the test.
BUG=155792


Review URL: https://chromiumcodereview.appspot.com/11274037

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163975 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
sivachandra@chromium.org d45e73e88b Allow DEPS file to specify 'target_os'.
BUG=155792


Review URL: https://chromiumcodereview.appspot.com/11246004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163955 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org cb5667aaa2 patch can be None in the exception, causing a secondary exception.
R=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11232069

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163646 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org bff3fc2946 Add yaml to git-gs.
These are used for Google AppEngine configuration files.

TBR=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11239003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163582 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
sivachandra@chromium.org aebe87f424 Add gerrit Change-Id to commit messages if they do not have one.
BUG=156729


Review URL: https://chromiumcodereview.appspot.com/11236013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163366 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
cjhopman@chromium.org 426557ad35 Fix week_of, quarter_of, year_of calculation
These calculations were not dropping the time from the provided date.
And so a week would be Monday 11AM to Monday 11AM when run at 11AM.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11233041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163360 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 370a623c70 Add a print to figure out where the hang occurs.
TBR=rogerta@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11235034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163342 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
dpranke@chromium.org 9e227d5bd5 use "/" instead of path.sep in owners glob check
R=maruel@chromium.org
BUG=157022


Review URL: https://chromiumcodereview.appspot.com/11236018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163198 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
dpranke@chromium.org e3b1c3d1e3 Fix swapping of args in call to relpath() that was causing
OWNERS checks on DEPS to fail.

TBR=maruel@chromium.org
BUG=157022



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163192 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
iannucci@chromium.org 7954005862 Allow users of git cl to disable git copy detection entirely.
Depends on rietveld cl: https://codereview.appspot.com/6726050/
BUG=155511

Review URL: https://chromiumcodereview.appspot.com/11195012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163092 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
scottmg@google.com 1a6ec7915b update windows ninja binary
Update to b022e789fd of github.com/martine/ninja:master.

Specifically, pulls in space-in-path dependency file fix here: 32f8ed1178

Bootstrapped from clean pull, ninja_test passes cleanly.

BUG=156789
TBR=maruel

Review URL: https://codereview.chromium.org/11226006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@163001 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
cmp@chromium.org 34e039a175 Revert "Fix a specific use case for the CQ."
This reverts commit r162769.

TBR=maruel@google.com
BUG=156778


Review URL: https://chromiumcodereview.appspot.com/11190067

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162892 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 87dad41087 Fix a specific use case for the CQ.
Ensure the gcl change directory is created when gcl was never used by itself but
used through trychange.py

R=nsylvain@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11193040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162769 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
cjhopman@chromium.org 04d119d52d Add script to look up a user's activity
Found to be particularly helpful in writing snippets.

This tool looks up all activity for a particular user across many
different services. It looks up changes and reviews across various
Rietveld and Gerrit instances and looks up issues in various google code
projects.

Running with no arguments will look up activity of $USER over the
current week (last week on Monday). I.e. the primary use case is for
looking up your activity for writing snippets.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11140010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162561 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
dpranke@chromium.org 17cc244cdb implement per-file OWNERS support
R=maruel@chromium.org
BUG=119394


Review URL: https://chromiumcodereview.appspot.com/11114005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162529 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
ilevy@chromium.org 27ca3a99b4 Add recursion=n syntax to DEPS files.
This will let DEPS files specify a higher local bound for recursion.
Note there is an edge case where a dependency can be initially pulled
in with a lower recursion level and then gets ignored subsequently
when a lower level DEPS overrides it's inclusion level and then
includes the same dependency.  I do not solve this case, as
I am intending to use this syntax for top level deps files.

BUG=155780


Review URL: https://chromiumcodereview.appspot.com/11146032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162464 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
ilevy@chromium.org 1369150868 Make gclient sync use cpu count for default jobs
- On high core, fast machines, jobs=8 is does not offer good
  parallelization.  Switch to use number of local cpus.

R=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11140019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@162072 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
srdjan@google.com b531354fef Fix Issue 154553: gcl upload from within drover throws error
Adjust timeouts in PrimeLint.

BUG=154553

Review URL: https://chromiumcodereview.appspot.com/11122005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161950 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@chromium.org c51def3ff4 Restore previous behavior of GetSha1ForSvnRev, so unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/11148019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161909 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com 312a6a4e7a Fix safesync_url handling for git.
Takes into account the new submodule-enabled repository layout.
Review URL: https://codereview.chromium.org/11098064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161403 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
szager@google.com 1d23a428cc Add option to synthesize a consistent lkgr commit by running deps2git.py
and deps2submodules.py.

Depends on https://codereview.chromium.org/11085027
Review URL: https://codereview.chromium.org/11090038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161305 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org b848d5b703 Fix multi-solution use case with conflicting custom_deps overrides.
Let's say there's 2 solutions, solA and solB, both fetching the dependency depA
with different urls, solA has 'depA': 'http://foo/bar' and solB has 'depA':
From('depB', 'bar').

This case used to not work, because LateOverride() was not called in
verify_validity(), so it was not comparing the resolved urls but instead what is
textually specified in both DEPS files.

Also because LateOverride() was not called, verify_validity() was comparing the
original urls even if custom_deps is specified in the solution(s).

Finally, allow one to mismatch the other IFF one is None.

R=szager@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11088023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161228 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
mkwst@chromium.org d3734c9cad Adding *.pm and *.pl files to the list searched by 'git gs'.
BUG=155016

Review URL: https://chromiumcodereview.appspot.com/11028112

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@161109 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
cmp@chromium.org c22ea4bc1d Make repos without VIEW_VC also post Committed to the codereview.
R=maruel@chromium.org
BUG=153446


Review URL: https://chromiumcodereview.appspot.com/11094033

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@160960 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
sivachandra@chromium.org 270db5c246 Allow special java statements (for example imports) to be as long as neccessary.
BUG=152209


Review URL: https://chromiumcodereview.appspot.com/11043031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@160956 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org e6b162cf32 Add .isolate to git-gs.
TBR=csharp@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11065002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@160027 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org de85d9c794 Add protected against empty binary file and disable all binary file support.
If a file is empty, it's not a binary file in the first place. This is to
protect against improper uploads.
From light testing, it seems binary file support is totally broken. This needs to be verified throughout before being enabled back.

TBR=rogerta@chromium.org
BUG=23608


Review URL: https://chromiumcodereview.appspot.com/11016032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159941 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org cd8d8e1702 Correct invalid use of 'is' when '==' should have been used.
R=nsylvain@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11046016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159909 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
hinoka@chromium.org 791be0bc65 Added extra error message to trychange for empty diffs
BUG=


Review URL: https://chromiumcodereview.appspot.com/11046004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159765 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
iannucci@chromium.org 53937ba767 Add option to specify similarity level for git diff operations on commandline
BUG=125983

Review URL: https://chromiumcodereview.appspot.com/10945002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159732 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 3836bb2c3f Update upload.py at 6edc5bf0ceb2.
TBR=iannucci@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/11032023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159715 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org a73435aa98 Fix private issues, take two.
The object creation order was wrong

TBR=rogerta@chromium.org
BUG=149941


Review URL: https://chromiumcodereview.appspot.com/11024009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159524 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 0aca0f9684 Enforce the checkout object to use an absolute path.
Stop using stderr so the output is more readable on buildbot.
Otherwise stderr arrives before stdout in apply_issue step.

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11038002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159508 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 4dd9f7205a Make apply_issue.py much more verbose about what it's doing.
It's to help users figuring out what is happening.

TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11028002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159504 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago
maruel@chromium.org 9d5f4ad1b9 Works around rate limiting by trying to apply CL unauthenticated first.
TBR=rogerta@chromium.org
BUG=153284


Review URL: https://chromiumcodereview.appspot.com/11019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159488 0039d316-1c4b-4281-b951-d872f2087c98
13 years ago