aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,199 Commits
6 Branches
0 Tags
183 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '3ff0e5dfaf'
${ noResults }
Commit Graph

6199 Commits (3ff0e5dfaf1ac7a91874705012d9fe25eccd26bc)
 

Author SHA1 Message Date
recipe-roller 71c6bc07e6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b70069b5465136f8634c5694b714b1b4421276f5 Remove swarming_task from StepData. (karenqian@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6af1159648c8dd64daeda9f90384f7d9b09665c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1643670
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur 2c48f24c7f git-cl: Report presubmit execution time. 
Bug: 970113
Change-Id: Iff31287d1ab8f683f7745fd0abc62b138ffcf219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1642649
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller 0f47678812 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ac2632016e98b767225c2f1328418c1167618efe [step_runner/subproc] Refactor handle closing out of main function. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifc33e30933ddcb14f8f1d7af34c5c6338334091a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1642575
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller b3bc26ec29 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c2b6b7ae345169e8f0a09f767467ddd897542a25 Fix fake_kitchen.sh on windows. (iannucci@chromium.org)
  https://crrev.com/b1c18614e63aeb781c75681f5ff393576dc9e8ab Fix logdog client library on windows. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I65df9833c4981b120a17eba151193ae86a3a79da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1642574
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 97f308aa25 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8c2c028496f3b8e47034e45682a41be3405dbaeb Add cpu cost classes to api.step. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23e30fe3597fb1f7db3d9e09ed5d698b48190520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1642355
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 372ccb3faf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3f64ba05d329bb41bc8b651d07b7b7f3c1bf4135 Fix manifest link. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id668c1eda67af1473ab4bb43f12e42acee701d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1642307
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 0183a1fe6c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bd459f5f82d151b4b304a29600a2a671c24b9ce0 Get rid of gevent monkey patching. (iannucci@chromium.org)
  https://crrev.com/94a299a13fceebfccc56e692e46b7daa16903b07 Add userspace access APIs for recipe concurrency. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iccc3fb2a18e0fe4a4954cf1402101d7ceb9bafc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1641601
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller b9cb66f449 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0624ac77bb1b64cb175809e332b9a6ae4f9b77e3 Switch RecipeEngine._step_stack to be GLS. (iannucci@chromium.org)
  https://crrev.com/bfed55c460d57a5185a6a3a036de835f0a5940ad Make _step_stack never empty. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If8378d61bf5233f81284771a323008a66d4b8c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1641599
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller ce7c00af4f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2faacf687c1d66e2100fdb038782e524eb24f296 Move tracking of namespaces and deduplicated step names into the engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie8c08dd2b0285f02bf9748a076ac4b82abdd6ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1641598
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller f5f2ef9c93 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b81bc5473638f2c9c2a6f567e4fc976c978a247d buildbucket: propagate `cq_experimental` when inheriting buildsets. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7326f9ffcc5165da28b1ed92701bde0d04205d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1641583
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 1ca73c8718 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e5b7ae69e6b4b747abe479496b783c4c7ac904d9 cq: expose ordered_gerrit_changes as a property. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I72dfde991b1620e2114d5a209181efb98ab9536b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1639371
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller c38806be71 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8eb708a2d5545c549ee462a193891ed7e30d430e [archive] Append file permissions stored in extra attributes (smut@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefbe36e25e36611a6dede30171e70b61a9bfaddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1639620
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller b712f77706 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b5922385482112ce31df891af71854c81662d69e Remove jsonResult defaulting to null (martiniss@google.com)


R=recipe-roller@chromium.org, tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9791f5b80afe6529a6321eccbd4ae7d1a3f18a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1638960
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller cd28c22b7b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a60ff0ed1597c637ca24b898bd1649c7d9b30838 Further refine cmd0 lookup. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6342a44fcb9c1d621e55b027683c225e65861452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1637920
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller bad01ad3ad Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e634bbd816e69976845479453d01a96d78ab2593 Add back windows 32bit support. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If7d24a46dcc551547e48ed9353c5bbdfeac3aee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1637848
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur 3acbc749e4 gclient: Make it possible to set target_rev to a commit hash. 
Bug: 956807
Change-Id: I333479715257a582e26a823ed5c0e2382851ff35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1625775
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Eric Boren 67c4820073 [git-cl] Fix crash in "git cl upload" 
This occurs when the command is run on autorollers.

Change-Id: I264b85e906617412538b333b06414479b4acc386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1637360
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>
 6 years ago
Jonathan Nieder 9779b146cd git-cl: Use modern environment variable name to trigger tracing 
In git.git commit e4b75d6a1d31 (trace2: rename environment variables
to GIT_TRACE2*, 2019-05-19), the GIT_TR2_EVENT environment variable
is being renamed to GIT_TRACE2_EVENT.

Set both environment variables so that Git versions with and without
that change will both write traces to the tr2-event file.

The trace2 facility was introduced in Git 2.22.0.  rc0 and rc1 use the
more cryptic GIT_TR2* name; rc2 and later (and in particular Git
2.22.0 final) will only support GIT_TRACE2*.  In a week or so, once
this change finishes rolling out to the Googler population, we can
simplify "git cl" by only using the modern GIT_TRACE2_EVENT envvar and
GIT_TR2* will be lost to history.

Change-Id: Iade2ebfd4aff27270688d94514f5f35a4e34a29b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1636277
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jonathan Nieder <jrn@google.com>
 6 years ago
Robert Iannucci 77e19d35dc Roll led to latest version. 
Picks up some library fixes to allow `led get-swarm` to work correctly
again.

R=tandrii@chromium.org, vadimsh@chromium.org

Change-Id: I1f6870378224372eeba12cfabc9f9b002250b4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1636276
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 6 years ago
recipe-roller 688dd321c9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/57101cd8c0028985759fb381f064ee77b3e0adbc Refactor new_step_stream to take only the essential data. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2d87af8aa19b49e76ad93ff54a5a6462126cd791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1635804
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 04163545e7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/55b0c542ede5a3ed4e93c0c844559ea74790e5ea cq: expose api.cq.props_for_child_build property. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe73eaa040044ae272ee478118bc26bff56d5311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1634281
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller f9d2b4a62e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/edb73a793557dcbdfe6854f27d90d3d488fa04ec Make nested parent steps have strict scope. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifee6f601b1b8f506ae8c3bc30e3c3765ea491c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1634279
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 607c4711b4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8b16a36e64065fb9a59237d9cbeb1b4123910e8f json: api.json.loads as test_api.json.loads. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e93d278ad6585a433e5180fffdcae44f924518f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1635799
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Vadim Shtayura 96104d42da [cipd] Update lucicfg 1.7.7 => 1.7.8. 
To pick up support for "<project>:<bucket>/<builder>" syntax:
  https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1629989
  https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1632664

R=tandrii@chromium.org, maruel@chromium.org
BUG=966603

Change-Id: I870432a33c763c24591ee7e9eafe1154dda6df84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1635795
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 6 years ago
Takuto Ikuta 2ee83757a1 [autoninja] use custom status in non-windows too 
This is non-windows version of
840a6d66ec

Change-Id: Iaddd3a153011f9c15cf065e7ef96e320d1737ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1632034
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 6 years ago
recipe-roller b97d193baa Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d90d37f751848195850d2af1a300d9c95dd2a2b8 Remove unused name_prefix complexity. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9435f05315b75e979b0e4559c06c90f115e4a2de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633510
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 89aaeb90e2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/29f83f0b60ed4debf5349aaa91019200a7a19357 cq: add .experimental and .top_level properties. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8371ad6b8a977c5e703e704ed17d08c7fb911783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1632839
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 0f52b90f75 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/295d478e0b3dc060e50fdba37edbf6552cc8796c Make recipe engine unit tests less flaky. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie0065c7f1e779fc780425a423ffcfda681b6756a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633175
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Marc-Antoine Ruel 602401825b cipd: Update lucicfg to 1.7.7. 
Add link in cipd_manifest.txt to help people figure out which commit to
use.

R=jchinlee@chromium.org

Bug: 808836
Change-Id: I2c03c6a25e79363792a85d976d2a245b0ba6b5b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633173
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 4ce909c11c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/21625832430557848a1bb6336f10bd4a86e0ac78 [post_process] Make output_properties have decoded values. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5611da3fdf21150de237358525d3c6d1d6778ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633107
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 9c0d43d008 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c4450432fa4f62e6ae7fd530d596dec6a43bd701 Automate copying cq.proto to recipe engine. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ief4d3afba1dadc6a7a598c64f17a29c5e165434b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633032
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Robbie Iannucci 374de57e57 Revert "cipd: remove windows-386" 
This reverts commit 314e301879.

Reason for revert: On second thought, I don't think we want this.

Original change's description:
> cipd: remove windows-386
> 
> Running depot_tools on Windows 32 bits is not supported anymore.
> 
> Add a comment to cipd_manifest.txt to help people to figure out by themselves
> where to look to do a roll.
> 
> Change-Id: I8a8c2d1437ec77c99588261e3eba0abdcb13c105
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1630448
> Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

TBR=maruel@chromium.org,iannucci@chromium.org

Change-Id: I206becbf5bde4bb12e9d71ccab13027171fb017f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1633030
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Marc-Antoine Ruel 314e301879 cipd: remove windows-386 
Running depot_tools on Windows 32 bits is not supported anymore.

Add a comment to cipd_manifest.txt to help people to figure out by themselves
where to look to do a roll.

Change-Id: I8a8c2d1437ec77c99588261e3eba0abdcb13c105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1630448
Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 10e57cf618 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/03e509d455281ec684552595e49b77e66bca6c70 Add --no-emoji flag to simulation tests. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I95fb7c6035d804d4d8600369da2366fc0d75d92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1631942
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller c5b8a73247 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c2ae1f8b058dc210e2f8b1753aa7184973da36a6 Remove stdout and stderr from expectation files. (gbeaty@chromium.org)


R=iannucci@chromium.org, recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I60e4142ad54eb22d3912a603f816a034fa5b2d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1632616
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Robert Iannucci 778c7f117a Make tryserver API only update the presentation of its own steps. 
To sanely support concurrency, I need to make `api.step.nest` strictly
scoped; i.e. once you leave the nest context it closes all the steps
within that context.

This changes some wild 'active_step' uses to generate a step for the
module's own purpose.

R=martiniss@chromium.org, nodir@chromium.org, tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Bug: 910369
Change-Id: I19aef31118faf9d3d078a2c5a0ebd48a4bfebd43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1630044
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller 26af0d34d2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/16a26b8a4218fab4320f63c4ddd27fb6471bcc55 Remove unused import. (tandrii@chromium.org)
  https://crrev.com/4f12504d84f212988adacdbf413051e1aaf5f61d Remove ability to set callback on nesting steps. (iannucci@chromium.org)
  https://crrev.com/5205e83b1f86731b1a2d9d4d403da415bc18029f cq: upgrade recipe_module to use protobuf message as input. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I99962ec123e14929cfb3df5da846e4ecf0398fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1630087
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Andrii Shyshkalov c47fcecdac Fix flaky gclient_smoketest. 
It assumed, incorrectly, that git always listens on port 20000.
It's mostly true, except when tests are ran in parallel.

Example of flake: https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket.appspot.com/8912524891032998560/+/steps/presubmit/0/stdout

R=smut

Recipe-Nontrivial-Roll: build
Change-Id: I96825175e2f899bce703443b80b71bba5953ac72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1629745
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: smut <smut@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
recipe-roller 7096877200 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0e48aee67e9a413e67382067081e2dbe2d19e10b Formatting improvements for the test runner. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia717a1b2dae804f224d21004bf553be7a9d831c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1629548
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller c0a9f5278b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b09eee7479e11b35b74c2de2de80824bdf7999c7 Skip proto compilation on tests which do not write proto files. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1fd3f5fa2c9756e930cf5760a09ce926b6dbb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1628825
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur 21000eb851 presubmit_support: Run tests on parallel when asked. 
Bug: 819774
Change-Id: I19cd59aab23f3afb39da7fa04c470ad4b1c688f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1627402
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller 6247b59b7c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ac1ba2318d5dc0263f74e9aa00aabc95c1b856da [archive] Support extracting Unicode filenames (smut@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib5799703c1db7fea1174c8c0e3df7b7960fafc80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1628823
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller f46a311417 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/760356455dfc993bd960091e4e828f3c319f1526 Fix Path.__repr__ in config_types.py. (iannucci@chromium.org)


R=recipe-roller@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id2cc766b4455c87f6d5828b764010833cd979adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1629203
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller c5d48532a0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7d36d49d6d50c84b6a44a6a9a7c29ad5dead839f Fix race in test runner. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie57d4b11c4ea0c94e6e291bc09950b3d268c8d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1629198
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller dd563e08d6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a11e6b64ef01423a58b5f4cdce59bb1a0c87c469 Reland (2): Add gevent to recipe engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I263e997036281a85895c2b06568c751a9dfd082a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1629142
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller e24c4d61dc Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f1dba26d41c1621b7d2c62dfa0f0f022dd47d0f5 Revert "Reland Add gevent to recipe engine." (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8a2051eeba89793ef3e35d55060ee81ceb84d621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1628906
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Raul Tambre e99d4b4386 subprocess2, gerrit_test_case: Use SIGTERM instead of SIGKILL for Windows support 
SIGKILL doesn't exist on Windows, but SIGTERM does.
For our purposes they do the same thing.

Bug: 962263
Change-Id: I16929cf7d1377cd81f71401a48b5a84fe54da493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1608561
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
 6 years ago
recipe-roller 239d4ca606 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/15b7962d99c005a8be0a89ddb1b84e7702ac7636 Reland Add gevent to recipe engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02e2d911ff050b6506bbf4e6c413cd6e21c26818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1628298
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Raul Tambre 7c93846385 Convert except statements to be Python 3 compatible 
Ran "2to3 -w -n -f except ./".

The scripts still work with Python 2.
There are no intended behaviour changes.

Bug: 942522
Change-Id: Ifa274cb83f74cfa8ce092fffbb88f3ab5309e72c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1607841
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
 6 years ago
Raul Tambre 7d1300b89a fake_repos: Fix use of NamedTemporaryFile on Windows 
Python doesn't guarantee that the file created by tempfile.NamedTemporaryFile can be opened by multiple programs at once.
This is the case on Windows, so we need to close the temporary PID file and only then pass it to Git.

Bug: 962263
Change-Id: Idf4a36b33ce06d7ab06453c20a690622179aef58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1608560
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
 6 years ago