Commit Graph

67 Commits (375765c6bf8081b53669293f6d1d4c71f67ffcb0)

Author SHA1 Message Date
maruel@chromium.org c78f246ee4 Add scm.*.GetEmail() to retrieve the user email. Use this email for try job emails.
TEST=not much
BUG=none

Review URL: http://codereview.chromium.org/399070

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32720 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 5aeb7dd54c Reapply 32057, 32058, 32059, 32062 and fixes problems introduced by these changes.
Noteworthy change is scm.SVN.GetFileProperty calls Capture instead of Run.

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/399009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32181 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 261eeb5e93 Revert 32057, 32058, 32059, 32062 because they still have unwanted side-effects.
Revert "Group SCM-specific functions in classes to simplify generalization of the interface."
Revert "Fix 2 recently introduced errors."
Revert "Fix a variable aliasing error."
Revert "Fix typo."

TBR=dpranke
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/391075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32065 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 85a3192f9c Group SCM-specific functions in classes to simplify generalization of the interface.
TEST=none
BUG=none

Move scm functions into a class to make it simpler to manage.

Review URL: http://codereview.chromium.org/391052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32057 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 8ef5f54e4d Cleanup the unit tests by mocking more system functions.
TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/392006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31754 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org e3608dfc1a Run pychecker over most scripts in depot_tools. Catched a few bugs.
TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/385007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31590 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org ea6c2c5cea Fix depot_tools unit tests on Windows.
TEST=unittests
BUG=none
Review URL: http://codereview.chromium.org/273010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28591 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
thestig@chromium.org de24345ee7 Make the try slave selection client side.
BUG=23071
TEST=none
Review URL: http://codereview.chromium.org/248029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28155 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
chase@chromium.org ad02011773 Fix trychange unittest.
BUG=none
TEST=trychange unittest passes
Review URL: http://codereview.chromium.org/243090

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27969 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
robertshield@google.com 0d3c7a868b Add missing import from r26426.
BUG=gcl try and gcl upload don't work
TBR=maruel

Review URL: http://codereview.chromium.org/207007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26429 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org f7fb33eed4 Add better try server settings automatic detection support.
This is a redo of http://codereview.chromium.org/123020 (revision 18198) that was reverted in revision 18232 because of a codereview.settings misconfiguration and not because the script was broken.

The misconfiguration was fixed in http://codereview.chromium.org/126021

Review URL: http://codereview.chromium.org/125135

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18612 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org b9d5fd015d Revert 18198 because the root chromium codereview.settings has wrong try server settings. :(
Will reapply in 3 days.

TEST=gcl try works.
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/126020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18232 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 899410c9ee Add automatic try server settings detection support.
Don't rely on the freaky tryserver.py script anymore. Use gcl codereview settings instead.

TEST=gcl try still works, shouldn't break git-try
BUG=none

Review URL: http://codereview.chromium.org/123020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18198 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 2c3024ac53 Refactor the unit tests to remove a lot of duplicate code.
Remove old unused git-cl test files.

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/122040

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18177 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org be0d1ca0e4 Add more tests and cleanup ChangeInfo class.
Review URL: http://codereview.chromium.org/113269

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15885 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 11e0fd6997 Revert changes 15823 and 15824 because they broke gclient revert.
TBR=sgk
Review URL: http://codereview.chromium.org/115217

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15827 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 46b9ae6961 Starts reusing functions in gclient.py from gcl.py.
Review URL: http://codereview.chromium.org/113218

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15824 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago