Commit Graph

18 Commits (328c3c73a85557aec6531327e39fdc8dfa99426b)

Author SHA1 Message Date
maruel@chromium.org 28924253a1 Caches socket.getfqdn(), send 'domain' when profiling.
Otherwise it's hard to know what's generated from automated testing.

R=chase@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6902153

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83673 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 7ca049ba14 Send googler profiling data.
BUG=
TEST=

Review URL: http://codereview.chromium.org/6904055

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83507 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org f31294b482 Make max len parametrable so it can be modified for users.
Mostly useful for commit-queue as I want to both send the trace and be able to
read it locally.

TBR=jam

Review URL: http://codereview.chromium.org/5608001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@68055 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org a7a1a83bf0 Add python's version in breakpad stack traces
BUG=
TEST=

Review URL: http://codereview.chromium.org/5131005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67314 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org 1bd1ed3cc6 Add more exception information to breakpad.
When an HTTP exception information is logged, no information is sent by
default. Add an helper function to manually extract interesting information
to append it to the exception type.

Also disable another pylint warning.

TEST=manual test
BUG=none

Review URL: http://codereview.chromium.org/5303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67306 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
maruel@chromium.org b17b55beca Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT.
This causes some code clutter.

TEST=Increased pylint warning level
BUG=none

Review URL: http://codereview.chromium.org/4321006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org cb2985fb69 Largely reduce the number of pylint warnings and fix one typo.
Most of them are style issues or variable aliasing.

TEST=Can almost enable pylint warnings
BUG=none

Review URL: http://codereview.chromium.org/4360002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 322fa22fed Reenable breakpad in the DC by enabling .chromium.org suffix.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4176004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64049 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 2379632b67 Improve breakpad by adding cwd, fix str(last_tb) and dump what is sent to the user.
The user will get an idea of what data is sent.

Getting the current working directory is useful to know what checkout was used.

the repr(last_tb) call was stripping off a lot of useful information for
debugging.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3384020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60339 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org fa877020b6 Add some doc to breakpad.py and add support for NO_BREAKPAD environment variable.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3311023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58982 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ce921b2023 Use https for stack trace upload.
Add an explicit Register() function to be called outside of this file.
Send the host fqdn to help know from where the exception comes. It is useful when a build slave throws an exception.

Review URL: http://codereview.chromium.org/2327003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48455 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ab89d6f286 Use getfqdn() instead of gethostname()
Otherwise it would return the naked host name most of the time, especially on Windows.

Review URL: http://codereview.chromium.org/2239010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48432 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 7aeac3ee34 Fix KeyboardInterrupt exception filtering.
Add exception information and not just the stack trace.
Make the url easier to change at runtime.

Review URL: http://codereview.chromium.org/2109001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47179 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 9addb1e18f Don't ask to upload a stack trace anymore.
The code proved to be robust enough to not do false positive, i.e.
no non-googler stack trace has been uploaded up to date.
So stop wasting users time and just do it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2014012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46992 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
msb@chromium.org 8912ead3b4 gclient: Keyboard interrupt should not cause request to send stack
Patch-contributed-by: Alexey Marinichev <amarinichev@chromium.org>

Review URL: http://codereview.chromium.org/553139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37434 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 7aca9e8cb5 Add a check so non-google employee don't send crash dumps.
Add a warning message in case the check ever fail.

Review URL: http://codereview.chromium.org/460044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33700 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org 5b3d69d2c9 Disable braekpad automatic registration while we figure out stuff
Review URL: http://codereview.chromium.org/462022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33686 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago
maruel@chromium.org ada4c65e1c Minimalist breakpad implementation.
Client-side implementation.

TODO: Need to automatically disable it for unit tests.

Review URL: http://codereview.chromium.org/444009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33681 0039d316-1c4b-4281-b951-d872f2087c98
15 years ago