Commit Graph

29 Commits (26970fa9079112076ce036f3949806bbb2dac5fb)

Author SHA1 Message Date
maruel@chromium.org 261eeb5e93 Revert 32057, 32058, 32059, 32062 because they still have unwanted side-effects.
Revert "Group SCM-specific functions in classes to simplify generalization of the interface."
Revert "Fix 2 recently introduced errors."
Revert "Fix a variable aliasing error."
Revert "Fix typo."

TBR=dpranke
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/391075

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32065 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 926ae6a75f Fix 2 recently introduced errors.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/391072

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32058 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 85a3192f9c Group SCM-specific functions in classes to simplify generalization of the interface.
TEST=none
BUG=none

Move scm functions into a class to make it simpler to manage.

Review URL: http://codereview.chromium.org/391052

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32057 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org e3608dfc1a Run pychecker over most scripts in depot_tools. Catched a few bugs.
TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/385007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31590 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
finnur@chromium.org e1555a609d Use TRYBOT_RESULTS_EMAIL_ADDRESS environment variable
for the try servers and fallback on EMAIL_ADDRESS, since 
WebKit uses that. 

The reason is that some people have WebKit emails that 
predate Chromium emails so some separation is warranted 
so that people don't have to fix up emails all the time. 

BUG=None 
TEST=None 
Original review: http://codereview.chromium.org/372048


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31437 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
joi@chromium.org 467f4b78f1 Add missing 's' to options.
BUG=none
TEST='gcl try' should succeed even if EMAIL_ADDRESS env variable is not set.

Review URL: http://codereview.chromium.org/351025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30870 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org c9f06b00f6 Small fixes.
Enforce --bot when --url is used.
Add a warning when --email is not defined.
Set a default --name on rietveld patches.
Set return value.

TEST=not much
BUG=when using --url and not --bot, an exception was thrown

Review URL: http://codereview.chromium.org/348044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@30848 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
pkasting@chromium.org 4e9f491f8d Try to clarify "gcl help try" some.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/332014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29927 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
thestig@chromium.org cce9e1c2fa Check Exception object's argument length in trychange.py.
Review URL: http://codereview.chromium.org/274031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28931 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
thestig@chromium.org de24345ee7 Make the try slave selection client side.
BUG=23071
TEST=none
Review URL: http://codereview.chromium.org/248029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28155 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
bradnelson@google.com e2d29c8824 Adding an option to specify a default patchlevel in codereview.settings.
BUG=None
TEST=None

Review URL: http://codereview.chromium.org/243084

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27971 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 81344141c1 Fix the prompt so the user can interact with svn.
When using svn for try job for the first time, svn will ask for the credentials.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/223024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27103 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 5ba3a44fee Fix svn diff mungling.
It was adding a space in front of every line.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26973 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
robertshield@google.com 0d3c7a868b Add missing import from r26426.
BUG=gcl try and gcl upload don't work
TBR=maruel

Review URL: http://codereview.chromium.org/207007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26429 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org d090099eb7 Fix for r26423 part 2.
TBR=brad
BUG=gcl try is broken
TEST=none

Review URL: http://codereview.chromium.org/215003


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26426 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
bradnelson@google.com 833b227017 Adding a project selection option to gcl.
Defaulting to a value in codereview.settings

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/200078

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25886 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
thakis@chromium.org 0270161899 Unbreak `gcl try` if EMAIL_ADDRESS is not set.
Review URL: http://codereview.chromium.org/172099

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25151 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
thakis@chromium.org 59ad6c72ee Make git try work over svn.
Codereview URL: http://codereview.appspot.com/110134


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25111 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
mark@chromium.org 35663168f6 Fix trychange.py --host and --port to work as expected
Review URL: http://codereview.chromium.org/174244

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@23999 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org b3b00a41c8 Add --target support to trychange.py.
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/155032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@19878 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org f7fb33eed4 Add better try server settings automatic detection support.
This is a redo of http://codereview.chromium.org/123020 (revision 18198) that was reverted in revision 18232 because of a codereview.settings misconfiguration and not because the script was broken.

The misconfiguration was fixed in http://codereview.chromium.org/126021

Review URL: http://codereview.chromium.org/125135

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18612 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org b9d5fd015d Revert 18198 because the root chromium codereview.settings has wrong try server settings. :(
Will reapply in 3 days.

TEST=gcl try works.
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/126020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18232 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 899410c9ee Add automatic try server settings detection support.
Don't rely on the freaky tryserver.py script anymore. Use gcl codereview settings instead.

TEST=gcl try still works, shouldn't break git-try
BUG=none

Review URL: http://codereview.chromium.org/123020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@18198 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
skylined@chromium.org 666eb33dfc PathDifference cuts a supplied "root path" from a second path and returns what remains. It is assumed that this can be used as a relative path from the "root path" to the second path.
If the root path ends with a path separator (\ or /), the function used to cut an additional character from the path and the returned value would be incorrect. This fix makes sure the behavior is consistent and correct no matter if the root path ends with a separator or not.

(This fixes the "epot_tools" tools bug.)
Review URL: http://codereview.chromium.org/118376

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17855 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 79613219a3 This was supposed to be in revision 17737 but was left out by accident.
Review: http://codereview.chromium.org/119244


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17739 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 46a9410947 Deprecate gcl.GetSVNFileInfo() for gclient.CaptureSVNInfo().
Review URL: http://codereview.chromium.org/113290

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15891 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 11e0fd6997 Revert changes 15823 and 15824 because they broke gclient revert.
TBR=sgk
Review URL: http://codereview.chromium.org/115217

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15827 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 46b9ae6961 Starts reusing functions in gclient.py from gcl.py.
Review URL: http://codereview.chromium.org/113218

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15824 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@google.com fb2b8eb2e2 Create the Next Generation of depot_tools. Eh.
Review URL: http://codereview.chromium.org/92087

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@14349 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago