This will hopefully make Rietveld._send retry 500s like it promises to
BUG=585632
Review URL: https://codereview.chromium.org/1681333005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298726 0039d316-1c4b-4281-b951-d872f2087c98
This will hopefully make Rietveld._send retry 500s like it promises to
BUG=
Review URL: https://codereview.chromium.org/1683603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298688 0039d316-1c4b-4281-b951-d872f2087c98
rogerta@ has indicated that he should no longer be an owner of
depot_tools.
Review URL: https://codereview.chromium.org/1673313006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298683 0039d316-1c4b-4281-b951-d872f2087c98
The vs_files directory is used for VS 2015 builds and needs to be in
.gitignore, along with vs2013_files.
The naming convention for timestamps is changed and .gitignore needs to
be updated for that.
Finally, the .pylint.d directory keeps being created and should be
ignored.
Review URL: https://codereview.chromium.org/1667853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298682 0039d316-1c4b-4281-b951-d872f2087c98
The UCRT is now optional and it failed to install on one builder.
Making optional to fix build break
If this doesn't fix the break on the waterfall then the switch
to VS 2015 will need to be reverted (crrev.com/1598493004).
TBR=scottmg@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1680433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298634 0039d316-1c4b-4281-b951-d872f2087c98
In C++11 std::swap was moved from <algorithm> to <utility>. As such,
lint needed to be updated to look for/suggest <utility> when it finds
std::swap. The IWYU logic is a little bit different for <utility>
functions, including swap, because they do not typically include
template parameters, unlike most other std:: functions. Reworked the
existing algorithm pattern to be more generic and support multiple
differet headers. Did not rename/all caps _re_pattern_templates as it
is referenced/modified outside of cpplint.py.
BUG=584689
Review URL: https://codereview.chromium.org/1673543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298622 0039d316-1c4b-4281-b951-d872f2087c98
Always formats full GN files that are modified since the format should
be canonical.
I tried to make it consistent in style with the existing formatters. I've
tested running it locally. For "git cl format" it formats GN files. For
"git cl format --diff" it outputs the full formatted files like clang but
doesn't modify. For "git cl format --dry-run" it doesn't modify or output.
TEST=Works running locally.
BUG=
Review URL: https://codereview.chromium.org/1666403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298617 0039d316-1c4b-4281-b951-d872f2087c98
Previously, when a commit was skipped, it would be blamed on the line
number the line had *after* the skipped commit. This could mean a
totally unrelated commit gets blamed. Now, a heuristic analyses the diff
of the skipped commit to discover approximately what line number the
line had *before* the skipped commit, so it can hopefully be blamed on
the right commit.
BUG=574290
Review URL: https://codereview.chromium.org/1629253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298609 0039d316-1c4b-4281-b951-d872f2087c98
Right now I get
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
Calculating hash of toolchain in vs2013_files. Please wait...
which isn't very informative (or at least a bit confusing as to why it's
doing the same thing 6 times).
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1671433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298593 0039d316-1c4b-4281-b951-d872f2087c98
This change adds the option to use the current issue number, if any,
when doing a git cl patch. Instead of doing git cl issue (copy the
number) git cl patch <number>, one can simply do git cl patch -i
BUG=
Review URL: https://codereview.chromium.org/1641903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298582 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
I believe this breaks trybot patching on Windows.
Example: https://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/6811
Error:
'E:\b\build\scripts\slave\.recipe_deps\depot_tools\python' is not recognized as an internal or external command,
operable program or batch file.
I'm speculatively reverting.
Original issue's description:
> bot_update: add depot_tools to PATH so that e.g. apply_issue can be found
>
> BUG=437264
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298556
TBR=jochen@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437264
Review URL: https://codereview.chromium.org/1662763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298561 0039d316-1c4b-4281-b951-d872f2087c98
I acknowledge this is really gross. This allows us to roll the changes into
build_limited in the short term.
Longer term, paths could be passed from outside.
BUG=582074
Review URL: https://codereview.chromium.org/1665753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298550 0039d316-1c4b-4281-b951-d872f2087c98
Currently, the script requires you to pass the unwanted commits on the
command line, but eventually, you could configure it with a file
(checked into the repo) that provides a fixed set of commits to always
skip (such as commits that do a huge amount of renaming and nothing
else).
BUG=574290
Review URL: https://codereview.chromium.org/1559943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298544 0039d316-1c4b-4281-b951-d872f2087c98
This change packages the api-ms-* DLLs and the VS 2015 CRT DLLs in all
of the VS package directories that we add to the path, so that they can
run without having the UCRT installed.
The Common7\IDE path was removed because it isn't actually packaged, in
VS 2013 or VS 2015, so adding it to the path is purely confusing.
In addition to changing the packaging script the installation script has
to change in order to continue if the UCRT cannot be installed. It
still makes sense to try to install it, and print a message saying where
the installer is, for the convenience of Google developers who may want
more flexibility in running VS 2015 binaries.
A 'calculating hash' message was added to make the mysterious hashing
hangs (which can be several minutes long) less mysterious.
BUG=440500
Review URL: https://codereview.chromium.org/1660723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298541 0039d316-1c4b-4281-b951-d872f2087c98
I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.
BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org
Review URL: https://codereview.chromium.org/1650993005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298531 0039d316-1c4b-4281-b951-d872f2087c98
recipe_engine -> 44b384f9b4f1085e9cfe43ea6308735a3af8d4e5: RELAND of Make the recipe engine allow modules named the same thing to co-exist.
R=martiniss@chromium.org,luqui@chromium.org
TBR=iannucci@chromium.org
BUG=582280
Review URL: https://codereview.chromium.org/1660163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298530 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
Exposed recipe engine bug with ambiguous names, causing roller blockage.
Original issue's description:
> Adds bot_update to depot_tools.
>
> This CL imports the bot_update script, along with the bot_update and gclient recipe modules from build. This should allow for recipes to run on swarming.
>
> Also moves the recipe stuff into the infra folder.
>
> bot_update has been modified. See full diff at https://paste.googleplex.com/4969207737352192
>
> TBR=phajdan.jr@chromium.org
>
> BUG=
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298490
TBR=iannucci@chromium.org,phajdan.jr@chromium.org,martiniss@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Review URL: https://codereview.chromium.org/1651323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298505 0039d316-1c4b-4281-b951-d872f2087c98
This CL imports the bot_update script, along with the bot_update and gclient recipe modules from build. This should allow for recipes to run on swarming.
Also moves the recipe stuff into the infra folder.
bot_update has been modified. See full diff at https://paste.googleplex.com/4969207737352192TBR=phajdan.jr@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1641363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298490 0039d316-1c4b-4281-b951-d872f2087c98
Small fix that makes it possible to use ninja and depot-tools using
the mingw64 chroot bundled in git 2.7.0
With this change I can build succesfully on Windows and still have
a civilized shell.
BUG=
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/1638303006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298454 0039d316-1c4b-4281-b951-d872f2087c98
This fixes the test being dependent on the system time, and undefined
behaviour resulting from negative timestamps in positive-offset
timezones.
BUG=581895
Review URL: https://codereview.chromium.org/1640973002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298438 0039d316-1c4b-4281-b951-d872f2087c98
dsansome@chromium.org
scottmg@chromium.org
thakis@chromium.org
tandrii@chromium.org
brucedawson@chromium.org
martiniss@chromium.org
recipe-roller@chromium.org
skym@chromium.org
kylechar@chromium.org
phajdan.jr@chromium.org
mgiuca@chromium.org
mtrofin@chromium.org
andybons@chromium.org
kjellander@chromium.org
sebmarchand@chromium.org
szager@chromium.org
luqui@chromium.org
primiano@chromium.org
jkarlin@chromium.org