Commit Graph

6 Commits (13f258bf05b13d920ffebbf06ffebdac8743fcc3)

Author SHA1 Message Date
Tobias Hilbrich 29c2afdb30 Fix hanging powershell
Powershell can try to read additional commands from stdin. The `< nul` makes
sure it reads an EOF and properly returns.

The motivation for this change was a hanging WebRTC build job on an automated
build machine.

R=iannucci@chromium.org, vadimsh@chromium.org

Details:
https://stackoverflow.com/questions/2041799/powershell-script-gets-stuck-doesnt-exit-when-called-from-batch-file
Bug:
Change-Id: I51df3927644ca3a7e212089e0c414e2e8eb0c02a
Reviewed-on: https://chromium-review.googlesource.com/549317
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Robert Iannucci a297b40f8a [cipd.bat] Switch cipd.bat to use -Command.
-File something.ps1 args is SUPPOSED to pass args (i.e. the rest of the
command line) through to the script. It seems, however, that it's
actually parsing the rest of the command line and throws up its
hands at a parameter like '-'.

-Command, however, seems to work.

R=vadimsh@chromium.org

Bug:
Change-Id: I617bf43f5b27bd2d0246106ab10b28e0a2fdd901
Reviewed-on: https://chromium-review.googlesource.com/495566
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Robert Iannucci 5ededcb5f2 Clear Zone.Identifier to allow depot_tools.zip bootstrap
BUG=680274

Change-Id: I47fd8d7a5380aca49c873006c4f66732b21bee37
Reviewed-on: https://chromium-review.googlesource.com/427323
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Vadim Shtayura d3cee645d7 Revert "Allow cipd.ps1 execution even if it was fetched from depot_tools.zip."
This reverts commit 15f122ee64.

Reason for revert: lots of bots are running Powershell 2. the 
new step fails on them (non-fatally though, just generating 
errors in the log, e.g. https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/357219/steps/ensure%20git%20tooling%20on%20windows/logs/stdio)

Original change's description:
> Allow cipd.ps1 execution even if it was fetched from depot_tools.zip.
> 
> Windows keeps track of files downloaded from the Internet and powershell by
> default refuses to execute them (even with RemoteSigned policy). We need to
> explicitly unblock the file first.
> 
> Note: it requires Powershell >= 3.0.
> 
> R=dpranke@chromium.org, iannucci@chromium.org
> BUG=663843
> 
> Change-Id: Id681f4058f906fa4782a360be184d132d837ae78
> Reviewed-on: https://chromium-review.googlesource.com/424327
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
> 

TBR=iannucci@chromium.org,vadimsh@chromium.org,dpranke@chromium.org,chromium-reviews@chromium.org
BUG=663843
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ibdc58e60d3f35a760de45bc1f71c88c1c4d2f2df
Reviewed-on: https://chromium-review.googlesource.com/424872
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
8 years ago
Vadim Shtayura 15f122ee64 Allow cipd.ps1 execution even if it was fetched from depot_tools.zip.
Windows keeps track of files downloaded from the Internet and powershell by
default refuses to execute them (even with RemoteSigned policy). We need to
explicitly unblock the file first.

Note: it requires Powershell >= 3.0.

R=dpranke@chromium.org, iannucci@chromium.org
BUG=663843

Change-Id: Id681f4058f906fa4782a360be184d132d837ae78
Reviewed-on: https://chromium-review.googlesource.com/424327
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
8 years ago
Robert Iannucci 2188fe944f Add cipd bootstrap scripts to depot_tools.
This takes advantage of powershell on windows for a cleanish duplicate of the
posix version.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=663843

Change-Id: Ib23a044ff912e3239b58848a26143eb6575826d5
Reviewed-on: https://chromium-review.googlesource.com/414228
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
8 years ago