Commit Graph

4 Commits (1101645d533f44d3fe650d1635fa4bbe2b6eb716)

Author SHA1 Message Date
Dan Jacques 1b9a43aab3 Remove special Cygwin PATH manipulation from .bat.
Several boilerplate batch files include a provision to prepend
"depot_tools" to PATH prior to running those tools. This undermines
the utility of PATH overrides, since these tools specifically force their
"depot_tools" sub-paths to be used regardless of environment.

The origin of this behavior is likely limited to a specific fix for a
specific problem, but was then perpetuated by the copy/paste of
boilerplate bootstrap code as more bootstraps were added.

This is important in upcoming configurations, where core tools such as
Python and Git will be overridden via PATH on the bots.

Cygwin users who depended on this behavior should just add "depot_tools"
to their PATH in the appropriate location (i.e. in their .bashrc).

BUG=chromium:714293, chromium:724902
TEST=None

Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537
Reviewed-on: https://chromium-review.googlesource.com/510290
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
maruel@chromium.org 70444a0907 Fix EOL issues.
Set svn:eol-style=CRLF for all .bat files and everything in bootstrap/win/
Set svn:eol-style=LF for everything else.

Also delete depot_tools/git_cl/ since it's not used anymore.
Review URL: http://codereview.chromium.org/8055016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103051 0039d316-1c4b-4281-b951-d872f2087c98
14 years ago
sgk@google.com b671b22335 Add setlocal so {cpplin,gcl}.bat don't repeatedly add \depot_tools to %PATH%.
Review URL: http://codereview.chromium.org/201062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@25751 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org 6607d4d923 Adding cpplint.bat to depot_tools.
so you can type only cpplint in console like the other scripts(gclient, gcl, etc)

BUG=None
TEST=None

Patch contributed by thiago.farina@gmail.com


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@22576 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago