This change moves most of the code into presubmit_support and gclient_utils and just leaves the formatting differences for the messages between the two tools.
Review URL: http://codereview.chromium.org/6719004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79002 0039d316-1c4b-4281-b951-d872f2087c98
output object, I forgot to modify the commit command, and so now we're
ignoring failures complete. That's not good :(
Landing w/o review (but with unit tests!) to minimize damage.
Review URL: http://codereview.chromium.org/6688017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78627 0039d316-1c4b-4281-b951-d872f2087c98
bugs that for some reason the presubmit missed the first time around.
TBR=chase@chromium.org,maruel@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78497 0039d316-1c4b-4281-b951-d872f2087c98
"Fix regression introduced in r78329."
"Modify gcl to use suggested_reviewer output from presubmit_support."
My quick fix was insufficient.
TBR=dpranke
Review URL: http://codereview.chromium.org/6667042
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78356 0039d316-1c4b-4281-b951-d872f2087c98
This really needs a unit test.
TBR=dpranke
TEST=none
Review URL: http://codereview.chromium.org/6670046
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78355 0039d316-1c4b-4281-b951-d872f2087c98
EDITOR environment variable shouldn't be required anymore
can contain quotes and multiple arguments.
Uses shell=True to let the shell parse the quoted string
instead of handling all forms of quotes ourselves.
By default, msysgit ships with the TERM environment variable
set, when set to 'msys', we prepend 'env' to the executed
command. That is required so msys knows which program
to run the given file.
BUG=none
TEST=On many platforms. Win7, WinXP, Ubuntu.
Review URL: http://codereview.chromium.org/6685062
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78332 0039d316-1c4b-4281-b951-d872f2087c98
It also simplifies all of the PresubmitResult* objects and the way we're using output streams since we can assume more about how the callers are calling us.
Note that I uses PEP-8 style method names where I was adding entirely new classes (or rewriting existing classes completely) since per maruel@ he is trying to new that style for new code.
This change also contains two small changes to git_cl to fix bugs and restore the previous behavior of --force skipping the presubmit checks.
Review URL: http://codereview.chromium.org/6694009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78328 0039d316-1c4b-4281-b951-d872f2087c98
something with spaces in it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6686046
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78027 0039d316-1c4b-4281-b951-d872f2087c98
It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.
BUG=70548
TEST=check $TERM in windows
Review URL: http://codereview.chromium.org/6686027TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6683033
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77972 0039d316-1c4b-4281-b951-d872f2087c98
It is cleaner this way since in Win32 console, the
value is always "dumb" while in msysgit it is always
"msys" The user shouldn't change the value of $TERM
in msysgit otherwise their whole copy of msysgit
will be flaky.
BUG=70548
TEST=check $TERM in windows
Review URL: http://codereview.chromium.org/6686027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77954 0039d316-1c4b-4281-b951-d872f2087c98
An explicit msysgit check is needed since it requires
the usage of 'env' to open the editor.
BUG=70550, 70548
TEST=Win,Linux
Review URL: http://codereview.chromium.org/6680019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77946 0039d316-1c4b-4281-b951-d872f2087c98
Editor doesn't come up due to Shell=True
BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77913 0039d316-1c4b-4281-b951-d872f2087c98
gcl is now fully compatible with msysgit.
BUG=70550
TEST=gcl change through msysgit.
Review URL: http://codereview.chromium.org/6689001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77909 0039d316-1c4b-4281-b951-d872f2087c98
Don't block execution.
Python 2.4 has been untested for a while and may break unexpectedly.
TEST=manual testing
BUG=none
Review URL: http://codereview.chromium.org/5110009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66870 0039d316-1c4b-4281-b951-d872f2087c98
Improve SendToRietveld to hardcode less function arguments.
TEST=manually tested that gcl works on both chromium and non-chromium rietveld instances
BUG=none
Review URL: http://codereview.chromium.org/5015005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66499 0039d316-1c4b-4281-b951-d872f2087c98
Most of them are style issues or variable aliasing.
TEST=Can almost enable pylint warnings
BUG=none
Review URL: http://codereview.chromium.org/4360002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
Upload hook are only run with the --upload flag.
Most of the time the same hook is run in both case so gcl presubmit is simply 2x
slower than it could be otherwise.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4277003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64779 0039d316-1c4b-4281-b951-d872f2087c98
This makes gcl to use a specific rietveld instance per change list. This is
useful when moving from one rietveld instance to another, so in-flight reviews
are sent to the right instance.
Also clear gcl.CODEREVIEW_SETTINGS between gcl_unittest tests to remove tests interference.
TEST=updated unit tests
BUG=none
Review URL: http://codereview.chromium.org/4218006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64631 0039d316-1c4b-4281-b951-d872f2087c98
The new format will be introduced in the next change.
TEST=not much, mostly manually tested.
BUG=none
Review URL: http://codereview.chromium.org/4106011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64600 0039d316-1c4b-4281-b951-d872f2087c98
Doing static analysis on the script greatly easy refactoring since it reduces
the chances of leaving a typo in rarely executed & untested & untested code.
This is in preparation to refactor changelist on-disk format to use json.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4184008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64427 0039d316-1c4b-4281-b951-d872f2087c98
It happens when a user uses --diff foo.diff so the list of file is not defined.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62547 0039d316-1c4b-4281-b951-d872f2087c98
smarter about finding the most appropriate settings file.
Before this change, I inadvertently did a [gcl try] on a chrome-internal
change (it was a trivial change and not really secret, so no harm done).
After this change, that won't be possible.
Also, change breakpad to not upload the exception that is thrown when
the user fails to provide correct log-on credentials.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3390013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61738 0039d316-1c4b-4281-b951-d872f2087c98
It doesn't give me useful information.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3493005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60209 0039d316-1c4b-4281-b951-d872f2087c98
I saw that in the exceptions and the current error (file not found) is not useful.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3332017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58978 0039d316-1c4b-4281-b951-d872f2087c98
BUG=none
TEST=gcl upload works when there's no codereview.settings in the cache.
Review URL: http://codereview.chromium.org/3366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58270 0039d316-1c4b-4281-b951-d872f2087c98
It must always be present.
BUG=none
TBR=none
Review URL: http://codereview.chromium.org/3280013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@58060 0039d316-1c4b-4281-b951-d872f2087c98
It's broken on 10.5.2.
TEST=gcl works all the time on Mac
TBR=nsylvain
Review URL: http://codereview.chromium.org/3169044
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57381 0039d316-1c4b-4281-b951-d872f2087c98
This way the function is much more similar to subprocess.call(). Further changes
will be done, to be able to convert all the function, to be able to parallelize
output without corrupting it.
Used pylint to verify call graph correctness, causing some other unrelated
changes.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/3117039
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57369 0039d316-1c4b-4281-b951-d872f2087c98
It contradicts the previous changes to enforce codereview.settings.
TEST=new unit test
BUG=none
Review URL: http://codereview.chromium.org/3171026
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57195 0039d316-1c4b-4281-b951-d872f2087c98
Original Description:
Remove code duplication and improve style.
Create a Popen function to reduce code duplication.
Use RemoveDirectory where relevant.
Make drover slightly more posix friendly.
Review URL: http://codereview.chromium.org/3199011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@57083 0039d316-1c4b-4281-b951-d872f2087c98
Create a Popen function to reduce code duplication.
Use RemoveDirectory where relevant.
Make drover slightly more posix friendly.
Review URL: http://codereview.chromium.org/3126020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@56893 0039d316-1c4b-4281-b951-d872f2087c98
dpranke@chromium.org
maruel@chromium.org
mhm@chromium.org
bauerb@chromium.org
thomasvl@chromium.org
jam@chromium.org
evan@chromium.org
joi@chromium.org
thestig@chromium.org