174c293382
tryserver module: fix in set_failure_hash
...
set_failure_hash assumes that (StepFailure is raised) => (some steps
were ran), which is not a correct implication.
Check that there was a step before.
R=iannucci@chromium.org
BUG=
Change-Id: I36ad187584cb42696676e3339f6a77fc77dfd3b1
Reviewed-on: https://chromium-review.googlesource.com/412994
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
7da798be10
infra_paths: do nothing if path_config is not specified
...
Currently if path_config is not specified, infra_paths
defaults to buildbot paths. We want to make this behavior explicit,
so we don't have to introduce a new "luci" path configuration which
tells infra_paths module to do nothing.
Buildbot now specifies path_config=buildbot since
https://chromium-review.googlesource.com/c/412029/ ,
so now we can remove this default.
This also affects all expectation files because this CL switches
the default path configuration from Buildbot to LUCI.
In particular, it changes default git cache dir from [GIT_CACHE]
to [CACHE]/git.
Also code paths that work only in Buildbot environment has to
have a test with path_config=buildbot.
R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586
Change-Id: Ifeabe13e69810dd24a6deb4830699f8c9fafafae
Reviewed-on: https://chromium-review.googlesource.com/411989
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
fbf01c5431
remove slave_build path
...
slave_build path, defined by infra_paths module, is unnecessarily tied
to our buildbot setup which we are trying to deprecate in favor of LUCI.
In practice it is always == start_dir and that's what we want in LUCI too.
Update all code that uses slave_build path to use start_dir instead.
R=iannucci@chromium.org, martiniss@chromium.org
BUG=662586
Change-Id: Id52aa535d6a4f52670d581bf56aab65f670b1861
Reviewed-on: https://chromium-review.googlesource.com/412075
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
8 years ago
9701c7c16d
Recipes: Stop using tryserver_gerrit in depot_tools.
...
Only changes how test properties are given, no change in functionality.
Should enable recipe roll of https://codereview.chromium.org/2464673002 .
R=martiniss@chromium.org,machenbach@chromium.org
BUG=chromium:645616
Review-Url: https://codereview.chromium.org/2468373002
8 years ago
51a7b096ca
bot_update: understand new Gerrit patch properties.
...
This change is backwards compatible, so no expectation changes expected
in downstream rolls.
Depends on https://codereview.chromium.org/2442173003 recipe_engine
change.
BUG=645616
R=martiniss@chromium.org,machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2439373002
8 years ago
456ca7f0c2
tryserver recipe_module: Add get_tags.
...
Lets you get CL tags for a given CL.
BUG=591172
Review-Url: https://codereview.chromium.org/1915833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300658 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
08315d9073
Avoid computing patch_root in get_files_affected_by_patch.
...
Context: See https://codereview.chromium.org/1934533002/#msg19 for context.
Allows: https://codereview.chromium.org/1933223002
Next - testing that it works for skia, upgrading old users to new method,
and finally killing old code.
R=machenbach@chromium.org,rmistry@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/1927403003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300395 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
25837199f3
Revert of Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
...
Hopefully everything will be back to normal now...
Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
TBR=iannucci@chromium.org,hinoka@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915033006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300210 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
d34c90601f
Reland of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #1 id:1 of https://codereview.chromium.org/1917263002/ )
...
Reason for revert:
re-landing because wrong order of reverts :(
Original issue's description:
> Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
>
> Reason for revert:
> breaks skia bots :(
>
> Original issue's description:
> > depot_tools: add infra_paths recipe module for infra-specific paths
> >
> > Depends on https://codereview.chromium.org/1906323003
> >
> > BUG=chromium:605919
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
>
> TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300199
TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1921373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300200 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
54e0d26399
Revert of depot_tools: add infra_paths recipe module for infra-specific paths (patchset #2 id:20001 of https://codereview.chromium.org/1915463002/ )
...
Reason for revert:
breaks skia bots :(
Original issue's description:
> depot_tools: add infra_paths recipe module for infra-specific paths
>
> Depends on https://codereview.chromium.org/1906323003
>
> BUG=chromium:605919
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300184
TBR=iannucci@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1917263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300199 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f30e872853
depot_tools: add infra_paths recipe module for infra-specific paths
...
Depends on https://codereview.chromium.org/1906323003
BUG=chromium:605919
Review URL: https://codereview.chromium.org/1915463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300184 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
4c3969479a
depot_tools: import bot_update gclient git rietveld tryserver recipe modules (reland #1 )
...
Previous attempt: https://codereview.chromium.org/1642023002
TBR=martiniss
BUG=582074
Review URL: https://codereview.chromium.org/1651033004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298519 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f77c42a6a3
Revert of depot_tools: import bot_update gclient git rietveld tryserver recipe modules (patchset #6 id:100001 of https://codereview.chromium.org/1642023002/ )
...
Reason for revert:
breakages: https://code.google.com/p/chromium/issues/detail?id=582229
Original issue's description:
> depot_tools: import bot_update gclient git rietveld tryserver recipe modules
>
> BUG=582074
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298447
TBR=maruel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582074, 582229
Review URL: https://codereview.chromium.org/1644173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298457 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
29689c6822
depot_tools: import bot_update gclient git rietveld tryserver recipe modules
...
BUG=582074
Review URL: https://codereview.chromium.org/1642023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298447 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
Nodir Turakulov
tandrii
martiniss@chromium.org
phajdan.jr@chromium.org