aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,322 Commits
6 Branches
0 Tags
207 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '083ed2e307'
${ noResults }
Commit Graph

10322 Commits (083ed2e3072fe841d32fb3f9f01d40984e46b067)
 

Author SHA1 Message Date
Michael Achenbach 6592c25524 Suppress python deprecation warning to unblock cpplint 
Bug: 1517826
Change-Id: I78d67bb8d6ac426595c742f4e688f037a1c0b012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5190610
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
 2 years ago
Chenlin Fan 39bc04eb9f New vpython to depot_tools. 
Fixed https://crrev.com/c/5091007

This change includes commits:
0c1a41fa62950eedcaaee58ba7268d3813871e3f vpython: preserve NoDefaultCurrentDirectoryInExePath state
a7a2cf379c762dc22a35fc4e1af9e4dfd8df2785 vpython: remove unused code
65fb8069dc290e3b3cc4765f57a78fbbe0ed2093 vpython: update script used for gathering changes
dca9f0e513fae6d176bd264766dec6c464c38e8e Run compileall in parallel.
a76e08f54c62e239b37f020040382f4918d9e056 cipkg: set NoDefaultCurrentDirectoryInExePath on windows
a4b9b9d8f8ba904212a9ff3a33be76060d380f3c cipkg: append $out to derivation envs
445bf8af01dafa28d86e8aedac9ff091a4c64662 cipkg: add peep-software-deployment as owner
50b7bd75850311895fac95eb602df392d982345f Split the global linter config into per-directory configs.
00e23cbde55df05e0e42f7a574c79ff8bcf589c4 vpython: match tag before verify
ef99f244101ffd1b549c740ef6059b255bdbd49c fix gci-ed warning for vpython and pkgbuild
ba2a688d3175807a5f66ab64afd649c867cf563a vpython: rename vpython_ng to vpython

Change-Id: Iafbbbbd4408f62436cf6af17fe9b86cf5d66d06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5191526
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2 years ago
Brian Ryner 60d2ba87c3 Update cipd_bootstrap_test to use a newer cipd client binary. 
The previous binary was so old that it does not work on recent
versions of macOS.

Note that `cipd selfupdate-roll` requires the cipd package to exist
at the given tag for all platforms that the package has ever been
built for. Therefore, I'm using a revision after the latest platform
was added to the builders.

Change-Id: I865c31a5e3823ffc344bcb6585a29935ef6214a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5191588
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 312cd0453c Reland^3 "Upgrade python to 3.11" 
This is a reland of commit 6a9dd48b27

Bug: 1500415
Change-Id: I9de26bf55de10da15d7c809cc9223b36b7ae31f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5189582
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 8d14454ba4 Remove python2 from bootstrap 
With this change, python2[.bat] will no longer be available in
depot_tools root. vpython continues to work.

Bug: 1376538
Change-Id: Iabe22e4e33d0d79d258068c90128da8de4d3ece1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5170265
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
recipe-roller ad697e33c1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8759241822982743489

recipe_engine:
e3401483e4
  e340148 (mingkong@google.com)
      [Analysis] Roll updated protos.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0e22eee97c3792b71e2b89cb943bef7cdac9110e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5187131
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 7db417c0cd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8759248114162767793

recipe_engine:
3218a30bcf
  3218a30 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from ccbd7fc8f200 to 0d11be367258

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaaf62d03787ddf3aba76ed4936edc2be6016904d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5185327
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Josip Sokcevic cb8b22fa77 [PRESUBMIT] Increase unit test timeout 
Windows is frequently hitting the timeout.

R=gavinmak@google.com

Fixed: 1517377
Change-Id: I86f18767ef11ed8c88f7a3b91b621fc0ea8ef3ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5187116
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Lukasz Anforowicz 388f822682 Explicitly specify `--config-path` when invoking `rustfmt`. 
This prevents `rustfmt` from looking up directory-specific configs (e.g.
`third_party/rust/chromium_crates_io/vendor/tinyvec-1.6.0/rustfmt.toml`)
and using them instead of the Chromium config.

Fixed: 1517348
Change-Id: I5231443479f1f417608ecac263808dc91963948f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5185319
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
 2 years ago
Gavin Mak 85142e0ee1 Upload git traces if bot_update doesn't exit with ok_ret 
Recipe-Nontrivial-Roll: build
Bug: 1517126
Change-Id: I04a6e369a9d0fb50e0dfd18f4bd23ecc0c1c40d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5186756
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 0cba8dd68e [owners] Limit number of concurrent Gerrit connections 
R=gavinmak@google.com

Fixed: 319469729
Change-Id: I955fa17c80cee25bc2163a8bca0234cdbb659f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5186760
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
recipe-roller 095b349ad3 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8759320467243643553

recipe_engine:
a16cd1f023
  a16cd1f (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 73ba3793a856 to d740e2026f68

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibaa5eac11f1ac10106064fb63f21c6afda23396d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5182262
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Josip Sokcevic cd076ba1b0 [git_cl] Limit number of concurrent connections 
When git cl status is executed, it's possible that Gerrit will throttle
some requests. This change sets upper bound of concurrent connections to
20.

R=gavinmak@google.com

Fixed: b/319248186
Change-Id: I51b1d87109447efc8c86d615f12bcafe8c317a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5181274
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
recipe-roller 6953ebe3c1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8759434341725238193

recipe_engine:
8c34b0b3f3
  8c34b0b (mohrr@google.com)
      [defer] Allow suppressing results in contexts

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie4d64f4efc8b775310e6ef682f78c32e4893ddf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5177077
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Yuanjun Huang 35a5306635 [depot_tools] update lucicfg v1.43.2 -> v1.43.3 
To release dynamic_builder_template rule for buildbucket configs.

Changes in lucicfg:
5404f7b170..22aebefcfa/lucicfg

Changes in infra:
374d7c959..9827af897

Bug:1502021
Change-Id: I37ecea6a4cb744d76694245c026d42c5ee4313a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5170108
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
 2 years ago
Josip Sokcevic 783c919a44 Revert "Upgrade python to 3.11" 
This reverts commit 6a9dd48b27.

Reason for revert: breaks release branches

Original change's description:
> Reland "Reland "Upgrade python to 3.11""
>
> This is a reland of commit 32c1207c9e
>
> Original change's description:
> > Reland "Upgrade python to 3.11"
> >
> > This is a reland of commit 6a167d1e1f
> >
> > Original change's description:
> > > Upgrade python to 3.11
> > >
> > > R=bryner
> > >
> > > Bug: 1500415
> > > Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> > > Reviewed-by: Brian Ryner <bryner@google.com>
> > > Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
> >
> > Bug: 1500415
> > Change-Id: I0cce81772186a26c3bdb67c5b49ce383b8a1443e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118884
> > Commit-Queue: Peter Wen <wnwen@chromium.org>
> > Reviewed-by: Brian Ryner <bryner@google.com>
>
> Bug: 1500415
> Change-Id: I01872caa1bb0bf75e3696edb7bb07dc33aeb6ce6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5165860
> Reviewed-by: Brian Ryner <bryner@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1500415
Change-Id: I55a6f75d1003bcbc2236cf15c6e556f1ed842b92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5170270
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 6a9dd48b27 Reland "Reland "Upgrade python to 3.11"" 
This is a reland of commit 32c1207c9e

Original change's description:
> Reland "Upgrade python to 3.11"
>
> This is a reland of commit 6a167d1e1f
>
> Original change's description:
> > Upgrade python to 3.11
> >
> > R=bryner
> >
> > Bug: 1500415
> > Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> > Reviewed-by: Brian Ryner <bryner@google.com>
> > Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 1500415
> Change-Id: I0cce81772186a26c3bdb67c5b49ce383b8a1443e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118884
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Brian Ryner <bryner@google.com>

Bug: 1500415
Change-Id: I01872caa1bb0bf75e3696edb7bb07dc33aeb6ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5165860
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
William Hesse b4adf17316 Fix git_cache to not use bare repository git-dir flag on regular checkouts 
The git_cache command was changed to use the new git-dir flag when
operating on the bare repository checkouts in its cache, but
also added it to the git commands operating on the regular repository
checkouts backed by that cache.

Reverts part of CL https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5165856

Bug: b/294415576
Bug: b/318661838
Change-Id: I620efd2615aab787cf6eb2b460a1a2027c70c473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5168708
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 259976c748 Fix git_cache when safe.bareRepository=explicit 
R=gavinmak@google.com

Bug: b/294415576
Change-Id: I10523e8c5973c0ca934d549d15c2195346edfbd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5165856
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 86752e9a55 Update repo_launcher to 2.40 
Bug: 1515383
Change-Id: Iaae10a7482e09943ea8b84bb97d97ebbf2dff642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5166208
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
 2 years ago
Josip Sokcevic 6c1a07d48a [git_number] Improve error message on parse_commitrefs 
We are observing "binascii.Error: Non-hexadecimal digit found" on LUCI,
but it's not reproducible on local env.

This change also triggers the recipe roller.

R=gavinmak@google.com

Bug: 1514645
Change-Id: I4b97c4593b117d145f8304069d569607033babbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5160257
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Michael Anthony Knyszek 0214c08320 [lucicfg] Update v1.43.1 -> v1.43.2. 
The most notable change is the addition of the NEWEST_FIRST
luci-scheduler policy. Note: this CL doesn't set the package's
git_revision to the exact commit where the version was updated and then
rolled into infra/infra because the package builders were down at the
time. Instead, it updates to the first good commit on the package
builders after (374d7c95).

Change-Id: Ie193d70ca41d86e549ac7026d0027528b910c9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5164149
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2 years ago
recipe-roller 7380fdcba2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8759959050220780625

recipe_engine:
1fb142e1c4
  1fb142e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 200dbdf0e967 to 103e5437313b

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0cd65182ac9ea922f027e1260aea3c153f2f6832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5161808
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Josip Sokcevic 450aa8d76c [git_cl] Force lookup CL number 
UploadAllSquashed doesn't have access to `cl` object and can't update
the issue number. When a new cl is uploaded with --dependencies flag,
`cl` that is passed to upload_branch_deps is outdated - GetIssue returns
None.

Instead of passing cl, or overriding cl in CMDupload with one generated
by UploadAllSquashed, simply unset lookedup_issue which forces GetIssue
to read value from git config.

R=gavinmak@google.com

Fixed: 1514055
Change-Id: I8a55807b097d464379aade20d9cfa3c01f1db69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5148352
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Chris Lewis 2bd782954f Update to 2.6.16 
https://crrev.com/c/5085067 introduced `describe` outputting metadata
to the CLI.

Bug: https://crbug.com/1506737

Change-Id: I2567e90da6e0a20437c081099364bd56bc6646d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5161009
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Chris Lewis <cflewis@google.com>
 2 years ago
Josip Sokcevic 31a99001bd Remove dead code 
R=gavinmak@google.com

Change-Id: If27b290ebb575db5ec93b4abcb7f432bedd6f18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5153638
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Josip Sokcevic 751c658593 [gclient] Reuse rev-parse output in verbose mode 
If verbose mode is used, we call rev-parse x2 for each git dependency.
Reusing the value results in 10% reduction for gclient no-op sync (~2s
savings).

R=gavinmak@google.com

Change-Id: I7d1a0a13f2aea3df20b25816fef22ef777a12bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5146995
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Gavin Mak edba22d4eb Fix multiline comment formatting 
Many incorrectly formatted comments exist from the switch to
4 space indent: https://crrev.com/c/4836379

Bug: 1514505
Change-Id: I6366f9da812919bd35b999f18fa8a49b7a66c09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5153633
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 31a590e0cd [scm] Cache ResolveCommit call 
The cache won't be used if ResolveCommit throws an exception or when
non-sha1 is used.

This optimization saves about 7% of overall gclient sync on
chromium/src.

R=gavinmak@google.com

Change-Id: I9c36d937dc7b8553818888e2e9c4eecd029a978c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5147496
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Gavin Mak e010fbf0a5 Remove git drover 
git drover was deprecated 3 years ago in favor of cherry picking:
https://crrev.com/c/2653952

Change-Id: I12273f7691de73eef939a13ac5a4fdfec65356f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5153632
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 42b995792c [gclient] Cache rev-list HEAD call 
This optimization saves about 9% of overall gclient sync on
chromium/src.

R=gavinmak@google.com

Change-Id: I4700e9db9e91a69746e212f6f04376dfb38bef91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5147495
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Josip Sokcevic 1bdc5c8db4 [presubmit] Don't replace os.environ 
Assigning os.environ the result of os.environ.copy() replaces it
with a standard dict. This breaks reflection into the actual
environment, as well as features such as case-insensitivity on
Windows, leading to undefined standard library behavior.

R=bryner, gavinmak

Bug: 1511316
Change-Id: I63d026387104ae92669256567854f8bf9d2397a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5133887
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Joey Arhar 0e40b92d9e Don't try squashing only one commit 
This patch makes git rebase-update only try squashing when rebasing
fails if there is more than one commit present in the branch it is
rebasing.

Squashing adds an extra step for the user when rebasing fails, and when
there is only one commit, squashing is guaranteed not to help.

Fixed: 1434450
Change-Id: I1952c1172dbf6a44060ed2da2d79ec07d67893d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5068315
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Josip Sokcevic 911ccd864c [win_toolchain] Add DIR_METADATA 
This should route crash reports (e.g. https://crbug.com/1451128) to the
right component.

Fixed: b/285971982
Change-Id: If3391e4fb2b7af4f9fe91261283e8ef79a9e6759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5141486
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 2 years ago
recipe-roller 8191486420 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8760517731482306737

recipe_engine:
110c9cee8a
  110c9ce (bryner@google.com)
      Remove python script added by mistake.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I33ab5317e979c2da0b38fac7617ac9ab60c6656d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5153634
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Ruben Rodriguez Buchillon 007dd45a94 cros: expand to cover more roots 
The background is we maintain a fork of a fork of cros and as we're
moving to submodules this is what our repo looks like e.g. chromite is
at the top, and it's using submodules.

It doesn't seem like this would negatively affect anyone else, and would
make our system a lot simpler.

Change-Id: Ib1c9fd95a36e55fc13bede9bb539daedd5efe0ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5132338
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
 2 years ago
recipe-roller 390005586b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761692344201209681

recipe_engine:
30f87e440d
  30f87e4 (vadimsh@chromium.org)
      Revert "[swarming] [recipe] Use prpc swarming cli for all recipes"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6fd6600a995e5659ae7a59f92023757cf1576d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123955
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Gavin Mak 38c697d3ec Don't print "Updating depot_tools" 
This message is not useful.

Bug: 1418413
Change-Id: I37f92933dd6c5b40229cd8472551c0d1a3b5e962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123952
Reviewed-by: Will Harris <wfh@chromium.org>
Auto-Submit: Gavin Mak <gavinmak@google.com>
Commit-Queue: Will Harris <wfh@chromium.org>
 2 years ago
Robert Iannucci 710996478e [yapf] Update yapf to a version which supports python3.11 syntax. 
R=bryner, yiwzhang@google.com

Change-Id: Iec8b5750d1f4889b301c6efe4ee42b399660897d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123295
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Michael Savigny f26dddb204 Add use_goma deprecation warning to autoninja. 
Adds the same warning to every use_goma build that is currently printed
on a gn gen with use_goma=true.

Bug:b/277197166
Change-Id: Icf9781f814416dfbeb2826fc88372465155fcd2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123231
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
 2 years ago
recipe-roller 5ce8e010db Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761755888906628305

recipe_engine:
242059d678
  242059d (mohrr@google.com)
      [path] Add annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4735ab98d2e8dea44fde597e677e35a7cf96333a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119289
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Helmut Januschka 6444de14d1 fix crash in case HEAD exists as a file 
Bug: 1428373
Change-Id: If9d988d542345dbfa0e02f7c3d6f935b48372df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018937
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
 2 years ago
recipe-roller e29896a0f7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761791744613897537

recipe_engine:
ed4f1addee
  ed4f1ad (jonahhooper@google.com)
      [swarming] [recipe] Use prpc swarming cli for all recipes

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaa3b7ca815f01000ce1b3f83da0415d22ef9eca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119282
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Ben Pastene d6aaf4522a Revert "Reland "Upgrade python to 3.11"" 
This reverts commit 32c1207c9e.

Reason for revert: spec reverting for `FileNotFoundError: shell not found` errors on win-presubmit
https://ci.chromium.org/ui/p/chromium/builders/try/win-presubmit?limit=200
eg
https://ci.chromium.org/ui/p/chromium/builders/try/win-presubmit/377708/overview

Original change's description:
> Reland "Upgrade python to 3.11"
>
> This is a reland of commit 6a167d1e1f
>
> Original change's description:
> > Upgrade python to 3.11
> >
> > R=bryner
> >
> > Bug: 1500415
> > Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> > Reviewed-by: Brian Ryner <bryner@google.com>
> > Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 1500415
> Change-Id: I0cce81772186a26c3bdb67c5b49ce383b8a1443e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118884
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Brian Ryner <bryner@google.com>

Bug: 1500415
Change-Id: Ic57bdd4919f44b38b7edc334dc7e504e19256067
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119766
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2 years ago
Garrett Beaty 7a9218d13f Enable searching starlark files with git gs. 
Change-Id: Ib4688483cca43b10f88cfc529b03e119b8d2d267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119764
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Chan Li 305904f4ee [depot_tools] roll lucicfg to 1.43.1 
To pick up the heartbeat_timeout support

Bug: 5078993
Change-Id: Ic5161516f74f1bfee36cbcb25fd8fed10814619d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119765
Commit-Queue: Randy Maldonado <randymaldonado@google.com>
Auto-Submit: Chan Li <chanli@chromium.org>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
 2 years ago
Josip Sokcevic 32c1207c9e Reland "Upgrade python to 3.11" 
This is a reland of commit 6a167d1e1f

Original change's description:
> Upgrade python to 3.11
>
> R=bryner
>
> Bug: 1500415
> Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> Reviewed-by: Brian Ryner <bryner@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1500415
Change-Id: I0cce81772186a26c3bdb67c5b49ce383b8a1443e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118884
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2 years ago
Josip Sokcevic 18bb70aed6 Revert "Upgrade python to 3.11" 
This reverts commit 6a167d1e1f.

Reason for revert: https://crbug.com/1511105

Original change's description:
> Upgrade python to 3.11
>
> R=bryner
>
> Bug: 1500415
> Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> Reviewed-by: Brian Ryner <bryner@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1500415
Change-Id: I8d0b04ca679c1581d4572e89efbb8cf2012cfa78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118878
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Josip Sokcevic 6a167d1e1f Upgrade python to 3.11 
R=bryner

Bug: 1500415
Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Jeff Yoon d9dab49dc6 [dirmd] Roll dirmd into depot_tools 
Changes included:
* crrev/c/5079176

Bug: 1505875
Change-Id: I5407acdec01043c679228aa09f2577dfd4c614ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5115874
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
 2 years ago