Also added a tiny bit of exponential backoff.
BUG=375479
Review URL: https://codereview.chromium.org/350433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291682 0039d316-1c4b-4281-b951-d872f2087c98
Renewal of OAuth2 credentials did not work on appengine because it
replies with 302 instead of 401 when authentication fails. Configured
it to attempt credentials renewal on a 302.
Of course this will prevent any 302 from working normally, but it works
with Rietveld since it does not use 302.
BUG=319446
Review URL: https://codereview.chromium.org/238273011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264639 0039d316-1c4b-4281-b951-d872f2087c98
When rietveld.py overrides upload.py's logging module, it generally works fine...
until someone tries to run upload.py with any level of verbosity. Then the
calls to logging.getLogger and logging.INFO/logging.DEBUG fail. This patches
upload.py to properly use a module-scope logger so that rietveld.py doesn't
have to perform invasive surgery, and everything just works.
This version of upload.py taken from upstream Rietveld at:
changeset: 1267:d7b39eca7dbe
branch: chromium
R=djacques@chromium.org, maruel@chromium.org
Review URL: https://codereview.chromium.org/221423007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262793 0039d316-1c4b-4281-b951-d872f2087c98
The commit queue can't successfully run presubmit checks on top of
ReadOnlyRietveld because it requires access to the password field to pass
through to presubmit_shim.
R=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/197213003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259611 0039d316-1c4b-4281-b951-d872f2087c98
ssl.SSLError does NOT have 'reason' attribute. Use str() to get a
reliable string.
Fixed the silly bug in another CL: https://codereview.chromium.org/180273003/
The ssl.SSLError does NOT have attribute 'reason', and must use the
generic 'strerror' instead. This is what happens when I submit a CL
too fast...
BUG=346845
R=stip@chromium.org,maruel@chromium.org
Review URL: https://codereview.chromium.org/180723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253317 0039d316-1c4b-4281-b951-d872f2087c98
With the addition of this method, rietveld.py can be used to create cli-based tools to review Chromium code.
BUG=none
Review URL: https://codereview.chromium.org/127083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@244529 0039d316-1c4b-4281-b951-d872f2087c98
This makes exception catching code which compares the code with
numeric values work as expected. pythonis not PHP and 500 != '500'.
BUG=none
Review URL: https://codereview.chromium.org/27260007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228788 0039d316-1c4b-4281-b951-d872f2087c98
The callee needs it to be a string so that it can be made
part of HTTP request. However, in code using Rietveld
it's useful to use non-string types for flags where
Rietveld actually doesn't return strings (say booleans).
One example is the commit flag, which is a boolean.
BUG=291335
Review URL: https://chromiumcodereview.appspot.com/24846002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225748 0039d316-1c4b-4281-b951-d872f2087c98
This will replace the CQ one and allow it to stay in sync with Rietveld.
For now I've only covered methods that CQ seems to touch.
BUG=291335
Review URL: https://chromiumcodereview.appspot.com/24095007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@224455 0039d316-1c4b-4281-b951-d872f2087c98
Add an option to apply_issue to fail if anonymous access
triggers a login prompt.
- cherry-pick upload.py rietveld cl 37c73ece82d0 which
allows clients to request no authentication.
BUG=240634
Review URL: https://chromiumcodereview.appspot.com/20634003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214023 0039d316-1c4b-4281-b951-d872f2087c98
Very long comments, like when posting a diff that failed to apply, cause extra
burden on the Commit Queue logs.
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11929027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@177713 0039d316-1c4b-4281-b951-d872f2087c98
I've found it helpful and instructive to see what we're posting to
rietveld. Let's add it as a debug log for others too. Can be helpful
to debug certain network issues.
Review URL: https://chromiumcodereview.appspot.com/11778015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@175361 0039d316-1c4b-4281-b951-d872f2087c98
Multiple presubmit checks may call the same function multiple times, so it's
worth caching the results to speed up the presubmit check run.
Convert presubmit_support, git-cl and gcl to use it.
R=dpranke@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11280143
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169726 0039d316-1c4b-4281-b951-d872f2087c98
If a file is empty, it's not a binary file in the first place. This is to
protect against improper uploads.
From light testing, it seems binary file support is totally broken. This needs to be verified throughout before being enabled back.
TBR=rogerta@chromium.org
BUG=23608
Review URL: https://chromiumcodereview.appspot.com/11016032
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159941 0039d316-1c4b-4281-b951-d872f2087c98
This brings back git cl try to try at LKGR instead of HEAD, which is coherent
with git-try and gcl try.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10963013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157810 0039d316-1c4b-4281-b951-d872f2087c98
This is mainly to reduce the spam that the commit queue adds to
commit-bot@chromium.org as all follow up emails on code reviews are sent to it
because it was adding itself as a reviewer, even if it is not.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10918075
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@155141 0039d316-1c4b-4281-b951-d872f2087c98
This ensures we don't send incorrect values like None or random strings.
R=cmp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10836348
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@152756 0039d316-1c4b-4281-b951-d872f2087c98
authentication. Also allow apply_issue.py to specify a username if needed.
BUG=43563
TEST=Make sure that sending try jobs directly from rietveld works.
Review URL: https://chromiumcodereview.appspot.com/10704111
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@145600 0039d316-1c4b-4281-b951-d872f2087c98
on http://codereview.appspot.com/6221063/ which makes sure that rietveld will
upload non-image binary files.
BUG=23608
TEST=Use apply_issue.py with an issue that contains binary files, and make
sure the files download correctly.
Review URL: https://chromiumcodereview.appspot.com/10422006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138472 0039d316-1c4b-4281-b951-d872f2087c98
Rietveld doesn't post the message when it is too large.
R=petermayo@chromium.org
BUG=
TEST=Now the CQ should stop having weird case where it doesn't post a message on
CQ failure. It was because the message was simply too long!
Review URL: http://codereview.chromium.org/10383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135326 0039d316-1c4b-4281-b951-d872f2087c98
Rietveld self-corrupts its status all the time, there is not point in bailing
just because of that. So just assume it's an 'M' and it'll work fine. In any
case, the diff is properly parsed to detect what was the real operation.
Add unit test that correctly process a deleted file with status:null.
TBR=nsylvain@chromium.org
BUG=
TEST=A corrupted patchset can still be committed with the Commit Queue.
Review URL: http://codereview.chromium.org/10272024
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@134733 0039d316-1c4b-4281-b951-d872f2087c98
r123775 contained copy-paste left-over that caused the code to throw a NameError
instead of a HTTPError.
R=petermayo@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9536014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@124184 0039d316-1c4b-4281-b951-d872f2087c98
Occasionally, AppEngine throws HTTP 500. In practice it's not a big deal but
upload.py converts them into sys.exit() call which is problematic. This breaks
the commit queue since this behaviors forces the CQ to quit.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9480005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@123775 0039d316-1c4b-4281-b951-d872f2087c98
It's annoying to have it crash much later in a member function call when a
trailing backslash is provided.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8056016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103058 0039d316-1c4b-4281-b951-d872f2087c98
Add support for a few svn:* properties.
Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway.
More testing.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7840003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99952 0039d316-1c4b-4281-b951-d872f2087c98
That means some properties will being to be applied.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7776015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98
hinoka@chromium.org
sergiyb@chromium.org
pgervais@chromium.org
agable@chromium.org
sergeyberezin@chromium.org
machenbach@chromium.org
dtseng@chromium.org
phajdan.jr@chromium.org
chrisphan@chromium.org
ilevy@chromium.org
maruel@chromium.org
rogerta@chromium.org