We aren't using --git-cache on bots anymore, so we shouldn't need to
point people to the CrOS fork. Everything else is merged upstream.
Bug: b/187784544
Change-Id: Ifd261ce509b9b501c49c2b567be17e4d9014913c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5311255
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
This shouldn't really happen, but who knows what users might
(accidentally) try to do.
Change-Id: Ic968f133693532a816b9bd3c8c5b97cba3261bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5309411
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Sergey Frolov <sfrolov@google.com>
Commit-Queue: Sergey Frolov <sfrolov@google.com>
Leave the recipes/ code at 2 space to match the rest of the recipes
project in other repos.
Reformatted using:
files=( $(
git ls-tree -r --name-only HEAD | \
grep -Ev -e '^(third_party|recipes)/' | \
grep '\.py$';
git grep -l '#!/usr/bin/env.*python' | grep -v '\.py$'
) )
parallel ./yapf -i -- "${files[@]}"
~/chromiumos/chromite/contrib/reflow_overlong_comments "${files[@]}"
The files that still had strings that were too long were manually
reformatted because they were easy and only a few issues.
autoninja.py
clang_format.py
download_from_google_storage.py
fix_encoding.py
gclient_utils.py
git_cache.py
git_common.py
git_map_branches.py
git_reparent_branch.py
gn.py
my_activity.py
owners_finder.py
presubmit_canned_checks.py
reclient_helper.py
reclientreport.py
roll_dep.py
rustfmt.py
siso.py
split_cl.py
subcommand.py
subprocess2.py
swift_format.py
upload_to_google_storage.py
These files still had lines (strings) that were too long, so the pylint
warnings were suppressed with a TODO.
auth.py
gclient.py
gclient_eval.py
gclient_paths.py
gclient_scm.py
gerrit_util.py
git_cl.py
presubmit_canned_checks.py
presubmit_support.py
scm.py
Change-Id: Ia6535c4f2c48d46b589ec1e791dde6c6b2ea858f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4836379
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Since we have a wrapper around the launcher, we can move the two
minor changes to that:
(1) The shebang is already ignored as we run the script via
sys.executable which is the active version of Python.
(2) The custom repo url can be set via an environment variable.
Change-Id: If9f940086ab87a6816e6a3f5c789ccb5702847c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4697333
Commit-Queue: Tim Bain <tbain@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Tim Bain <tbain@google.com>
We're looking at dropping Python 3.5 support from repo. Lets roll
this back out in Chromium a little early to get a better idea of
who is still relying on it.
Change-Id: Idcdd5b0a957f5a2f8b146149c407c26347be0aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830590
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Debian is deleting /usr/bin/python by default, so re-use the existing
python3 interp that our wrapper was invoked with.
Bug: 1182059
Test: `./repo` still works w/out /usr/bin/python
Change-Id: I1806f2ae2f8c6fe8b5f5a95fd2e50735d6e3196a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2715994
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Give people one more month before we make 3.6 a hard requirement.
Change-Id: Ieb471b917c5ef5b9cb20b321305c4c13af675109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575635
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Give people one more month before we make 3.6 a hard requirement.
Change-Id: I696bf3f0edbe64d6294dd626fc9ff16c9e44fd87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2570017
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
It looks like some bots don't have this for whatever reason.
Bug: 1148984
Change-Id: I7ff826e0a0df78e3be9e1f84698b69574c75f71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2567384
Reviewed-by: Sean McAllister <smcallis@google.com>
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This is a reland of 19512276d2.
It includes an update to .gitattributes for recipes.
Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
Bug: 1148984
Change-Id: Ia7844016cb04d3197e51ad05da64c885cf3277a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2561229
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This reverts commit 19512276d2.
Reason for revert: broke ART bots.
Bug: 1153114
Original change's description:
> repo: auto-update depot_tools when used
>
> Since gclient automatically syncs this checkout when used,
> have repo do the same for CrOS users.
>
> Bug: 1148984
> Test: ran and saw it auto-update when used externally
> Test: ran and saw it not auto-update when used inside of a repo checkout
> Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Michael Mortensen <mmortensen@google.com>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>
TBR=vapier@chromium.org,ehmaldonado@chromium.org,mmortensen@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,mmortensen@chromium.org
Change-Id: Ic0ac9155e3acde87966f518213a5a8440e167295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2560955
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Since gclient automatically syncs this checkout when used,
have repo do the same for CrOS users.
Bug: 1148984
Test: ran and saw it auto-update when used externally
Test: ran and saw it not auto-update when used inside of a repo checkout
Change-Id: I56b9a45ef3a9ed501f6277e8f8357d4719cf2557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2537164
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This pulls the latest version from upstream.
This drops the custom keys Chromium has been carrying.
We switched our release signing over to the official key,
so there's no need for ours anymore.
The new version will attempt to use Python 3 if available
and whine if it's not. It shouldn't cause errors, just new
warnings, but it should help us track down old systems.
Bug: https://crbug.com/gerrit/10418
Test: `repo sync` still works
Change-Id: I915d0874a1642880831964f91c4632f9d17a1e4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2044341
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
These are mostly about rolling in Python 3 encoding fixes.
Bug: None
Test: `repo sync` works w/Python 3
Change-Id: I7d749a3a62523a7c802fb0ed7dcd383868df1d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1809420
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
This is mostly for Python 3 improvements.
Bug: gerrit:10418
Change-Id: Ice96b8dc5f700015ae6ec53c0e5b86700bcf6532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1734587
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
This rolls a few changes from upstream noticed by early testing.
Bug: 900461
Change-Id: Iea568be41e3149a667fba655576bdd591b353079
Reviewed-on: https://chromium-review.googlesource.com/c/1387706
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.
BUG=chromium:632203
TEST=`repo sync` still works
Review-Url: https://codereview.chromium.org/2402193002
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.
BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted
Review-Url: https://codereview.chromium.org/2340073002
We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.
BUG=chromium:339665
TEST=repo sync works
Review URL: https://codereview.chromium.org/146723003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@249277 0039d316-1c4b-4281-b951-d872f2087c98
This is necesary to force an existing repo working directory to check
out a new version of the repo tool which has been signed with a new
key.
R=cmp@chromium.org
Review URL: https://codereview.chromium.org/22909004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@217347 0039d316-1c4b-4281-b951-d872f2087c98
This is backwards compatible, and should be done prior
to upgrading repo's internals to 1.9.4.
BUG=chromium-os:31841
TEST=manual validation
Review URL: https://chromiumcodereview.appspot.com/10541155
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@142238 0039d316-1c4b-4281-b951-d872f2087c98
The purpose of this is so that cros can roll out repo updates at our
own pace (including testing), rather than being at the mercy of android
project rolling something out that may break our setup.
BUG=chromium-os:24413
Review URL: http://codereview.chromium.org/9021045
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115533 0039d316-1c4b-4281-b951-d872f2087c98
the current canonical upstream. The Chromium mirror is out of date.
Review URL: http://codereview.chromium.org/8540026
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109742 0039d316-1c4b-4281-b951-d872f2087c98
Yiwei Zhang
Mike Frysinger
Andrii Shyshkalov
Nico Weber
Don Garrett
mmoss@chromium.org
szager@chromium.org
akeshet@google.com
szager@chromium.org
ferringb@google.com
jeffbailey@chromium.org
tonyg@google.com
maruel@chromium.org
msb@chromium.org
scottz@google.com