Commit Graph

8 Commits (main)

Author SHA1 Message Date
Mike Frysinger 124bb8e53c switch to 4 space indent
Leave the recipes/ code at 2 space to match the rest of the recipes
project in other repos.

Reformatted using:
files=( $(
	git ls-tree -r --name-only HEAD | \
		grep -Ev -e '^(third_party|recipes)/' | \
		grep '\.py$';
	git grep -l '#!/usr/bin/env.*python' | grep -v '\.py$'
) )
parallel ./yapf -i -- "${files[@]}"
~/chromiumos/chromite/contrib/reflow_overlong_comments "${files[@]}"

The files that still had strings that were too long were manually
reformatted because they were easy and only a few issues.
autoninja.py
clang_format.py
download_from_google_storage.py
fix_encoding.py
gclient_utils.py
git_cache.py
git_common.py
git_map_branches.py
git_reparent_branch.py
gn.py
my_activity.py
owners_finder.py
presubmit_canned_checks.py
reclient_helper.py
reclientreport.py
roll_dep.py
rustfmt.py
siso.py
split_cl.py
subcommand.py
subprocess2.py
swift_format.py
upload_to_google_storage.py

These files still had lines (strings) that were too long, so the pylint
warnings were suppressed with a TODO.
auth.py
gclient.py
gclient_eval.py
gclient_paths.py
gclient_scm.py
gerrit_util.py
git_cl.py
presubmit_canned_checks.py
presubmit_support.py
scm.py

Change-Id: Ia6535c4f2c48d46b589ec1e791dde6c6b2ea858f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4836379
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
Brian Ryner 6cebde7ca2 Update pylint vpython specs to use a specific minor version.
This is always recommended, since wheel availability varies between
minor versions. We may not support major-version-only specifiers
in the future.

Change-Id: Ib41426fa39212fe3e49d87c1d1c8b5bbc49aef7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3708295
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
3 years ago
Josip Sokcevic c3e25c828d Fix hangs when running pylint with py3
R=gavinmak@google.com

Bug: 1280381
Change-Id: I9bec0f371aa300e2418ac1c200683c02b7e66cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3350910
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
3 years ago
Josip Sokcevic 8daaf5c5b0 Explicitly set python version for pylint 2.6
vpython doesn't parse shebang. If python version is not explicitly set
in vpython file, version 2 will be used. pylint 2.6 requires py3.

R=dpranke@google.com

Bug: 1242737
Change-Id: I21a3c4b26c24860b4c8fd07c6d5cc6d5149af2fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3120321
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Dirk Pranke d60b99cd5a Get pylint-2.6 to work under vpython3 on Windows.
This change fixes a minor issue in the pylint-2.6.bat wrapper
script and adds a missing dependency on colorama.

With these changes, it looks like pylint-2.6 will now work on Windows.

Bug: 1157676
Change-Id: Ic23fc4cd04bf464034bf5471856fdfb646f66a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3018262
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
4 years ago
John Budorick 09c9cf419d pylint: roll six to 1.15.0.
Matching chromium. (I'm sure this is asking for trouble.)

Bug: chromium:1007101
Change-Id: Iba3200bd093697f41551c99f58a9c5261c958436
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2726729
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: John Budorick <jbudorick@chromium.org>
4 years ago
Mike Frysinger 8ca189d4e5 pylint-2.6: use newer pyquotes
Bug: 1123433
Change-Id: I60dc7bbcf6216fc90b58d32d99072f998501509d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2518471
Reviewed-by: Owen Rodley <orodley@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
4 years ago
Owen Rodley 5d099fcb48 Add pylint 2.6.0 to depot_tools.
This is the latest version, which supports Python 3 only.

Bug: 1123433
Change-Id: I7516ed52d64f38f8214c6295e9ad3d08a98e2b4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2473704
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago