Leave the recipes/ code at 2 space to match the rest of the recipes
project in other repos.
Reformatted using:
files=( $(
git ls-tree -r --name-only HEAD | \
grep -Ev -e '^(third_party|recipes)/' | \
grep '\.py$';
git grep -l '#!/usr/bin/env.*python' | grep -v '\.py$'
) )
parallel ./yapf -i -- "${files[@]}"
~/chromiumos/chromite/contrib/reflow_overlong_comments "${files[@]}"
The files that still had strings that were too long were manually
reformatted because they were easy and only a few issues.
autoninja.py
clang_format.py
download_from_google_storage.py
fix_encoding.py
gclient_utils.py
git_cache.py
git_common.py
git_map_branches.py
git_reparent_branch.py
gn.py
my_activity.py
owners_finder.py
presubmit_canned_checks.py
reclient_helper.py
reclientreport.py
roll_dep.py
rustfmt.py
siso.py
split_cl.py
subcommand.py
subprocess2.py
swift_format.py
upload_to_google_storage.py
These files still had lines (strings) that were too long, so the pylint
warnings were suppressed with a TODO.
auth.py
gclient.py
gclient_eval.py
gclient_paths.py
gclient_scm.py
gerrit_util.py
git_cl.py
presubmit_canned_checks.py
presubmit_support.py
scm.py
Change-Id: Ia6535c4f2c48d46b589ec1e791dde6c6b2ea858f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4836379
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reduce calling SendProfile to long running commands. There's lots of low hanging fruit (slow commands) to optimize before we need perf stats from fast commands.
R=maruel@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11416230
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170009 0039d316-1c4b-4281-b951-d872f2087c98
This required fixing the adhoc mock to be more versatile.
TBR=cmp@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9178019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117896 0039d316-1c4b-4281-b951-d872f2087c98
I don't want to receive them even in the case of a direct call to SendStack().
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@117039 0039d316-1c4b-4281-b951-d872f2087c98
While re-reading the code, I thought I had found a bug but I hadn't. So I wrote
the test to document the behavior to not make the same error again.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8121001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103772 0039d316-1c4b-4281-b951-d872f2087c98
When running an interactive python prompt, sys.modules['__main__'] has no
__file__ member.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8051027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@103055 0039d316-1c4b-4281-b951-d872f2087c98
Mostly useful for commit-queue as I want to both send the trace and be able to
read it locally.
TBR=jam
Review URL: http://codereview.chromium.org/5608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@68055 0039d316-1c4b-4281-b951-d872f2087c98
When an HTTP exception information is logged, no information is sent by
default. Add an helper function to manually extract interesting information
to append it to the exception type.
Also disable another pylint warning.
TEST=manual test
BUG=none
Review URL: http://codereview.chromium.org/5303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67306 0039d316-1c4b-4281-b951-d872f2087c98
Most of them are style issues or variable aliasing.
TEST=Can almost enable pylint warnings
BUG=none
Review URL: http://codereview.chromium.org/4360002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98
The user will get an idea of what data is sent.
Getting the current working directory is useful to know what checkout was used.
the repr(last_tb) call was stripping off a lot of useful information for
debugging.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3384020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60339 0039d316-1c4b-4281-b951-d872f2087c98
Add an explicit Register() function to be called outside of this file.
Send the host fqdn to help know from where the exception comes. It is useful when a build slave throws an exception.
Review URL: http://codereview.chromium.org/2327003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48455 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise it would return the naked host name most of the time, especially on Windows.
Review URL: http://codereview.chromium.org/2239010
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@48432 0039d316-1c4b-4281-b951-d872f2087c98
Add exception information and not just the stack trace.
Make the url easier to change at runtime.
Review URL: http://codereview.chromium.org/2109001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@47179 0039d316-1c4b-4281-b951-d872f2087c98
The code proved to be robust enough to not do false positive, i.e.
no non-googler stack trace has been uploaded up to date.
So stop wasting users time and just do it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2014012
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@46992 0039d316-1c4b-4281-b951-d872f2087c98
Add a warning message in case the check ever fail.
Review URL: http://codereview.chromium.org/460044
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33700 0039d316-1c4b-4281-b951-d872f2087c98
Client-side implementation.
TODO: Need to automatically disable it for unit tests.
Review URL: http://codereview.chromium.org/444009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33681 0039d316-1c4b-4281-b951-d872f2087c98
Mike Frysinger
tandrii@chromium.org
thakis@chromium.org
ilevy@chromium.org
maruel@chromium.org
msb@chromium.org