From f204d4b81fe17b8b996ab3c18503601499227493 Mon Sep 17 00:00:00 2001 From: "tzik@chromium.org" Date: Thu, 13 Mar 2014 07:40:55 +0000 Subject: [PATCH] Pass through "--filter" arguments from "git cl lint" to cpplint.py Review URL: https://codereview.chromium.org/196943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256776 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/git_cl.py b/git_cl.py index 12f2c87c99..eaed4baf22 100755 --- a/git_cl.py +++ b/git_cl.py @@ -1382,7 +1382,9 @@ def CreateDescriptionFromLog(args): def CMDlint(parser, args): """Runs cpplint on the current changelist.""" - _, args = parser.parse_args(args) + parser.add_option('--filter', action='append', metavar='-x,+y', + help='Comma-separated list of cpplint\'s category-filters') + (options, args) = parser.parse_args(args) # Access to a protected member _XX of a client class # pylint: disable=W0212 @@ -1403,7 +1405,10 @@ def CMDlint(parser, args): files = [f.LocalPath() for f in change.AffectedFiles()] # Process cpplints arguments if any. - filenames = cpplint.ParseArguments(args + files) + command = args + files + if options.filter: + command = ['--filter=' + ','.join(options.filter)] + command + filenames = cpplint.ParseArguments(command) white_regex = re.compile(settings.GetLintRegex()) black_regex = re.compile(settings.GetLintIgnoreRegex())