From e7e9ac66999091fa214cbac63a556aeb9aac0ac6 Mon Sep 17 00:00:00 2001
From: Allen Li <ayatane@chromium.org>
Date: Fri, 12 Jul 2024 01:05:36 +0000
Subject: [PATCH] [git_cl] Add set_config_func parameter

Used to inject git dependency

Bug: b/351024645
Change-Id: Ie5e1f5a18b722a16f236e89c33510c961738d40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5692553
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
---
 git_cl.py | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

diff --git a/git_cl.py b/git_cl.py
index 0ee11a87b..1dad72359 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -34,6 +34,7 @@ import webbrowser
 import zlib
 
 from typing import Any
+from typing import Callable
 from typing import List
 from typing import Mapping
 from typing import NoReturn
@@ -3691,6 +3692,7 @@ class GitAuthConfigChanger(object):
         host_shortname: str,
         mode: GitConfigMode,
         remote_url: str,
+        set_config_func: Callable[..., None] = scm.GIT.SetConfig,
     ):
         """Create a new GitAuthConfigChanger.
 
@@ -3700,6 +3702,8 @@ class GitAuthConfigChanger(object):
             mode: How to configure auth
             remote_url: Git repository's remote URL, e.g.,
                 https://chromium.googlesource.com/chromium/tools/depot_tools.git
+            set_config_func: Function used to set configuration.  Used
+                for testing.
         """
         self._cwd: str = cwd
         self._shortname: str = host_shortname
@@ -3708,6 +3712,7 @@ class GitAuthConfigChanger(object):
         # Base URL looks like https://chromium.googlesource.com/
         self._base_url: str = parts._replace(path='/', query='',
                                              fragment='').geturl()
+        self._set_config_func: Callable[..., str] = set_config_func
 
     @classmethod
     def infer_and_create(cls) -> 'GitAuthConfigChanger':
@@ -3743,12 +3748,12 @@ class GitAuthConfigChanger(object):
         """Apply config changes relating to credential helper."""
         cred_key: str = f'credential.{self._base_url}.helper'
         if self._mode == GitConfigMode.NEW_AUTH:
-            scm.GIT.SetConfig(self._cwd, cred_key, '', modify_all=True)
-            scm.GIT.SetConfig(self._cwd, cred_key, 'luci', append=True)
+            self._set_config(cred_key, '', modify_all=True)
+            self._set_config(cred_key, 'luci', append=True)
         elif self._mode == GitConfigMode.NEW_AUTH_SSO:
-            scm.GIT.SetConfig(self._cwd, cred_key, None, modify_all=True)
+            self._set_config(cred_key, None, modify_all=True)
         elif self._mode == GitConfigMode.OLD_AUTH:
-            scm.GIT.SetConfig(self._cwd, cred_key, None, modify_all=True)
+            self._set_config(cred_key, None, modify_all=True)
         else:
             raise TypeError(f'Invalid mode {self._mode!r}')
 
@@ -3756,14 +3761,14 @@ class GitAuthConfigChanger(object):
         """Apply config changes relating to SSO."""
         sso_key: str = f'url.sso://{self._shortname}/.insteadOf'
         if self._mode == GitConfigMode.NEW_AUTH:
-            scm.GIT.SetConfig(self._cwd, 'protocol.sso.allow', None)
-            scm.GIT.SetConfig(self._cwd, sso_key, None, modify_all=True)
+            self._set_config('protocol.sso.allow', None)
+            self._set_config(sso_key, None, modify_all=True)
         elif self._mode == GitConfigMode.NEW_AUTH_SSO:
-            scm.GIT.SetConfig(self._cwd, 'protocol.sso.allow', 'always')
-            scm.GIT.SetConfig(self._cwd, sso_key, base_url, modify_all=True)
+            self._set_config('protocol.sso.allow', 'always')
+            self._set_config(sso_key, base_url, modify_all=True)
         elif self._mode == GitConfigMode.OLD_AUTH:
-            scm.GIT.SetConfig(self._cwd, 'protocol.sso.allow', None)
-            scm.GIT.SetConfig(self._cwd, sso_key, None, modify_all=True)
+            self._set_config('protocol.sso.allow', None)
+            self._set_config(sso_key, None, modify_all=True)
         else:
             raise TypeError(f'Invalid mode {self._mode!r}')
 
@@ -3771,18 +3776,18 @@ class GitAuthConfigChanger(object):
         """Apply config changes relating to gitcookies."""
         if self._mode == GitConfigMode.NEW_AUTH:
             # Override potential global gitcookie config
-            scm.GIT.SetConfig(self._cwd, 'http.gitcookies', '', modify_all=True)
+            self._set_config('http.gitcookies', '', modify_all=True)
         elif self._mode == GitConfigMode.NEW_AUTH_SSO:
             # Override potential global gitcookie config
-            scm.GIT.SetConfig(self._cwd, 'http.gitcookies', '', modify_all=True)
+            self._set_config('http.gitcookies', '', modify_all=True)
         elif self._mode == GitConfigMode.OLD_AUTH:
-            scm.GIT.SetConfig(self._cwd,
-                              'http.gitcookies',
-                              None,
-                              modify_all=True)
+            self._set_config('http.gitcookies', None, modify_all=True)
         else:
             raise TypeError(f'Invalid mode {self._mode!r}')
 
+    def _set_config(self, *args, **kwargs):
+        self._set_config_func(self._cwd, *args, **kwargs)
+
 
 class _GitCookiesChecker(object):
     """Provides facilities for validating and suggesting fixes to .gitcookies."""