From e52bd5a6ec9cfc7063266b374d1c48fd6d607f0e Mon Sep 17 00:00:00 2001 From: "deymo@chromium.org" Date: Thu, 29 Aug 2013 18:05:21 +0000 Subject: [PATCH] my_activity: Add support for short URLs on gerrit. Added support for the internal and external gerrit short URLs. BUG=None TEST=Ran my_activity.py manualy. URLs work. Review URL: https://chromiumcodereview.appspot.com/23477012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@220340 0039d316-1c4b-4281-b951-d872f2087c98 --- my_activity.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/my_activity.py b/my_activity.py index 4883cdf28..16d3f7dba 100755 --- a/my_activity.py +++ b/my_activity.py @@ -118,10 +118,12 @@ gerrit_instances = [ { 'url': 'gerrit.chromium.org', 'port': 29418, + 'shorturl': 'crosreview.com', }, { 'url': 'gerrit-int.chromium.org', 'port': 29419, + 'shorturl': 'crosreview.com/i', }, ] @@ -394,15 +396,18 @@ class MyActivity(object): issues = map(json.loads, issues) # TODO(cjhopman): should we filter abandoned changes? - issues = map(self.process_gerrit_issue, issues) + issues = [self.process_gerrit_issue(instance, issue) for issue in issues] issues = filter(self.filter_issue, issues) issues = sorted(issues, key=lambda i: i['modified'], reverse=True) return issues - def process_gerrit_issue(self, issue): + def process_gerrit_issue(self, instance, issue): ret = {} ret['review_url'] = issue['url'] + if 'shorturl' in instance: + ret['review_url'] = 'http://%s/%s' % (instance['shorturl'], + issue['number']) ret['header'] = issue['subject'] ret['owner'] = issue['owner']['email'] ret['author'] = ret['owner']