From e447411c4ead92ea2797e7a109ec6a0518a895db Mon Sep 17 00:00:00 2001 From: Aaron Gable Date: Fri, 20 Jan 2017 11:50:12 -0800 Subject: [PATCH] Remove unused FORCE_HTTPS_COMMIT_URL parameter from git-cl BUG= Change-Id: Ib8953a7fea4e3cd1c17ea277b5310a31821bfbe8 Reviewed-on: https://chromium-review.googlesource.com/431050 Reviewed-by: Andrii Shyshkalov Commit-Queue: Aaron Gable --- git_cl.py | 8 -------- tests/git_cl_test.py | 2 -- 2 files changed, 10 deletions(-) diff --git a/git_cl.py b/git_cl.py index b5e2fab262..f11cee849d 100755 --- a/git_cl.py +++ b/git_cl.py @@ -885,12 +885,6 @@ class Settings(object): self.project = self._GetRietveldConfig('project', error_ok=True) return self.project - def GetForceHttpsCommitUrl(self): - if not self.force_https_commit_url: - self.force_https_commit_url = self._GetRietveldConfig( - 'force-https-commit-url', error_ok=True) - return self.force_https_commit_url - def GetPendingRefPrefix(self): if not self.pending_ref_prefix: self.pending_ref_prefix = self._GetRietveldConfig( @@ -3282,8 +3276,6 @@ def LoadCodereviewSettingsFromFile(fileobj): SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True) SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True) SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True) - SetProperty('force-https-commit-url', 'FORCE_HTTPS_COMMIT_URL', - unset_error_ok=True) SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True) SetProperty('project', 'PROJECT', unset_error_ok=True) SetProperty('pending-ref-prefix', 'PENDING_REF_PREFIX', unset_error_ok=True) diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py index c440a416bd..3a0acc13ea 100755 --- a/tests/git_cl_test.py +++ b/tests/git_cl_test.py @@ -527,8 +527,6 @@ class TestGitCl(TestCase): ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1), ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1), ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1), - ((['git', 'config', '--unset-all', 'rietveld.force-https-commit-url'],), - CERR1), ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],), CERR1), ((['git', 'config', '--unset-all', 'rietveld.project'],), CERR1),