From e05d4882351e836e1b65ed5061adfbed69aa3923 Mon Sep 17 00:00:00 2001 From: Andrii Shyshkalov Date: Wed, 12 Apr 2017 14:34:49 +0200 Subject: [PATCH] git cl tests: improve readability of test helper. Shorten lines and remove useless stacktrace to make sure the actually usefull exception fits on tandrii@'s screen :) R=sergiyb@chromium.org Change-Id: I387da6c70f72a122d64f7a044d201d72a858fc3f Reviewed-on: https://chromium-review.googlesource.com/475811 Reviewed-by: Sergiy Byelozyorov Commit-Queue: Andrii Shyshkalov --- tests/git_cl_test.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py index 7b20a245c..1876087de 100755 --- a/tests/git_cl_test.py +++ b/tests/git_cl_test.py @@ -611,16 +611,13 @@ class TestGitCl(TestCase): raise # Sadly, has_failed() returns True if this OR any other tests before this # one have failed. - git_cl.logging.exception( - '\nIF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME!\n' + git_cl.logging.error( + '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n' 'There are un-consumed self.calls after this test has finished.\n' 'If you don\'t know which test this is, run:\n' ' tests/git_cl_tests.py -v\n' - '\n' - 'If you are already running just this single test, then **first** ' - 'fix the problem whose exception is emitted below by unittest ' - 'runner.\n' - '\n' + 'If you are already running only this test, then **first** fix the ' + 'problem whose exception is emitted below by unittest runner.\n' 'Else, to be sure what\'s going on, run this test **alone** with \n' ' tests/git_cl_tests.py TestGitCl.\n' 'and follow instructions above.\n' +