From de9c675a9be08c8daf547ccd404c3641610ada5d Mon Sep 17 00:00:00 2001 From: "phajdan.jr@chromium.org" Date: Fri, 27 Sep 2013 19:07:47 +0000 Subject: [PATCH] Always convert flag value to string in set_flag The callee needs it to be a string so that it can be made part of HTTP request. However, in code using Rietveld it's useful to use non-string types for flags where Rietveld actually doesn't return strings (say booleans). One example is the commit flag, which is a boolean. BUG=291335 Review URL: https://chromiumcodereview.appspot.com/24846002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@225748 0039d316-1c4b-4281-b951-d872f2087c98 --- rietveld.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rietveld.py b/rietveld.py index dc8404f08..7397b295b 100644 --- a/rietveld.py +++ b/rietveld.py @@ -257,7 +257,7 @@ class Rietveld(object): return self.post('/%d/edit_flags' % issue, [ ('last_patchset', str(patchset)), ('xsrf_token', self.xsrf_token()), - (flag, value)]) + (flag, str(value))]) def search( self,