From d44bc14aa6a174503b550b4f7ad2b9c394878dcb Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Wed, 15 May 2024 16:53:48 +0000 Subject: [PATCH] split_cl: do not prepend '/' in $directory I think it is readable if '/' is not prepended for the CL title like ``` $directory: apply some change ``` e.g. https://crrev.com/c/5541194/1..3//COMMIT_MSG#b7 Change-Id: If4cbb4966ebf62f99a7078028e4cb104de4b7197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540834 Auto-Submit: Takuto Ikuta Reviewed-by: Gavin Mak Commit-Queue: Gavin Mak --- split_cl.py | 2 +- tests/split_cl_test.py | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/split_cl.py b/split_cl.py index b263915aa..b452c5038 100644 --- a/split_cl.py +++ b/split_cl.py @@ -64,7 +64,7 @@ def FormatDirectoriesForPrinting(directories, prefix=None): def FormatDescriptionOrComment(txt, directories): """Replaces $directory with |directories| in |txt|.""" - to_insert = FormatDirectoriesForPrinting(directories, prefix='/') + to_insert = FormatDirectoriesForPrinting(directories) return txt.replace('$directory', to_insert) diff --git a/tests/split_cl_test.py b/tests/split_cl_test.py index 574ce5a7d..f81391b15 100755 --- a/tests/split_cl_test.py +++ b/tests/split_cl_test.py @@ -38,12 +38,14 @@ class SplitClTest(unittest.TestCase): # One directory self.assertEqual( split_cl.FormatDescriptionOrComment(description, ["foo"]), - "Converted use of X to Y in /foo.") + "Converted use of X to Y in foo.", + ) # Many directories self.assertEqual( split_cl.FormatDescriptionOrComment(description, ["foo", "bar"]), - "Converted use of X to Y in ['/foo', '/bar'].") + "Converted use of X to Y in ['foo', 'bar'].", + ) def GetDirectoryBaseName(self, file_path): return os.path.basename(os.path.dirname(file_path))