Ignore C++ comments while checking for Singleton<T> in headers.

(without ignoring comments this check gives false positives on code like base/threading/thread_local.h)
Review URL: http://codereview.chromium.org/7747023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98421 0039d316-1c4b-4281-b951-d872f2087c98

presubmit_canned_checks.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2010 The Chromium Authors. All rights reserved.
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
@@ -828,14 +828,17 @@ def _CheckConstNSObject(input_api, output_api, source_file_filter):
 
 def _CheckSingletonInHeaders(input_api, output_api, source_file_filter):
   """Checks to make sure no header files have |Singleton<|."""
-  pattern = input_api.re.compile(r'Singleton<')
+  pattern = input_api.re.compile(r'Singleton\s*<')
   files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     if (f.LocalPath().endswith('.h') or f.LocalPath().endswith('.hxx') or
         f.LocalPath().endswith('.hpp') or f.LocalPath().endswith('.inl')):
       contents = input_api.ReadFile(f)
-      if pattern.search(contents):
+      for line in contents.splitlines(False):
-        files.append(f)
+        line = input_api.re.sub(r'//.*$', '', line)  # Strip C++ comment.
+        if pattern.search(line):
+          files.append(f)
+          break
 
   if files:
     return [ output_api.PresubmitError(