From cf0877805e358d9cd401fd8f2d3da123d157e1e1 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Tue, 23 Jul 2013 13:08:48 +0000 Subject: [PATCH] Simplify code; no need to pass issue arg to GetApprovingReviewers(). The class already knows the issue number. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/19976002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@213083 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/git_cl.py b/git_cl.py index bb07ee081..c1ae3f7f1 100755 --- a/git_cl.py +++ b/git_cl.py @@ -683,9 +683,9 @@ or verify this branch is set up to track another (via the --track argument to return self.RpcServer().get( '/download/issue%s_%s.diff' % (issue, patchset)) - def GetApprovingReviewers(self, issue): + def GetApprovingReviewers(self): return get_approving_reviewers( - self.RpcServer().get_issue_properties(int(issue), True)) + self.RpcServer().get_issue_properties(self.GetIssue(), True)) def SetIssue(self, issue): """Set this branch's issue. If issue=0, clears the issue.""" @@ -1577,7 +1577,7 @@ def SendUpstream(parser, args, cmd): # the commit viewvc url. # Keep a separate copy for the commit message. if cl.GetIssue(): - change_desc.update_reviewers(cl.GetApprovingReviewers(cl.GetIssue())) + change_desc.update_reviewers(cl.GetApprovingReviewers()) commit_desc = ChangeDescription(change_desc.description) if cl.GetIssue():