Check format of OWNERS files in PRESUBMIT and PanProjectChecks.

Bug: 789773
Change-Id: Iaa721c9971d1834dd796a9cd28a28a83b6482e05
Reviewed-on: https://chromium-review.googlesource.com/1019975
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
changes/75/1019975/2
Edward Lesmes 7 years ago committed by Commit Bot
parent 94580ab035
commit cb62e48b54

@ -56,6 +56,8 @@ def DepotToolsPylint(input_api, output_api):
def CommonChecks(input_api, output_api, tests_to_black_list): def CommonChecks(input_api, output_api, tests_to_black_list):
results = [] results = []
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
results.extend(input_api.canned_checks.CheckOwnersFormat(
input_api, output_api))
# TODO(maruel): Make sure at least one file is modified first. # TODO(maruel): Make sure at least one file is modified first.
# TODO(maruel): If only tests are modified, only run them. # TODO(maruel): If only tests are modified, only run them.
tests = DepotToolsPylint(input_api, output_api) tests = DepotToolsPylint(input_api, output_api)

@ -1013,6 +1013,10 @@ def PanProjectChecks(input_api, output_api,
print " %s took a long time: %dms" % (snapshot_memory[1], delta_ms) print " %s took a long time: %dms" % (snapshot_memory[1], delta_ms)
snapshot_memory[:] = (dt2, msg) snapshot_memory[:] = (dt2, msg)
snapshot("checking owners files format")
results.extend(input_api.canned_checks.CheckOwnersFormat(
input_api, output_api))
if owners_check: if owners_check:
snapshot("checking owners") snapshot("checking owners")
results.extend(input_api.canned_checks.CheckOwners( results.extend(input_api.canned_checks.CheckOwners(

Loading…
Cancel
Save