From b508ecd932fd2653b4d3e9bccd80b3b7ac98c36a Mon Sep 17 00:00:00 2001 From: Edward Lesmes Date: Mon, 7 Jun 2021 21:27:15 +0000 Subject: [PATCH] bot_update: Initialize synced_solutions before syncing. If sync fails, synced_solutions is not initialized, resulting in a use-before-init error. Bug: 1217352 Change-Id: I2367d0f8030faa571b5c2743d5d97aa4c0329a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2945663 Reviewed-by: Ben Pastene Commit-Queue: Edward Lesmes --- recipes/recipe_modules/bot_update/resources/bot_update.py | 1 + 1 file changed, 1 insertion(+) diff --git a/recipes/recipe_modules/bot_update/resources/bot_update.py b/recipes/recipe_modules/bot_update/resources/bot_update.py index 849680189..94e27f741 100755 --- a/recipes/recipe_modules/bot_update/resources/bot_update.py +++ b/recipes/recipe_modules/bot_update/resources/bot_update.py @@ -1064,6 +1064,7 @@ def checkout(options, git_slns, specs, revisions, step_text): pass should_delete_dirty_file = False + synced_solutions = [] experiments = [] if options.experiments: experiments = options.experiments.split(',')