Strip Windows line endings when checking licenses
The CheckLicense presubmit is supposed to check for correct licenses, not for correct line endings. By reading the input file in binary mode it implictly does both, leading to confusing error messages. This is exacerbated by bugs in the line ending checks which are being addressed separately. This change will avoid false positives on files that have Windows line endings. Change-Id: I2ff8632f273ec4896cb4918c386e0d1c12e72935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910486 Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>changes/86/2910486/2
parent
da8a67b497
commit
b0bfaf1b3d
Loading…
Reference in New Issue