From af3a9993dec43f7d0304e191723f6e78ff38e0c8 Mon Sep 17 00:00:00 2001 From: Andrii Shyshkalov Date: Thu, 9 Feb 2017 14:18:01 +0100 Subject: [PATCH] git cl: add temporary workaround for u200 chars in PolyGerrit. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit (edited, so that next next line gets u200 char between R= and reviewer email) R=​​mstarzinger@chromium.org TBR=agable@chromium.org BUG=b/34702620 (internal) Change-Id: I58f2528dd28e3a43d8eb2d7d4f5c046460d8a9ee Reviewed-on: https://chromium-review.googlesource.com/440085 Commit-Queue: Andrii Shyshkalov Reviewed-by: Andrii Shyshkalov --- git_cl.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/git_cl.py b/git_cl.py index 320095282..8bf9ff2b9 100755 --- a/git_cl.py +++ b/git_cl.py @@ -2799,7 +2799,12 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): reviewers = change_desc.get_reviewers() if reviewers: - refspec_opts.extend('r=' + email.strip() for email in reviewers) + # TODO(tandrii): remove this horrible hack once (Poly)Gerrit fixes their + # side for real (b/34702620). + def clean_invisible_chars(email): + return email.decode('unicode_escape').encode('ascii', 'ignore') + refspec_opts.extend('r=' + clean_invisible_chars(email).strip() + for email in reviewers) if options.private: refspec_opts.append('draft')