From aed892eb628f5c6f03217c634c1ef3c50d42d79f Mon Sep 17 00:00:00 2001 From: "danakj@chromium.org" Date: Fri, 12 Apr 2013 23:39:10 +0000 Subject: [PATCH] Teach cpplint include-what-you-use about chromium hash_set and hash_map. For hash_map and hash_set, we should include "base/hashtables.h", not the or standard headers. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14139002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@194047 0039d316-1c4b-4281-b951-d872f2087c98 --- presubmit_canned_checks.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index e4ce0418c..62471fc83 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -114,6 +114,14 @@ def CheckChangeLintsClean(input_api, output_api, source_file_filter=None): '-readability/casting,-runtime/int,-runtime/virtual,' '-whitespace/braces') + # Replace and as headers that need to be included + # with "base/hash_tables.h" instead. + cpplint._re_pattern_templates = [ + (a, b, 'base/hash_tables.h') + if header in ('', '') else (a, b, header) + for (a, b, header) in cpplint._re_pattern_templates + ] + # We currently are more strict with normal code than unit tests; 4 and 5 are # the verbosity level that would normally be passed to cpplint.py through # --verbose=#. Hopefully, in the future, we can be more verbose.