Revert "Generate patchset name from commit subject"

This reverts commit 947f2ee808.

Reason for revert: unnecessarily sets the title for the first upload,
which isn't done for Rietveld.

Original change's description:
> Generate patchset name from commit subject
> 
> BUG=672332
> 
> Change-Id: If9c662f11b217a52cac7c9c47ad9f3d978148c2e
> Reviewed-on: https://chromium-review.googlesource.com/419330
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> 

TBR=agable@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
BUG=672332
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I9dcec1b02c8f16ceca8338acef4a1fc174aef35c
Reviewed-on: https://chromium-review.googlesource.com/419517
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

git_cl.py

@@ -2934,20 +2934,16 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):
       print('Adding self-LGTM (Code-Review +1) because of TBRs')
       refspec_opts.append('l=Code-Review+1')
 
-    title = options.title
-    if not title:
-      default = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
-      title = ask_for_data('Title for patchset [%s]: ' % default) or default
-    if title:
-      if not re.match(r'^[\w ]+$', title):
-        title = re.sub(r'[^\w ]', '', title)
+    if options.title:
+      if not re.match(r'^[\w ]+$', options.title):
+        options.title = re.sub(r'[^\w ]', '', options.title)
         print('WARNING: Patchset title may only contain alphanumeric chars '
-              'and spaces. Cleaned up title:\n%s' % title)
+              'and spaces. Cleaned up title:\n%s' % options.title)
         if not options.force:
           ask_for_data('Press enter to continue, Ctrl+C to abort')
       # Per doc, spaces must be converted to underscores, and Gerrit will do the
       # reverse on its side.
-      refspec_opts.append('m=' + title.replace(' ', '_'))
+      refspec_opts.append('m=' + options.title.replace(' ', '_'))
 
     if options.send_mail:
       if not change_desc.get_reviewers():

tests/git_cl_test.py

@@ -1338,7 +1338,7 @@ class TestGitCl(TestCase):
   def _gerrit_upload_calls(cls, description, reviewers, squash,
                            squash_mode='default',
                            expected_upstream_ref='origin/refs/heads/master',
-                           ref_suffix='', title=None, notify=False,
+                           ref_suffix='', notify=False,
                            post_amend_description=None, issue=None, cc=None):
     if post_amend_description is None:
       post_amend_description = description
@@ -1409,18 +1409,6 @@ class TestGitCl(TestCase):
             expected_upstream_ref + '..' + ref_to_push],), ''),
         ]
 
-
-    if not title:
-      calls += [
-          ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
-          (('Title for patchset []: ',), ''),
-      ]
-    else:
-      if ref_suffix:
-        ref_suffix += ',m=' + title
-      else:
-        ref_suffix = '%m=' + title
-
     notify_suffix = 'notify=%s' % ('ALL' if notify else 'NONE')
     if ref_suffix:
       ref_suffix += ',' + notify_suffix
@@ -1474,7 +1462,6 @@ class TestGitCl(TestCase):
       squash_mode=None,
       expected_upstream_ref='origin/refs/heads/master',
       ref_suffix='',
-      title=None,
       notify=False,
       post_amend_description=None,
       issue=None,
@@ -1507,7 +1494,7 @@ class TestGitCl(TestCase):
         description, reviewers, squash,
         squash_mode=squash_mode,
         expected_upstream_ref=expected_upstream_ref,
-        ref_suffix=ref_suffix, title=title, notify=notify,
+        ref_suffix=ref_suffix, notify=notify,
         post_amend_description=post_amend_description,
         issue=issue, cc=cc)
     # Uncomment when debugging.
@@ -1547,7 +1534,7 @@ class TestGitCl(TestCase):
         'desc\n\nBUG=\n\nChange-Id: I123456789',
         squash=False,
         squash_mode='override_nosquash',
-        title='Dont_put_bad_chars')
+        ref_suffix='%m=Dont_put_bad_chars')
     self.assertIn(
         'WARNING: Patchset title may only contain alphanumeric chars '
         'and spaces. Cleaned up title:\nDont put bad chars\n',