From a287393e19445917b7aba310f260d824b85f9d40 Mon Sep 17 00:00:00 2001 From: "robertshield@chromium.org" Date: Wed, 20 Feb 2013 18:08:46 +0000 Subject: [PATCH] Fix PyLint presbumit check on win. We were passing a unicode string in the env block to subprocess.Popen which makes it unhappy. This forces the string to ascii first. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/12255083 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@183569 0039d316-1c4b-4281-b951-d872f2087c98 --- presubmit_canned_checks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 995aa4550..480ecd2b9 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -677,7 +677,7 @@ def RunPylint(input_api, output_api, white_list=None, black_list=None, env = input_api.environ.copy() import sys env['PYTHONPATH'] = input_api.os_path.pathsep.join( - extra_paths_list + sys.path) + extra_paths_list + sys.path).encode('utf8') def run_lint(files): # We can't import pylint directly due to licensing issues, so we run