From 9ccad5689c0975f3995e89558c64fb66e8a572bf Mon Sep 17 00:00:00 2001 From: John Budorick Date: Wed, 18 Apr 2018 09:08:13 -0700 Subject: [PATCH] bot_update: Ensure create_manifest ignores repos with explicit None urls. Bug: 830306 Change-Id: Id87a6f2053c7e3cd489647d1cbbc8a83f2e585db Reviewed-on: https://chromium-review.googlesource.com/1003326 Reviewed-by: Aaron Gable Commit-Queue: John Budorick --- recipes/recipe_modules/bot_update/resources/bot_update.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/recipes/recipe_modules/bot_update/resources/bot_update.py b/recipes/recipe_modules/bot_update/resources/bot_update.py index 7e3de71fa..b3c8241d7 100755 --- a/recipes/recipe_modules/bot_update/resources/bot_update.py +++ b/recipes/recipe_modules/bot_update/resources/bot_update.py @@ -452,7 +452,9 @@ def create_manifest(gclient_output, patch_root, gerrit_ref): revision = info.get('revision', '') # The format of the url is "https://repo.url/blah.git@abcdefabcdef" or # just "https://repo.url/blah.git" - url_split = info.get('url', '').split('@') + url_split = info.get('url') + if url_split is not None: + url_split = url_split.split('@') if not revision and len(url_split) == 2: revision = url_split[1] if url_split: