From 9b4a0570e51dd3ba8d419518b1a5537da40bb893 Mon Sep 17 00:00:00 2001 From: Bruce Dawson Date: Wed, 6 May 2020 17:05:01 +0000 Subject: [PATCH] Print clarifying message when no new owners needed If a CL already has owners on the reviewer list that cover all of the files - regardless of whether they have approved the change - git cl owners just prints ** You selected these owners **, which can be confusing. This change adds an explanation in the no-unowned-files case and suggests using --ignore-current if more reviewers are wanted. Bug: 1071967 Change-Id: If60455c5ec15006e09feed39633fa62e3ddf0a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2183222 Reviewed-by: Edward Lesmes Commit-Queue: Bruce Dawson --- owners_finder.py | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/owners_finder.py b/owners_finder.py index d70db7180..e421b763e 100644 --- a/owners_finder.py +++ b/owners_finder.py @@ -334,14 +334,19 @@ class OwnersFinder(object): # Print results self.writeln() self.writeln() - self.writeln('** You selected these owners **') - self.writeln() - for owner in self.selected_owners: - self.writeln(self.bold_name(owner) + ':') - self.indent() - for file_name in sorted(self.owners_to_files[owner]): - self.writeln(file_name) - self.unindent() + if len(self.selected_owners) == 0: + self.writeln('This change list already has owner-reviewers for all ' + 'files.') + self.writeln('Use --ignore-current if you want to ignore them.') + else: + self.writeln('** You selected these owners **') + self.writeln() + for owner in self.selected_owners: + self.writeln(self.bold_name(owner) + ':') + self.indent() + for file_name in sorted(self.owners_to_files[owner]): + self.writeln(file_name) + self.unindent() def bold(self, text): return self.COLOR_BOLD + text + self.COLOR_RESET