Revert 77913 - Regression: Editor Linux Fix for gcl.

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

TBR=mhm@chromium.org
Review URL: http://codereview.chromium.org/6684022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77928 0039d316-1c4b-4281-b951-d872f2087c98
experimental/szager/collated-output
jam@chromium.org 14 years ago
parent 37248c0bba
commit 93efa03156

@ -1063,9 +1063,10 @@ def CMDchange(args):
os.write(handle, text)
os.close(handle)
result = None
try:
if not silent:
subprocess.check_call(['env', GetEditor(), filename])
subprocess.check_call(['env', GetEditor(), filename], shell=True)
result = gclient_utils.FileRead(filename, 'r')
finally:
os.remove(filename)

@ -710,8 +710,9 @@ def UserEditedLog(starting_text):
fileobj.write(starting_text)
fileobj.close()
result = None
try:
subprocess.check_call(['env', editor, filename])
subprocess.check_call(['env', editor, filename], shell=True)
fileobj = open(filename)
result = fileobj.read()
fileobj.close()

Loading…
Cancel
Save