aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cipd: link directly to created package on chrome-infra-packages.

Browse Source 
I've been using this recipe module for a new internal builder
(http://shortn/_wvjqgrpIGb) and it seems odd to have the package
name and instance ID in the step text rather than a link directly
to the site. (Perhaps the module predates the CIPD UI rewrite?)

Recipe-Nontrivial-Roll: infra
Change-Id: Iab6080c3c6110ac2205cb3de397055b30d881d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1496953
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
changes/53/1496953/3
John Budorick 6 years ago committed by Commit Bot
parent 920bada95c
commit 8b94108e68
6 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File

4
recipes/recipe_modules/cipd/api.py
Unescape Escape View File

@ -302,8 +302,8 @@ class CIPDApi(recipe_api.RecipeApi):
'result': self.test_api.make_pin(pkg_name),
}))
ret_data = result.json.output['result']
result.presentation.step_text = '</br>pkg: %(package)s' % ret_data
result.presentation.step_text += '</br>id: %(instance_id)s' % ret_data
result.presentation.links[ret_data['instance_id']] = (
'https://chrome-infra-packages.appspot.com/p/%(package)s/+/%(instance_id)s' % ret_data)
return ret_data
def create_from_yaml(self, pkg_def, refs=None, tags=None):

4
recipes/recipe_modules/cipd/examples/full.expected/basic.json
Unescape Escape View File

@ -302,14 +302,14 @@
],
"name": "create fake-package.yaml",
"~followup_annotations": [
"@@@STEP_TEXT@</br>pkg: fake-package.yaml</br>id: 40-chars-fake-of-the-package-instance_id@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"result\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"package\": \"fake-package.yaml\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LINK@40-chars-fake-of-the-package-instance_id@https://chrome-infra-packages.appspot.com/p/fake-package.yaml/+/40-chars-fake-of-the-package-instance_id@@@"
]
},
{

4
recipes/recipe_modules/cipd/examples/full.expected/basic_pkg.json
Unescape Escape View File

@ -302,14 +302,14 @@
],
"name": "create infra/fake-package",
"~followup_annotations": [
"@@@STEP_TEXT@</br>pkg: infra/fake-package</br>id: 40-chars-fake-of-the-package-instance_id@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"result\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"package\": \"infra/fake-package\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LINK@40-chars-fake-of-the-package-instance_id@https://chrome-infra-packages.appspot.com/p/infra/fake-package/+/40-chars-fake-of-the-package-instance_id@@@"
]
},
{

4
recipes/recipe_modules/cipd/examples/full.expected/describe-many-instances.json
Unescape Escape View File

@ -302,14 +302,14 @@
],
"name": "create fake-package.yaml",
"~followup_annotations": [
"@@@STEP_TEXT@</br>pkg: fake-package.yaml</br>id: 40-chars-fake-of-the-package-instance_id@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"result\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"package\": \"fake-package.yaml\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LINK@40-chars-fake-of-the-package-instance_id@https://chrome-infra-packages.appspot.com/p/fake-package.yaml/+/40-chars-fake-of-the-package-instance_id@@@"
]
},
{

4
recipes/recipe_modules/cipd/examples/full.expected/mac64.json
Unescape Escape View File

@ -302,14 +302,14 @@
],
"name": "create fake-package.yaml",
"~followup_annotations": [
"@@@STEP_TEXT@</br>pkg: fake-package.yaml</br>id: 40-chars-fake-of-the-package-instance_id@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"result\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"package\": \"fake-package.yaml\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LINK@40-chars-fake-of-the-package-instance_id@https://chrome-infra-packages.appspot.com/p/fake-package.yaml/+/40-chars-fake-of-the-package-instance_id@@@"
]
},
{

4
recipes/recipe_modules/cipd/examples/full.expected/win64.json
Unescape Escape View File

@ -302,14 +302,14 @@
],
"name": "create fake-package.yaml",
"~followup_annotations": [
"@@@STEP_TEXT@</br>pkg: fake-package.yaml</br>id: 40-chars-fake-of-the-package-instance_id@@@",
"@@@STEP_LOG_LINE@json.output@{@@@",
"@@@STEP_LOG_LINE@json.output@ \"result\": {@@@",
"@@@STEP_LOG_LINE@json.output@ \"instance_id\": \"40-chars-fake-of-the-package-instance_id\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"package\": \"fake-package.yaml\"@@@",
"@@@STEP_LOG_LINE@json.output@ }@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@"
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LINK@40-chars-fake-of-the-package-instance_id@https://chrome-infra-packages.appspot.com/p/fake-package.yaml/+/40-chars-fake-of-the-package-instance_id@@@"
]
},
{

Write Preview
Loading…
Cancel
Save