From 893982033ec1c9861f0c906394402689e02b3c44 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Thu, 6 Sep 2012 07:37:10 +0000 Subject: [PATCH] Change Rietveld.add_comment() to not add the user as a reviewer by default This is mainly to reduce the spam that the commit queue adds to commit-bot@chromium.org as all follow up emails on code reviews are sent to it because it was adding itself as a reviewer, even if it is not. R=rogerta@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/10918075 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@155141 0039d316-1c4b-4281-b951-d872f2087c98 --- rietveld.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rietveld.py b/rietveld.py index 88f024b6c..94f7c6f52 100644 --- a/rietveld.py +++ b/rietveld.py @@ -226,7 +226,7 @@ class Rietveld(object): ('description', description), ('xsrf_token', self.xsrf_token())]) - def add_comment(self, issue, message): + def add_comment(self, issue, message, add_as_reviewer=False): max_message = 10000 tail = '…\n(message too large)' if len(message) > max_message: @@ -236,6 +236,7 @@ class Rietveld(object): ('xsrf_token', self.xsrf_token()), ('message', message), ('message_only', 'True'), + ('add_as_reviewer', str(bool(add_as_reviewer))), ('send_mail', 'True'), ('no_redirect', 'True')])