From 85c2a198335da5d3f3f28cde84e41495cf775375 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Thu, 22 Jul 2010 21:14:43 +0000 Subject: [PATCH] Add comments to clarify the purpose of some member variables. NO CODE CHANGE. TBR=bradnelson Review URL: http://codereview.chromium.org/3014027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@53382 0039d316-1c4b-4281-b951-d872f2087c98 --- gclient.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gclient.py b/gclient.py index d62e77ee5..7cd2c01d3 100644 --- a/gclient.py +++ b/gclient.py @@ -154,7 +154,12 @@ class Dependency(GClientKeywords): # A cache of the files affected by the current operation, necessary for # hooks. self.file_list = [] + # If it is not set to True, the dependency wasn't processed for its child + # dependency, i.e. its DEPS wasn't read. self.deps_parsed = False + # A direct reference is dependency that is referenced by a deps, deps_os or + # solution. A indirect one is one that was loaded with From() or that + # exceeded recursion limit. self.direct_reference = False # Sanity checks @@ -291,6 +296,8 @@ class Dependency(GClientKeywords): if name in [s.name for s in self.dependencies]: raise self.dependencies.append(Dependency(self, name, url)) + # Note: do not sort by name, the dependencies must be specified in the + # logical order. logging.info('Loaded: %s' % str(self)) def RunCommandRecursively(self, options, revision_overrides,