diff --git a/gcl.py b/gcl.py index 1d96e74bc..60b842764 100755 --- a/gcl.py +++ b/gcl.py @@ -770,6 +770,9 @@ def UploadCL(change_info, args): subject = subject + "..." upload_arg.append("--message=" + subject) + if GetCodeReviewSetting("PRIVATE") == "True": + upload_arg.append("--private") + # Change the current working directory before calling upload.py so that it # shows the correct base. previous_cwd = os.getcwd() diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py index a08596623..67248a5a8 100755 --- a/tests/gcl_unittest.py +++ b/tests/gcl_unittest.py @@ -279,6 +279,7 @@ class UploadCLUnittest(GclTestsBase): gcl.os.write(42, change_info.description) gcl.os.close(42) gcl.GetCodeReviewSetting('CC_LIST') + gcl.GetCodeReviewSetting('PRIVATE') gcl.os.getcwd().AndReturn('somewhere') gcl.os.chdir(change_info.GetLocalRoot()) gcl.GenerateDiff(change_info.GetFileNames()) @@ -305,6 +306,7 @@ class UploadCLUnittest(GclTestsBase): gcl.os.write(42, change_info.description) gcl.os.close(42) gcl.GetCodeReviewSetting('CC_LIST') + gcl.GetCodeReviewSetting('PRIVATE') gcl.os.getcwd().AndReturn('somewhere') gcl.os.chdir(change_info.GetLocalRoot()) gcl.GenerateDiff(change_info.GetFileNames()) @@ -331,6 +333,7 @@ class UploadCLUnittest(GclTestsBase): gcl.os.write(42, change_info.description) gcl.os.close(42) gcl.GetCodeReviewSetting('CC_LIST') + gcl.GetCodeReviewSetting('PRIVATE') gcl.os.getcwd().AndReturn('somewhere') gcl.os.chdir(change_info.GetLocalRoot()) gcl.GenerateDiff(change_info.GetFileNames())