diff --git a/pylintrc-2.17 b/pylintrc-2.17 index 2341a591d..30b526b56 100644 --- a/pylintrc-2.17 +++ b/pylintrc-2.17 @@ -1,3 +1,5 @@ +# Default config file for our pylint-2.17 wrapper. + [MAIN] # Analyse import fallback blocks. This can be used to support both Python 2 and diff --git a/pylintrc b/pylintrc-2.6 similarity index 99% rename from pylintrc rename to pylintrc-2.6 index d46658a96..71028181d 100644 --- a/pylintrc +++ b/pylintrc-2.6 @@ -1,3 +1,5 @@ +# Default config file for our pylint-2.6 wrapper. + [MASTER] # Specify a configuration file. diff --git a/pylintrc-2.7 b/pylintrc-2.7 new file mode 100644 index 000000000..35c8c88cd --- /dev/null +++ b/pylintrc-2.7 @@ -0,0 +1,352 @@ +# Default config file for our pylint-2.7 wrapper. + +[MASTER] + +# Specify a configuration file. +#rcfile= + +# Python code to execute, usually for sys.path manipulation such as +# pygtk.require(). +#init-hook= + +# Add files or directories to the blocklist. They should be base names, not +# paths. +ignore=CVS + +# Pickle collected data for later comparisons. +persistent=yes + +# List of plugins (as comma separated values of python modules names) to load, +# usually to register additional checkers. +load-plugins= + pylint_quotes + + +# Configure quote preferences. +string-quote = single-avoid-escape +triple-quote = double +docstring-quote = double + + +[MESSAGES CONTROL] + +# Enable the message, report, category or checker with the given id(s). You can +# either give multiple identifier separated by comma (,) or put this option +# multiple time. +#enable= + +# Disable the message, report, category or checker with the given id(s). You +# can either give multiple identifier separated by comma (,) or put this option +# multiple time (only on the command line, not in the configuration file where +# it should appear only once). +# +# These should get enabled, but the codebase has too many violations currently: +# bad-continuation +# anomalous-backslash-in-string +# bad-context-manager +# bad-indentation +# bad-str-strip-call +# bad-whitespace +# cell-var-from-loop +# deprecated-lambda +# eval-used +# function-redefined +# import-error +# locally-enabled +# missing-final-newline +# no-init +# no-name-in-module +# no-self-use +# not-callable +# old-style-class +# protected-access +# superfluous-parens +# super-on-old-class +# too-many-function-args +# trailing-whitespace +# unnecessary-semicolon +# unpacking-non-sequence +# unused-import +# useless-else-on-loop +# +# CHANGED: +disable= + invalid-name, + missing-docstring, + too-many-lines, + bad-inline-option, + locally-disabled, + duplicate-code, + too-many-ancestors, + too-many-instance-attributes, + too-few-public-methods, + too-many-public-methods, + too-many-return-statements, + too-many-branches, + too-many-arguments, + too-many-locals, + too-many-statements, + abstract-class-not-used, + abstract-class-little-used, + exec-used, + bad-builtin, + star-args, + deprecated-module, + reimported, + fixme, + global-statement, + broad-except, + logging-not-lazy, + bad-continuation, + anomalous-backslash-in-string, + assigning-non-slot, + bad-context-manager, + bad-indentation, + bad-str-strip-call, + bad-super-call, + bad-whitespace, + cell-var-from-loop, + consider-using-enumerate, + deprecated-lambda, + deprecated-method, + eval-used, + function-redefined, + import-error, + invalid-docstring-quote, + invalid-string-quote, + invalid-triple-quote, + locally-enabled, + line-too-long, + misplaced-comparison-constant, + misplaced-bare-raise, + missing-final-newline, + multiple-imports, + no-init, + no-name-in-module, + no-self-argument, + no-self-use, + not-an-iterable, + not-callable, + old-style-class, + protected-access, + redefined-variable-type, + simplifiable-if-statement, + singleton-comparison, + superfluous-parens, + super-on-old-class, + too-many-boolean-expressions, + too-many-function-args, + too-many-nested-blocks, + trailing-whitespace, + undefined-variable, + ungrouped-imports, + unnecessary-semicolon, + unneeded-not, + unpacking-non-sequence, + unsubscriptable-object, + unsupported-membership-test, + unused-import, + useless-else-on-loop, + using-constant-test, + wrong-import-order, + wrong-import-position, + + +[REPORTS] + +# Set the output format. Available formats are text, parseable, colorized, msvs +# (visual studio) and html +output-format=text + +# Put messages in a separate file for each module / package specified on the +# command line instead of printing them on stdout. Reports (if any) will be +# written in a file name "pylint_global.[txt|html]". +files-output=no + +# Tells whether to display a full report or only the messages +# CHANGED: +reports=no + +# Activate the evaluation score. +score=no + +# Python expression which should return a note less than 10 (10 is the highest +# note). You have access to the variables errors warning, statement which +# respectively contain the number of errors / warnings messages and the total +# number of statements analyzed. This is used by the global evaluation report +# (RP0004). +evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) + + +[VARIABLES] + +# Tells whether we should check for unused import in __init__ files. +init-import=no + +# A regular expression matching the beginning of the name of dummy variables +# (i.e. not used). +dummy-variables-rgx=_|dummy + +# List of additional names supposed to be defined in builtins. Remember that +# you should avoid to define new builtins when possible. +additional-builtins= + + +[TYPECHECK] + +# Tells whether missing members accessed in mixin class should be ignored. A +# mixin class is detected if its name ends with "mixin" (case insensitive). +ignore-mixin-members=yes + +# List of classes names for which member attributes should not be checked +# (useful for classes with attributes dynamically set). +ignored-classes=SQLObject,twisted.internet.reactor,hashlib,google.appengine.api.memcache + +# List of members which are set dynamically and missed by pylint inference +# system, and so shouldn't trigger E0201 when accessed. Python regular +# expressions are accepted. +generated-members=REQUEST,acl_users,aq_parent,multiprocessing.managers.SyncManager + + +[MISCELLANEOUS] + +# List of note tags to take in consideration, separated by a comma. +notes=FIXME,XXX,TODO + + +[SIMILARITIES] + +# Minimum lines number of a similarity. +min-similarity-lines=4 + +# Ignore comments when computing similarities. +ignore-comments=yes + +# Ignore docstrings when computing similarities. +ignore-docstrings=yes + + +[FORMAT] + +# Maximum number of characters on a single line. +max-line-length=80 + +# Maximum number of lines in a module +max-module-lines=1000 + +# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 +# tab). +# CHANGED: +indent-string=' ' + + +[BASIC] + +# List of builtins function names that should not be used, separated by a comma +bad-functions=map,filter,apply,input + +# Regular expression which should only match correct module names +module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ + +# Regular expression which should only match correct module level names +const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ + +# Regular expression which should only match correct class names +class-rgx=[A-Z_][a-zA-Z0-9]+$ + +# Regular expression which should only match correct function names +function-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct method names +method-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct instance attribute names +attr-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct argument names +argument-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct variable names +variable-rgx=[a-z_][a-z0-9_]{2,30}$ + +# Regular expression which should only match correct list comprehension / +# generator expression variable names +inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ + +# Good variable names which should always be accepted, separated by a comma +good-names=i,j,k,ex,Run,_ + +# Bad variable names which should always be refused, separated by a comma +bad-names=foo,bar,baz,toto,tutu,tata + +# Regular expression which should only match functions or classes name which do +# not require a docstring +no-docstring-rgx=__.*__ + + +[DESIGN] + +# Maximum number of arguments for function / method +max-args=5 + +# Argument names that match this expression will be ignored. Default to name +# with leading underscore +ignored-argument-names=_.* + +# Maximum number of locals for function / method body +max-locals=15 + +# Maximum number of return / yield for function / method body +max-returns=6 + +# Maximum number of branch for function / method body +max-branchs=12 + +# Maximum number of statements in function / method body +max-statements=50 + +# Maximum number of parents for a class (see R0901). +max-parents=7 + +# Maximum number of attributes for a class (see R0902). +max-attributes=7 + +# Minimum number of public methods for a class (see R0903). +min-public-methods=2 + +# Maximum number of public methods for a class (see R0904). +max-public-methods=20 + + +[CLASSES] + +# List of method names used to declare (i.e. assign) instance attributes. +defining-attr-methods=__init__,__new__,setUp + +# List of valid names for the first argument in a class method. +valid-classmethod-first-arg=cls + + +[IMPORTS] + +# Deprecated modules which should not be used, separated by a comma +deprecated-modules=regsub,string,TERMIOS,Bastion,rexec + +# Create a graph of every (i.e. internal and external) dependencies in the +# given file (report RP0402 must not be disabled) +import-graph= + +# Create a graph of external dependencies in the given file (report RP0402 must +# not be disabled) +ext-import-graph= + +# Create a graph of internal dependencies in the given file (report RP0402 must +# not be disabled) +int-import-graph= + + +[EXCEPTIONS] + +# Exceptions that will emit a warning when being caught. Defaults to +# "Exception" +overgeneral-exceptions=Exception diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index 96b27f73c..9694b0c8d 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -2890,7 +2890,7 @@ the current line as well! presubmit.sigint_handler.wait.return_value = (b'', None) pylint = os.path.join(_ROOT, 'pylint-2.7') - pylintrc = os.path.join(_ROOT, 'pylintrc') + pylintrc = os.path.join(_ROOT, 'pylintrc-2.7') env = {str('PYTHONPATH'): str('')} if sys.platform == 'win32': pylint += '.bat'