Use check_call(), not check_output()

There is user interaction when the svn credential isn't cached. (Duh)

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7864007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100462 0039d316-1c4b-4281-b951-d872f2087c98
experimental/szager/collated-output
maruel@chromium.org 14 years ago
parent 87e6d33103
commit 6a05169568

@ -401,10 +401,9 @@ def _SendChangeSVN(options):
if scm.SVN.AssertVersion("1.5")[0]: if scm.SVN.AssertVersion("1.5")[0]:
command.append('--no-ignore') command.append('--no-ignore')
subprocess2.check_output( subprocess2.check_call(command)
command, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT)
except subprocess2.CalledProcessError, e: except subprocess2.CalledProcessError, e:
raise NoTryServerAccess(' '.join(e.cmd) + '\nOuput:\n' + e.stdout) raise NoTryServerAccess(str(e))
finally: finally:
temp_file.close() temp_file.close()
shutil.rmtree(temp_dir, True) shutil.rmtree(temp_dir, True)

Loading…
Cancel
Save