From 6a05169568a44bf7bd86cd0edaeeb35670907b40 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Fri, 9 Sep 2011 19:12:02 +0000 Subject: [PATCH] Use check_call(), not check_output() There is user interaction when the svn credential isn't cached. (Duh) TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7864007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100462 0039d316-1c4b-4281-b951-d872f2087c98 --- trychange.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/trychange.py b/trychange.py index 50e32b859b..a40b6e12cf 100755 --- a/trychange.py +++ b/trychange.py @@ -401,10 +401,9 @@ def _SendChangeSVN(options): if scm.SVN.AssertVersion("1.5")[0]: command.append('--no-ignore') - subprocess2.check_output( - command, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT) + subprocess2.check_call(command) except subprocess2.CalledProcessError, e: - raise NoTryServerAccess(' '.join(e.cmd) + '\nOuput:\n' + e.stdout) + raise NoTryServerAccess(str(e)) finally: temp_file.close() shutil.rmtree(temp_dir, True)