From 665a4398b54fdee66c2c9d16c88823c7c55f2e6b Mon Sep 17 00:00:00 2001 From: Aaron Gable Date: Thu, 29 Jun 2017 10:53:46 -0700 Subject: [PATCH] git-cl-upload: warn if no rietveld project specified Bug: 600469 Change-Id: I4ebc7b0f28204ae4a4649e51d6aac8fc2f43ed20 Reviewed-on: https://chromium-review.googlesource.com/556152 Reviewed-by: Andrew Bonventre Commit-Queue: Aaron Gable --- git_cl.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/git_cl.py b/git_cl.py index 5d0375c01..98b474ac9 100755 --- a/git_cl.py +++ b/git_cl.py @@ -2311,6 +2311,11 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase): project = settings.GetProject() if project: upload_args.extend(['--project', project]) + else: + print() + print('WARNING: Uploading without a project specified. Please ensure ' + 'your repo\'s codereview.settings has a "PROJECT: foo" line.') + print() try: upload_args = ['upload'] + upload_args + args