From 5db8209d92b3766801628223898432b658b87c32 Mon Sep 17 00:00:00 2001 From: Aaron Gable Date: Thu, 17 Nov 2016 10:52:08 -0800 Subject: [PATCH] Don't return 1 when failing to add Gerrit CCs This causes other automated tooling to think that the entire upload has failed, when really only a small part of it has. BUG=666160 Change-Id: I0d646e77c54330d642097aebe70ec145ae291267 Reviewed-on: https://chromium-review.googlesource.com/412281 Commit-Queue: Andrii Shyshkalov Reviewed-by: Andrii Shyshkalov --- git_cl.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/git_cl.py b/git_cl.py index 19f97d590..4d8778cba 100755 --- a/git_cl.py +++ b/git_cl.py @@ -2847,11 +2847,8 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): if change_desc.get_cced(): cc.extend(change_desc.get_cced()) if cc: - errors = gerrit_util.AddReviewers( + gerrit_util.AddReviewers( self._GetGerritHost(), self.GetIssue(), cc, is_reviewer=False) - if errors: - return 1 - return 0 def _AddChangeIdToCommitMessage(self, options, args):