From 450e50d758fe1cdb9dea12134afd60ad8c31265f Mon Sep 17 00:00:00 2001 From: "mirandac@chromium.org" Date: Fri, 18 Feb 2011 16:45:29 +0000 Subject: [PATCH] I am a huge fan of drover, but discovered this morning that it wasn't working with my svn client, even though it was version 1.6.15. I did some poking around, and found that because SlikSvn doesn't give a revision number in its --version information dump, it was failing to match the regex in drover.py. I then noticed that the revision number wasn't being used for anything, so I removed it and everything worked great again. Review URL: http://codereview.chromium.org/6538055 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@75398 0039d316-1c4b-4281-b951-d872f2087c98 --- drover.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drover.py b/drover.py index 96a1724f5..abd942aa8 100755 --- a/drover.py +++ b/drover.py @@ -132,13 +132,12 @@ def getSVNVersionInfo(): stderr=subprocess.PIPE).stdout.readlines() info = {} for line in svn_info: - match = re.search(r"svn, version ((\d+)\.(\d+)\.(\d+)) \(r(\d+)\)", line) + match = re.search(r"svn, version ((\d+)\.(\d+)\.(\d+))", line) if match: info['version'] = match.group(1) info['major'] = int(match.group(2)) info['minor'] = int(match.group(3)) info['patch'] = int(match.group(4)) - info['revision'] = match.group(5) return info return None