telemetry: Fix imports

Logging was missing from __init__.py which broke under mac. This adds
that back in and remove unused imports from other files. The os check
is also moved up to be the first thing we look for since is_google_host
does not work with mac at the moment.

Bug:326277821
Change-Id: I3f28838d367eb9583332fd33ad35d71c0851fe4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6604498
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
changes/98/6604498/4
Struan Shrimpton 2 months ago committed by LUCI CQ
parent 68f0a29a64
commit 3be09c6d74

@ -2,19 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
from typing import Optional from typing import Optional
import os import logging
import socket import socket
import sys import sys
import pathlib
from opentelemetry import context as otel_context_api
from opentelemetry import trace as otel_trace_api from opentelemetry import trace as otel_trace_api
from opentelemetry.sdk import ( from opentelemetry.sdk import (
resources as otel_resources, resources as otel_resources,
trace as otel_trace_sdk, trace as otel_trace_sdk,
) )
from opentelemetry.sdk.trace import export as otel_export from opentelemetry.sdk.trace import export as otel_export
from opentelemetry.util import types as otel_types
from . import config from . import config
from . import clearcut_span_exporter from . import clearcut_span_exporter
@ -71,11 +68,11 @@ def is_google_host() -> bool:
def initialize(service_name, def initialize(service_name,
notice=DEFAULT_BANNER, notice=DEFAULT_BANNER,
cfg_file=config.DEFAULT_CONFIG_FILE): cfg_file=config.DEFAULT_CONFIG_FILE):
if not is_google_host(): # TODO(326277821): Add support for other platforms
if not sys.platform.startswith('linux'):
return return
# TODO(326277821): Add support for other platforms if not is_google_host():
if not sys.platform == 'linux':
return return
cfg = config.Config(cfg_file) cfg = config.Config(cfg_file)

@ -5,7 +5,6 @@
"""Utility for opting in or out of metrics collection""" """Utility for opting in or out of metrics collection"""
import argparse import argparse
import sys import sys
import pathlib
import config import config

@ -5,7 +5,6 @@
import getpass import getpass
import re import re
import pytest
from .proto import trace_span_pb2 from .proto import trace_span_pb2
from . import anonymization from . import anonymization

@ -9,9 +9,8 @@ import time
import urllib.error import urllib.error
import urllib.request import urllib.request
from typing import Callable, Dict, Optional, Pattern, Sequence, Tuple from typing import Callable, Dict, Optional, Sequence
from google.protobuf import ( from google.protobuf import (
json_format,
message as proto_msg, message as proto_msg,
struct_pb2, struct_pb2,
) )

@ -5,20 +5,12 @@
import contextlib import contextlib
from typing import Any, Iterator, Optional, Sequence from typing import Any, Iterator, Optional, Sequence
import logging
import pathlib
import sys
from opentelemetry import context as otel_context_api from opentelemetry import context as otel_context_api
from opentelemetry import trace as otel_trace_api from opentelemetry import trace as otel_trace_api
from opentelemetry.sdk import trace as otel_trace_sdk from opentelemetry.sdk import trace as otel_trace_sdk
from opentelemetry.util import types as otel_types from opentelemetry.util import types as otel_types
from . import config
from . import clearcut_span_exporter
from . import detector
@contextlib.contextmanager @contextlib.contextmanager
def use_span( def use_span(
span: otel_trace_api.Span, span: otel_trace_api.Span,

@ -8,7 +8,6 @@ from typing import Sequence
from opentelemetry import trace as trace_api from opentelemetry import trace as trace_api
from opentelemetry.sdk import trace as trace_sdk from opentelemetry.sdk import trace as trace_sdk
from opentelemetry.sdk import resources
from opentelemetry.sdk.trace import export as export_sdk from opentelemetry.sdk.trace import export as export_sdk
from . import trace as trace from . import trace as trace

Loading…
Cancel
Save